Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim commented on pull request blender/blender#129783 2024-11-05 22:26:31 +01:00
Sculpt: Simplify & optimize position undo with shape keys

BLI_assert(indices.size() == compressed.size())

Sean Kim commented on pull request blender/blender#129783 2024-11-05 22:26:30 +01:00
Sculpt: Simplify & optimize position undo with shape keys

compressed seems a bit misleading here, especially given future plans to attempt to apply compression in general to the undo steps. That being said I don't have a good recommendation here... maybe flattened?

Sean Kim commented on pull request blender/blender#129783 2024-11-05 22:18:28 +01:00
Sculpt: Simplify & optimize position undo with shape keys

Manual testing done:

  • Sculpting multiple strokes and undos with:
    • Only base mesh
    • Base Mesh + Shape Key
    • Base Mesh + Shape Key + Subdiv Modifier
      • On Basis / Relative Shape…
Sean Kim suggested changes for blender/blender#129790 2024-11-05 21:37:36 +01:00
Fix #129749: Use consistent GPv3 color settings in different modes

Aside from the inline code comment, this behaves as expected in mesh painting modes.

Sean Kim commented on pull request blender/blender#129790 2024-11-05 21:37:35 +01:00
Fix #129749: Use consistent GPv3 color settings in different modes

I don't understand why we pass nullptr here, it seems like this would cause a crash eventually from a null dereference in BKE_paint_use_unified_color

Sean Kim commented on pull request blender/blender#128953 2024-11-05 19:14:23 +01:00
Texture Paint: Add color jitter to strokes

Some high-level feedback that was mentioned in the recent module meeting:

  • Overall we like the idea and think this has good potential for both general artistic texture painting and potentially…
Sean Kim commented on pull request blender/blender#128953 2024-11-05 19:03:58 +01:00
Texture Paint: Add color jitter to strokes

@blender-bot package

Sean Kim created pull request blender/blender#129834 2024-11-05 02:53:49 +01:00
WIP: Refactor: Sculpt: Split undo step data
Sean Kim created branch split-undo-data in Sean-Kim/blender 2024-11-05 02:53:31 +01:00
Sean Kim pushed to split-undo-data at Sean-Kim/blender 2024-11-05 02:53:31 +01:00
c214fb8f1a WIP: Refactor: Sculpt: Split undo step data
94a5f541c3 GPU: Improve GLSL-C++ compatibility
Compare 2 commits »
Sean Kim commented on issue blender/blender#129826 2024-11-05 01:22:58 +01:00
Brush selection in tool tab does not affect the selected tool in Toolbar

I'm not entirely certain what the behavior here should be. It seems a bit odd to me to be able to change the active tool from within the right-side tool menu. Perhaps this should automatically…

Sean Kim created pull request blender/blender#129828 2024-11-05 00:42:30 +01:00
Refactor: Sculpt: Avoid storing extra undo data on geometry_push
Sean Kim pushed to remove-extra-undo-data-geometry-push at Sean-Kim/blender 2024-11-05 00:42:02 +01:00
11b8f00b21 Refactor: Sculpt: Avoid storing extra undo data on geometry_push
c9d50a316b Cleanup: Remove unneeded USD cmake check/guard
88f945d068 Geometry Nodes: Avoid potential copy of attribute in simulation bake mixing
9ceb33fedb Merge branch 'blender-v4.3-release'
426ed8c61e Fix #129425: Using Voxel Remesh in sculpt mode can crash
Compare 10 commits »
Sean Kim created branch remove-extra-undo-data-geometry-push in Sean-Kim/blender 2024-11-05 00:42:02 +01:00
Sean Kim closed issue blender/blender#93196 2024-11-04 23:34:23 +01:00
Sculpt crash in certain scenario (PBVH vert number does not match)
Sean Kim commented on issue blender/blender#93196 2024-11-04 23:34:17 +01:00
Sculpt crash in certain scenario (PBVH vert number does not match)

I'm going to close this issue since it no longer seems to be present. I do not get the assert mentioned in a current build of main, and we also provide a warning on the decimate modifier that it…

Sean Kim closed issue blender/blender#119292 2024-11-04 23:07:45 +01:00
Sculpt: Remesh operator crashes with Subdivision Modifier
Sean Kim commented on issue blender/blender#119292 2024-11-04 23:07:41 +01:00
Sculpt: Remesh operator crashes with Subdivision Modifier

This is actually the same issue as #86072, closing as a duplicate