Sean Kim Sean-Kim
2 Followers · 0 Following
  • Joined on 2023-12-14
Overview Repositories
5
 Projects Public Activity Starred Repositories
1
Sean Kim pushed to main at blender/blender 2024-08-24 00:22:50 +02:00
0e5c6ec33f Cleanup: Remove sculpt_brush_types.cc
Sean Kim commented on pull request blender/blender#126708 2024-08-23 23:46:07 +02:00
Cleanup: Remove sculpt_brush_types.cc

@blender-bot build

Sean Kim created pull request blender/blender#126708 2024-08-23 23:42:52 +02:00
Cleanup: Remove sculpt_brush_types.cc
Sean Kim created branch remove-sculpt-brush-types in Sean-Kim/blender 2024-08-23 23:30:20 +02:00
Sean Kim pushed to remove-sculpt-brush-types at Sean-Kim/blender 2024-08-23 23:30:20 +02:00
5109d84f97 Cleanup: Remove sculpt_brush_types.cc
d5e591b3dc Refactor: Sculpt: Add helper function to access all BVH nodes
0ff0e41c62 Cleanup: Sculpt: Remove unnecessary function prefixes in sculpt_pose.cc
fb7496f325 Cleanup: Sculpt: Simplify local function naming in sculpt.cc
c394aa9cea Cleanup: Add r_ prefix for ED_view3d_global_to_vector
Compare 10 commits »
Sean Kim commented on pull request blender/blender#126621 2024-08-23 23:09:52 +02:00
Fix: GPv3: Avoid NaN when reprojecting

After thinking about this more and experimenting a bit with the UI side of things, I think adding the ViewPlane option may be a mistake. It seems more like an orthogonal concern, since the…

Sean Kim commented on pull request blender/blender#126621 2024-08-23 22:06:43 +02:00
Fix: GPv3: Avoid NaN when reprojecting

Since the change described above seems a bit more involved, I opted to keep this PR as just changing the default case; I'll submit and link another one related to the new DrawingPlacementDepth…

Sean Kim pushed to fix-drawing-placement at Sean-Kim/blender 2024-08-23 22:02:24 +02:00
fbd820dfd8 Remove ReprojectMode::View change
Sean Kim deleted branch gp-reproject-ub from Sean-Kim/blender 2024-08-23 21:55:38 +02:00
Sean Kim merged pull request blender/blender#126623 2024-08-23 21:55:34 +02:00
Fix: Avoid potential UB when reprojecting GP
Sean Kim pushed to main at blender/blender 2024-08-23 21:55:33 +02:00
701b148530 Fix: Avoid potential UB when reprojecting GP
Sean Kim deleted branch break-up-paint-header from Sean-Kim/blender 2024-08-23 21:54:42 +02:00
Sean Kim merged pull request blender/blender#126668 2024-08-23 21:54:38 +02:00
Cleanup: Break apart `paint_intern.hh`
Sean Kim pushed to main at blender/blender 2024-08-23 21:54:37 +02:00
84615b0eac Cleanup: Break apart paint_intern.hh
Sean Kim commented on pull request blender/blender#126621 2024-08-23 11:14:45 +02:00
Fix: GPv3: Avoid NaN when reprojecting

The naming makes more sense with that explanation - I think the path forward here is to create a new enum DrawingPlacementDepth::ViewPlane and add explicit support for it in the project,…

Sean Kim commented on pull request blender/blender#126621 2024-08-23 10:53:33 +02:00
Fix: GPv3: Avoid NaN when reprojecting

I'm not familiar with the flags used in the other constructor, but the reason I swapped this here is due to this case:

    else if (align_flag & GP_PROJECT_DEPTH_VIEW) {
      depth_ =…
Sean Kim opened issue blender/blender#126672 2024-08-23 07:33:26 +02:00
StrokeCache Refactor
Sean Kim commented on pull request blender/blender#126668 2024-08-23 01:15:13 +02:00
Cleanup: Break apart paint_intern.hh

@blender-bot build

Sean Kim created pull request blender/blender#126668 2024-08-23 01:13:57 +02:00
Cleanup: Break apart paint_intern.hh
Sean Kim pushed to break-up-paint-header at Sean-Kim/blender 2024-08-23 01:10:09 +02:00
5271702135 Cleanup: Break apart paint_intern.hh