Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim pushed to break-up-paint-header at Sean-Kim/blender 2024-08-23 00:58:40 +02:00
558f0db392 Cleanup: Break apart paint_intern.hh
d5e591b3dc Refactor: Sculpt: Add helper function to access all BVH nodes
0ff0e41c62 Cleanup: Sculpt: Remove unnecessary function prefixes in sculpt_pose.cc
fb7496f325 Cleanup: Sculpt: Simplify local function naming in sculpt.cc
c394aa9cea Cleanup: Add r_ prefix for ED_view3d_global_to_vector
Compare 10 commits »
Sean Kim created branch break-up-paint-header in Sean-Kim/blender 2024-08-23 00:58:39 +02:00
Sean Kim commented on pull request blender/blender#126581 2024-08-22 23:40:41 +02:00
GPv3: Add Bake Grease Pencil Animation operator

Pending separate PR: !126621

Sean Kim deleted branch cleanup-view3d-project from Sean-Kim/blender 2024-08-22 23:24:16 +02:00
Sean Kim pushed to main at blender/blender 2024-08-22 23:24:13 +02:00
c394aa9cea Cleanup: Add r_ prefix for ED_view3d_global_to_vector
Sean Kim merged pull request blender/blender#126666 2024-08-22 23:24:12 +02:00
Cleanup: Add r_ prefix for ED_view3d_global_to_vector
Sean Kim commented on pull request blender/blender#126666 2024-08-22 22:46:38 +02:00
Cleanup: Add r_ prefix for ED_view3d_global_to_vector
Sean Kim created pull request blender/blender#126666 2024-08-22 22:46:06 +02:00
Cleanup: Add r_ prefix for ED_view3d_global_to_vector
Sean Kim created branch cleanup-view3d-project in Sean-Kim/blender 2024-08-22 22:45:27 +02:00
Sean Kim pushed to cleanup-view3d-project at Sean-Kim/blender 2024-08-22 22:45:27 +02:00
79eaa1ab4b Cleanup: Add r_ prefix for ED_view3d_global_to_vector
Sean Kim approved blender/blender#126382 2024-08-22 20:41:53 +02:00
Sculpt: Remove duplicate BVH tree positions storage

Looks good, one final comment about the asserts for me

Sean Kim commented on pull request blender/blender#126382 2024-08-22 20:41:51 +02:00
Sculpt: Remove duplicate BVH tree positions storage

Apologies - I thought I submitted this comment on the previous discussion we had; moving it here so it's easier to see. The reason I thought the assert was pointless is that it does the same check as the mesh_topology_count_matches & then doesn't do any further processing, it just returns out. Similarly in face_normals_cache_eval

Sean Kim commented on pull request blender/blender#126621 2024-08-22 04:48:28 +02:00
Fix: GPv3: Avoid NaN when reprojecting
Sean Kim commented on pull request blender/blender#126623 2024-08-22 04:48:08 +02:00
Fix: Avoid potential UB when reprojecting GP
Sean Kim created pull request blender/blender#126623 2024-08-22 04:47:24 +02:00
Fix: Avoid potential UB when reprojecting GP
Sean Kim created branch gp-reproject-ub in Sean-Kim/blender 2024-08-22 04:44:23 +02:00
Sean Kim pushed to gp-reproject-ub at Sean-Kim/blender 2024-08-22 04:44:23 +02:00
0234e503e6 Fix: Avoid potential UB when reprojecting GP
Sean Kim pushed to grease-pencil-bake-object-transform at Sean-Kim/blender 2024-08-22 04:32:36 +02:00
8ee22fcb29 Wire up reprojection
Sean Kim created pull request blender/blender#126621 2024-08-22 03:12:58 +02:00
Fix: GPv3: Avoid NaN when reprojecting
Sean Kim created branch fix-drawing-placement in Sean-Kim/blender 2024-08-22 03:12:19 +02:00