Sean Kim Sean-Kim
2 Followers · 0 Following
  • Joined on 2023-12-14
Overview Repositories
5
 Projects Public Activity Starred Repositories
1
Sean Kim created pull request blender/blender#126332 2024-08-14 21:03:11 +02:00
Fix #126330: Crash when using Color Filter
Sean Kim created branch fix-126330 in Sean-Kim/blender 2024-08-14 21:01:55 +02:00
Sean Kim pushed to fix-126330 at Sean-Kim/blender 2024-08-14 21:01:55 +02:00
fe02ae80d5 Fix #126330: Crash when using Color Filter
27bc773c0b Cleanup: Formatting
e04707bf2a Cleanup: Sculpt: Remove last usage of PBVHVertRef visibility function
70a24258c6 Sculpt: Remove unused positions array copy with some deform modifiers
92d935a205 Build: Ambiguous call to isfinite for MSVC 17.11
Compare 6 commits »
Sean Kim commented on issue blender/blender#126330 2024-08-14 20:57:06 +02:00
Sculpt: Crash when using Color Filter

Should have a fix up shortly

Sean Kim commented on issue blender/blender#126330 2024-08-14 20:48:13 +02:00
Sculpt: Crash when using Color Filter 
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /Users/seankim/Projects/blender-git/blender/lib/macos_arm64/tbb/include/tbb/parallel_reduce.h:176:19 in 
/Library/Developer/CommandLine…
Sean Kim commented on issue blender/blender#126330 2024-08-14 20:44:45 +02:00
Sculpt: Crash when using Color Filter

Hmm, I don't think its only in that PR build - I'm getting a crash on today's daily (8f996f178604)

Sean Kim commented on issue blender/blender#126330 2024-08-14 20:41:18 +02:00
Sculpt: Crash when using Color Filter

Checking against today's daily to verify

Sean Kim commented on issue blender/blender#126330 2024-08-14 20:35:54 +02:00
Sculpt: Crash when using Color Filter

I can't seem to repro this on current main

Sean Kim deleted branch boundary-data-init-refactor from Sean-Kim/blender 2024-08-14 19:35:29 +02:00
Sean Kim pushed to main at blender/blender 2024-08-14 19:35:26 +02:00
e7787f24aa Refactor: Simplify boundary::preview_data_init parameters
Sean Kim merged pull request blender/blender#126256 2024-08-14 19:35:26 +02:00
Refactor: Simplify boundary::preview_data_init parameters
Sean Kim pushed to boundary-data-init-refactor at Sean-Kim/blender 2024-08-14 19:32:18 +02:00
866f4905cc Remove unnecessary parentheses
Sean Kim commented on pull request blender/blender#126255 2024-08-14 19:13:55 +02:00
GPv3: Add ReprojectMode enum and DrawingPlacement constructor

Bit unfortunate that we have to duplicate some of the other constructor, but I guess it's not too bad. Just added a comment about the enum.

I think this can be solved in a follow up commit…

Sean Kim pushed to gp-drawing-placement at Sean-Kim/blender 2024-08-14 19:11:31 +02:00
c968300ed3 Account for layer transform like in other constructor
e01cd607d9 Merge branch 'main' of projects.blender.org:blender/blender into gp-drawing-placement
9d04027ab6 Use int8_t over uint8_t
93054f9a0e Refactor: Sculpt: Move original position restore to brush deform step
3cd26916f4 Cycles render test: Enable OIDN tests
Compare 99 commits »
Sean Kim created pull request blender/blender#126326 2024-08-14 18:52:32 +02:00
Cleanup: Add int8_t specifier to ED_grease_pencil.hh enum classes
Sean Kim created branch gp-enum-class-cleanup in Sean-Kim/blender 2024-08-14 18:46:58 +02:00
Sean Kim pushed to gp-enum-class-cleanup at Sean-Kim/blender 2024-08-14 18:46:58 +02:00
8240915145 Cleanup: Add int8_t specifier to ED_grease_pencil.hh enum classes
593e70dc53 Fix: Geometry Nodes: typo in node description
4f491aca80 Fix #126286: crash when opening blend file with point cache
7207015a58 Fix #125070: Handle "Unit Scale" correctly in the STL and PLY importers
5b75c5b89d Refactor: Sculpt: Specialize expand operator boundary calculation
Compare 10 commits »
Sean Kim commented on pull request blender/blender#126255 2024-08-14 03:06:51 +02:00
GPv3: Add ReprojectMode enum and DrawingPlacement constructor

Actually - I just took a look at the rest of the file; it uses int8_t for enum class (InterpolateFlipMode and InterpolateLayerMode), should this do the same?

Sean Kim pushed to gp-drawing-placement at Sean-Kim/blender 2024-08-14 02:58:24 +02:00
264afeb616 add uint8_t specifier to new enum class
Sean Kim deleted branch fix-126199 from Sean-Kim/blender 2024-08-14 02:54:32 +02:00