Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim commented on pull request blender/blender#130241 2024-11-16 16:41:47 +01:00
Subdiv: Start replacement of "converter" abstraction

You're right, I completely forgot that fact, whoops!

Sean Kim commented on pull request blender/blender#130363 2024-11-16 04:12:18 +01:00
Cleanup: Convert BKE_multires.hh enum to enum class
Sean Kim created pull request blender/blender#130363 2024-11-16 04:11:37 +01:00
Cleanup: Convert BKE_multires.hh enum to enum class
Sean Kim pushed to bke-multires-enum-change at Sean-Kim/blender 2024-11-16 04:09:22 +01:00
fc9232e28e Cleanup: Convert BKE_multires.hh enum to enum class
Sean Kim created branch bke-multires-enum-change in Sean-Kim/blender 2024-11-16 04:09:22 +01:00
Sean Kim created pull request blender/blender#130362 2024-11-16 03:28:58 +01:00
WIP: Allow memfile undo while in sculpt mode
Sean Kim created branch revert-undo-change in Sean-Kim/blender 2024-11-16 03:27:10 +01:00
Sean Kim pushed to revert-undo-change at Sean-Kim/blender 2024-11-16 03:27:10 +01:00
c26af731b6 WIP: Allow memfile undo while in sculpt mode
Sean Kim pushed to subdivide-undo-push at Sean-Kim/blender 2024-11-16 03:22:15 +01:00
57d07d5bca WIP: Fix: Support undoing subdivisions in sculpt mode
Sean Kim created pull request blender/blender#130361 2024-11-16 03:20:03 +01:00
WIP: Fix: Support undoing subdivisions in sculpt mode
Sean Kim created branch subdivide-undo-push in Sean-Kim/blender 2024-11-16 03:18:22 +01:00
Sean Kim pushed to subdivide-undo-push at Sean-Kim/blender 2024-11-16 03:18:22 +01:00
bfa9e2db32 WIP: Fix: Support undoing subdivisions in sculpt mode
Sean Kim created branch cleanup-subdivide-op in Sean-Kim/blender 2024-11-15 02:10:54 +01:00
Sean Kim pushed to cleanup-subdivide-op at Sean-Kim/blender 2024-11-15 02:10:54 +01:00
ef3a72cfb2 Cleanup: Avoid setting multires level twice when subdividing
Sean Kim commented on pull request blender/blender#130253 2024-11-15 00:46:28 +01:00
Subdiv: Warn when no object is selected for subdivision_set

I don't think we should go further in this direction. There are many small scenarios where it can accidentally or intentionally happen to have an object active but not selected. Is it…

Sean Kim commented on issue blender/blender#130200 2024-11-14 23:58:45 +01:00
Vulkan: Repeated Crashes in Sculpt Mode

@PratikPB2123 I think the more likely root cause here based on their most recent comment is something related to Vulkan, not necessarily the brush being used - possibly a memory leak given the…

Sean Kim deleted branch calc-mesh-intersect-data from Sean-Kim/blender 2024-11-14 23:52:54 +01:00
Sean Kim pushed to main at blender/blender 2024-11-14 23:52:49 +01:00
1e357cdca8 Cleanup: Change calc_*_intersect_data functions to take depth by value
Sean Kim merged pull request blender/blender#130256 2024-11-14 23:52:49 +01:00
Cleanup: Change calc_*_intersect_data functions to take depth by value
Sean Kim commented on pull request blender/blender#130241 2024-11-14 23:51:14 +01:00
Subdiv: Start replacement of "converter" abstraction

Just small inline comments so far; changes seem sane but I haven't pulled this down to test at all yet.