Sietse Brouwer SietseB
  • Joined on 2023-02-08
Sietse Brouwer commented on pull request blender/blender#119323 2024-03-12 00:05:33 +01:00
GPv3: Tint tool

This should be radius *= extension_sample.pressure. The falloff curve is affecting the strength (brush influence), not the brush radius.

Sietse Brouwer commented on pull request blender/blender#118273 2024-03-11 23:16:27 +01:00
GPv3: Overlay for Weight Paint mode

@filedescriptor Not entirely sure about the status of this one... Should I give my two cents on the no_active_weight matter? Or change something in the PR?

Sietse Brouwer pushed to gpv3-weight-paint-tools at SietseB/blender 2024-03-11 23:10:29 +01:00
756f77cc71 Code review pass
Sietse Brouwer pushed to gpv3-weight-paint-tools at SietseB/blender 2024-03-07 23:10:52 +01:00
2f1f297fba Code review: Build KDTree on every #on_stroke_extended event
98a7d8b84b Merge branch 'main' into gpv3-weight-paint-tools
4e196f916c Cleanup: Remove unnecessary AssetListStorage class
ab3b8df693 Fix #116249: Compositor: Gizmos ignore backdrop transformations
d99fffc460 GPv3: Legacy Conversion: Animation: Optimize fcurves handling.
Compare 533 commits »
Sietse Brouwer pushed to gpv3-cutter-tool at SietseB/blender 2024-03-07 16:48:45 +01:00
a8c62221bf Apply commit #119151 (Fix for end caps with hard eraser)
Sietse Brouwer created branch gpv3-autolock-layer-group in SietseB/blender 2024-03-06 13:39:41 +01:00
Sietse Brouwer pushed to gpv3-autolock-layer-group at SietseB/blender 2024-03-06 13:39:41 +01:00
0cfe41c9f0 Make autolock layers and autolock layer groups mutually exclusive
2686ed84ee Autolock inactive layer groups
eb91828aab GPU: Add maximum image units to GPU capabilities
d27ddccc60 Cleanup: use macro to avoid repetition in BPY_init_modules
ed5fb3eaba Cleanup: various non-functional C++ changes
Compare 10 commits »
Sietse Brouwer deleted branch gpv3-copy-paste from SietseB/blender 2024-03-04 22:32:12 +01:00
Sietse Brouwer pushed to gpv3-cutter-tool at SietseB/blender 2024-03-04 22:31:26 +01:00
3e39840bcd Cleanup after merge with main
06f552fd80 Merge branch 'main' into gpv3-cutter-tool
ce80cc1526 Cleanup: Remove unused UI button creation function
82448c1e4d Fix: Typo in latest commit
4ab6feb5bd Fix: GPU Compositor results are sometimes clipped
Compare 1345 commits »
Sietse Brouwer commented on pull request blender/blender#118347 2024-03-03 13:00:20 +01:00
GPv3: Weight Paint tools (Draw, Blur, Average, Smear, Sample weight)

Thanks again for the (joint) review! All right, the KDTree. If I'm understanding correctly, your proposal is to build a KDTree at every on_stroke_extended event. So, at a rate of let's say 20…

Sietse Brouwer pushed to gpv3-weight-paint-tools at SietseB/blender 2024-03-03 10:31:52 +01:00
0a7bac7d7d Code review pass
Sietse Brouwer commented on pull request blender/blender#114145 2024-03-01 17:03:55 +01:00
GPv3: Copy and Paste operators for copying strokes and points

The material_index attribute is so enormously common on GP curves, I would say it's practically always there. I could add an if, something like:

if (clipboard.materials.size() > 1 
Sietse Brouwer pushed to gpv3-copy-paste at SietseB/blender 2024-02-29 23:57:33 +01:00
1c011b5514 Remap the clipboard material indices after pasting
Sietse Brouwer commented on pull request blender/blender#114145 2024-02-29 21:22:48 +01:00
GPv3: Copy and Paste operators for copying strokes and points

Perhaps I was too conservative, but I treated join_geometries as a black box, i.e. not knowing what the index range of the pasted curves is after the join. When I have a CurvesGeometry A with…

Sietse Brouwer pushed to gpv3-copy-paste at SietseB/blender 2024-02-29 21:04:45 +01:00
875b0f62b3 Code review pass
Sietse Brouwer commented on pull request blender/blender#114145 2024-02-29 18:15:29 +01:00
GPv3: Copy and Paste operators for copying strokes and points

I've renamed it. It's for efficiently remapping the material indices from the source object to the paste target. When the source has 6 materials, you need a remap array of 6 positions. The…

Sietse Brouwer pushed to gpv3-copy-paste at SietseB/blender 2024-02-29 18:03:28 +01:00
54326f1c62 Code review pass, using session_uid now for mapping materials
Sietse Brouwer closed issue blender/blender#118865 2024-02-29 12:56:04 +01:00
GPv3: Memory leak when emptying a layer
Sietse Brouwer commented on issue blender/blender#118865 2024-02-29 12:56:01 +01:00
GPv3: Memory leak when emptying a layer

Let's close the issue then. Probably some oddity in the Debug build. No need to chase ghosts!

Sietse Brouwer pushed to gpv3-copy-paste at SietseB/blender 2024-02-28 23:47:12 +01:00
dcbc1d71c5 Better error reporting when active layer is not editable