geometry::smooth_curve_attribute
for weight smoothing
They should really advertise all those useful attributes functions! 😄
It's fine by me, using smooth_curve_attribute
. The results will be a bit different, compared to GPv2:
- Gaussian blur…
I'll ask Falk about it. If I remember correctly, using the attributes system was preferred over using the helper function.
Auto-format should remove the space between *
and op
, I guess?
I know this PR is already merged, but a 'review after the facts' was the easiest way for me to address a few things 😉
It would be nicer to have a poll here that checks the existence of any vertex group, e.g. !BLI_listbase_is_empty(BKE_object_defgroup_list(object))
. Then the menu item will be properly greyed out when there is no vertex group in the object.
There is no guarantee the active vertex group exists in the drawing. Instead of asserting, it should just skip the drawing (with a return
) when the vertex group isn't used (drawing_vgroup_index == -1
).
There should be a check-and-report here when the active vertex group is locked.