Sietse Brouwer SietseB
  • Joined on 2023-02-08
Sietse Brouwer pushed to gpv3-weight-paint-smooth-operator at SietseB/blender 2024-09-05 12:17:03 +02:00
0774b617e3 Use geometry::smooth_curve_attribute for weight smoothing
1635550cae Merge branch 'main' into gpv3-weight-paint-smooth-operator
871b25b219 Geometry: generalize attribute filters beyond just for anonymous attributes
f883cb77ba Fix #127117: NLA Channels missing update on animated object visibility
69557e316c Fix #127174: GPv3 misses ID selector in Properties Editor Data tab
Compare 509 commits »
Sietse Brouwer commented on pull request blender/blender#126429 2024-08-21 22:09:30 +02:00
GPv3: Operator Smooth active vertex group

They should really advertise all those useful attributes functions! 😄 It's fine by me, using smooth_curve_attribute. The results will be a bit different, compared to GPv2:

  • Gaussian blur…
Sietse Brouwer pushed to gpv3-weight-paint-normalize-operators at SietseB/blender 2024-08-17 11:15:48 +02:00
bb47577897 Use existing poll function
3cd1888188 Merge branch 'main' into gpv3-weight-paint-normalize-operators
6e72f00d4e Fix: UI: Wrong single editor window titles due to unset area sub-spacetype
e0b5654655 Cleanup: improve check for whether object has geometry set instances
5358d1b09a Depsgraph: avoid checking for evaluated object in draw code
Compare 106 commits »
Sietse Brouwer created pull request blender/blender#126429 2024-08-17 10:55:46 +02:00
GPv3: Operator Smooth active vertex group
Sietse Brouwer created branch gpv3-weight-paint-smooth-operator in SietseB/blender 2024-08-17 10:29:12 +02:00
Sietse Brouwer pushed to gpv3-weight-paint-smooth-operator at SietseB/blender 2024-08-17 10:29:12 +02:00
5f60cb7955 Cleanup
6ca0c3cc6e Use existing poll function
69010127b0 Merge branch 'main' into gpv3-weight-paint-smooth-operator
6fa7ff0c44 GPv3: Operator Smooth active vertex group
6e72f00d4e Fix: UI: Wrong single editor window titles due to unset area sub-spacetype
Compare 10 commits »
Sietse Brouwer commented on pull request blender/blender#126302 2024-08-14 17:06:28 +02:00
GPv3: Operators for Normalize active and Normalize all vertex groups

I'll ask Falk about it. If I remember correctly, using the attributes system was preferred over using the helper function.

Sietse Brouwer pushed to gpv3-weight-paint-normalize-operators at SietseB/blender 2024-08-14 17:01:05 +02:00
2cf7dac172 Code review
06e4f2eaf3 Merge branch 'main' into gpv3-weight-paint-normalize-operators
658b32093a Refactor: Sculpt: Replace sculpt attribute system for dynamic topology data
d065d54972 Fix: Missing sculpt overlays for dynamic topology
e612260f5c Refactor: Sculpt: Replace sculpt attribute system for persistent base data
Compare 65 commits »
Sietse Brouwer approved blender/blender#126313 2024-08-14 12:18:00 +02:00
GPv3: Few changes to invert weight operator

Two little details, looking good to me otherwise!

Sietse Brouwer commented on pull request blender/blender#126313 2024-08-14 12:17:59 +02:00
GPv3: Few changes to invert weight operator

Auto-format should remove the space between * and op, I guess?

Sietse Brouwer commented on pull request blender/blender#126313 2024-08-14 12:17:57 +02:00
GPv3: Few changes to invert weight operator

Maybe add `ob == nullptr

Sietse Brouwer closed pull request blender/blender#126303 2024-08-14 10:58:07 +02:00
GPv3: Operator Invert weights of active vertex group
Sietse Brouwer commented on pull request blender/blender#126275 2024-08-14 10:57:07 +02:00
GPv3: Invert weight operator

I know this PR is already merged, but a 'review after the facts' was the easiest way for me to address a few things 😉

Sietse Brouwer commented on pull request blender/blender#126275 2024-08-14 10:57:05 +02:00
GPv3: Invert weight operator

It would be nicer to have a poll here that checks the existence of any vertex group, e.g. !BLI_listbase_is_empty(BKE_object_defgroup_list(object)). Then the menu item will be properly greyed out when there is no vertex group in the object.

Sietse Brouwer commented on pull request blender/blender#126275 2024-08-14 10:57:04 +02:00
GPv3: Invert weight operator

Nitpick, but the style-guided way would be 1.0f.

Sietse Brouwer commented on pull request blender/blender#126275 2024-08-14 10:57:03 +02:00
GPv3: Invert weight operator

There is no guarantee the active vertex group exists in the drawing. Instead of asserting, it should just skip the drawing (with a return) when the vertex group isn't used (drawing_vgroup_index == -1).

Sietse Brouwer commented on pull request blender/blender#126275 2024-08-14 10:57:02 +02:00
GPv3: Invert weight operator

There should be a check-and-report here when the active vertex group is locked.

Sietse Brouwer created pull request blender/blender#126303 2024-08-13 23:30:08 +02:00
GPv3: Operator Invert weights of active vertex group
Sietse Brouwer created branch gpv3-weight-paint-invert-operator in SietseB/blender 2024-08-13 23:22:54 +02:00
Sietse Brouwer pushed to gpv3-weight-paint-invert-operator at SietseB/blender 2024-08-13 23:22:54 +02:00
8a58a8dfe7 GPv3: Operator Invert weights of active vertex group
58e55ef023 Fix #126293: Crash when moving mouse after enabling Dyntopo
f7d94d3e73 Fix #126252: Polyline target circle changes color randomly
4839a86984 Cleanup: BLI: Merge files
593e70dc53 Fix: Geometry Nodes: typo in node description
Compare 10 commits »