Sietse Brouwer SietseB
  • Joined on 2023-02-08
Sietse Brouwer commented on pull request blender/blender#114145 2024-02-28 23:27:14 +01:00
GPv3: Copy and Paste operators for copying strokes and points

An almost full rewrite, because the reviews took a different turn than the community task I started with ([#113248: GPv3: Copy/Paste Strokes](blender/blender#113

Sietse Brouwer pushed to gpv3-copy-paste at SietseB/blender 2024-02-28 23:15:18 +01:00
576cee52ed Cleanup: Remove unused header file
Sietse Brouwer pushed to gpv3-copy-paste at SietseB/blender 2024-02-28 23:11:57 +01:00
363e5d20f0 Rewrite: Global clipboard, make use of 'join_geometries'
9f820cc663 Merge branch 'main' into gpv3-copy-paste
0e7c9f071a Cleanup: Consolidate dyntopo bmesh detail_size calculation
b8fdef965d Merge branch 'blender-v4.1-release'
98343c0c17 Build: Upgrade Intel Graphics Compiler to 1.0.15468 on Linux
Compare 3852 commits »
Sietse Brouwer opened issue blender/blender#118865 2024-02-28 20:37:09 +01:00
GPv3: Memory leak when emptying a layer
Sietse Brouwer commented on pull request blender/blender#118347 2024-02-28 10:57:00 +01:00
GPv3: Weight Paint tools (Draw, Blur, Average, Smear, Sample weight)

The layers (threads) are keeping their own record of points under the brush, so just for the points on that layer. That way the threads can operate independently, no shared memory, no need for…

Sietse Brouwer commented on pull request blender/blender#118347 2024-02-28 10:45:29 +01:00
GPv3: Weight Paint tools (Draw, Blur, Average, Smear, Sample weight)

For the outer loop that's not an option right now, unfortunately. We need the frame_group index inside the loop; with parallel_for_each we don't have that index. I'll improve the comment above…

Sietse Brouwer deleted branch gpv3-fix-move-to-layer from SietseB/blender 2024-02-27 13:00:22 +01:00
Sietse Brouwer created pull request blender/blender#118793 2024-02-27 11:30:07 +01:00
Fix: GPv3: Move to layer operator doesn't do anything
Sietse Brouwer pushed to gpv3-fix-move-to-layer at SietseB/blender 2024-02-27 11:17:23 +01:00
fdef5147f3 Call to 'exec' in operator 'invoke'
a7d4174f8b Compositor: Unify Keying node between CPU and GPU
3295123fca Fix: Variable sized blur truncates filter kernel
ffcdf8b4dc Cleanup: Remove unused lambda capture.
be0c57a0a8 Cleanup: EEVEE: Use uint for enum specialization
Compare 10 commits »
Sietse Brouwer created branch gpv3-fix-move-to-layer in SietseB/blender 2024-02-27 11:17:23 +01:00
Sietse Brouwer commented on pull request blender/blender#118671 2024-02-26 23:51:01 +01:00
GPv3: Weight gradient tool

I can't see how we can gain much from an index mask. The gradient is an interactive tool, so at the operator's invoke we can't build a mask yet. And at the execute we already have to loop over…

Sietse Brouwer pushed to gpv3-weight-paint-overlay at SietseB/blender 2024-02-26 23:27:10 +01:00
6272f9c7ca Code review pass
Sietse Brouwer commented on pull request blender/blender#118347 2024-02-26 21:17:43 +01:00
GPv3: Weight Paint tools (Draw, Blur, Average, Smear, Sample weight)

For the case we have more than 1024 layers? ;-) It's just like the threading::parallel_for_each(drawings, [&](const MutableDrawingInfo &info) { we do in many other operators, only now at a…

Sietse Brouwer commented on pull request blender/blender#118347 2024-02-26 20:48:35 +01:00
GPv3: Weight Paint tools (Draw, Blur, Average, Smear, Sample weight)

Ha, when the mutex was used all the time, I would fully agree, of course. But adding stroke points to the brush buffer runs perfectly parallel, no mutex used there. The only rare moment the mutex…

Sietse Brouwer commented on pull request blender/blender#118347 2024-02-26 20:11:43 +01:00
GPv3: Weight Paint tools (Draw, Blur, Average, Smear, Sample weight)

Th comment was probably a bit confusing, I changed it. And I changed the for loop into threading::parallel_for_each(drawing_weights, [&](DrawingWeightData &drawing_weight) {, reflecting the…

Sietse Brouwer pushed to gpv3-weight-paint-tools at SietseB/blender 2024-02-26 19:55:38 +01:00
97af90d15b Code review pass
Sietse Brouwer commented on pull request blender/blender#118671 2024-02-26 14:11:53 +01:00
GPv3: Weight gradient tool

In general, a lot of stroke points are affected by the gradient tool. I wouldn't recommend using an index mask for that; it would be less performant.

Sietse Brouwer pushed to gpv3-weight-gradient-tool at SietseB/blender 2024-02-26 13:43:10 +01:00
9ed53a7a61 Code review pass
Sietse Brouwer pushed to gpv3-weight-paint-overlay at SietseB/blender 2024-02-23 20:51:45 +01:00
275d436c06 Merge branch 'main' into gpv3-weight-paint-overlay
03833417b3 EEVEE-Next: Fix black world probe when disabling probes
ee3291dc6d Fix double loading of asset catalogs when reloading "All" library
49c7dfe904 Fix unintended reloading of asset catalog files from disk
7f2193ff9e Merge branch 'blender-v4.1-release'
Compare 453 commits »
Sietse Brouwer commented on pull request blender/blender#118671 2024-02-23 19:47:35 +01:00
GPv3: Weight gradient tool

Little demo with Thickness and Offset modifiers: