Note: grease_pencil_weight_paint.cc only needs code review from line 275 and further. The first part is the same as in [#118347: GPv3: Weight Paint tools (Draw, Blur, Average, Smear, Sample…
retrieve_editable_drawings can return duplicates
I've reworked the whole WeightPaintOperation shebang. I hope it's progress, I'm not entirely sure about that. The code base grew from 600 to 1000 lines. But when you want to read the tools at a…
I tried a second time, but no luck with Array either.
Btw, I did a rewrite of retrieve_editable_drawings_grouped_per_frame() in grease_pencil_utils.cc, because the previous version could return duplicate drawings.
Thanks for the fast replies!
@filedescriptor Maybe I should tell a bit about what the tools share in code:
- Getting/creating the active vertex group in object and drawings.
- Getting locked…
Maybe I missed something, but I couldn't get Vector<std::atomic<int>> compiled. I concluded that Vector doesn't support atomic types. Hence the std::vector.
I did indeed, when I wrote the normalization for GPv2. The short answer is: they differ a bit, therefore the code can't be shared just out of the box. The longer answer is: the starting point of…
5407637127
Move brush_mode to WeightPaintOperation and fix for retrieving_drawings grouped per frame
Note: this PR doesn't contain the viewport overlay for showing vertex weights. The overlay code is in a separate PR: [#118273: GPv3: Overlay for Weight Paint mode](https://projects.blender.org/blen…