In my new commit I've:
- Handled all the code review remarks. Except for the one I commented on just now.
- Added segment support for the circle select operator.
- Added automatic conversion of…
I'm afraid I have to reopen this discussion. A problem with the IndexMask solution is that it returns affected points, but for an efficient segment expansion you only want to inspect the…
I noticed an UX difference: in GP, when you have a few points on a curve selected and you switch to 'curve' mode, the entire curve is selected. In '3D' curves, the curve is only selected when…
Sounds like a good plan to me. And even better: you are already on it! ;-)
@HooglyBoogly Thanks for the review! I learned a lot from it already. I replied to some of your remarks – the others I will just implement.
I know the algorithm is rather poor and scales…
Yes, that would be great, when the operators return what they changed. Then I don't have to hack into these functions, which I don't like either.
Modifying all the curves functions to support…
Will do, thanks for the insights!
I'll handle the first one.
Unfortunately, the second one isn't going to work. A drawing is just a layer, intersections can come from other layers to. So the 'project to 2d' can't be inside the…
We have to ensure then that is selection domain is always correct. That's something for a separate PR, I guess. I made a task for it. @filedescriptor
It's weird, but I noticed we can't use points.index_range(), because it always starts at 0. While points.first() gives the correct offset.
So keeping
` for (int point_i = points.first(…
I had a brainwave and added a Select Random method for segments with relative ease.