Nikita Sirgienko Sirgienko
1 Followers · 0 Following
  • Joined on 2020-12-10
Repositories
1
 Projects Public Activity Starred Repositories
Nikita Sirgienko pushed to main at blender/blender 2024-06-05 11:53:43 +02:00
2ced22611a Cycles: Fix missing adjustment for device, used for denoising
Nikita Sirgienko merged pull request blender/blender#122742 2024-06-05 11:53:43 +02:00
Cycles: Fix assert failure for CPU render with no CPU device selected
95024e02b6 Merge branch 'main' into fix_for_assert_failure_in_device_info_comp_operator
17907212aa Revert changes to the default constructor of DeviceInfo
38dd4a5e9a Fix: Wonky behaviour of "Frame All" and "Frame Selected" in the VSE
e2de34263a Nodes: don't show custom color panel for reroute nodes
8beb91118c Cleanup: make format
Compare 31 commits »
Nikita Sirgienko commented on pull request blender/blender#122742 2024-06-05 11:13:36 +02:00
Cycles: Fix assert failure for CPU render with no CPU device selected

The removal of the if() we can land immediately. I guess that will ease some stress before the bcon3, so then we can focus on making code to be more robust to errors.

Let's then limit this PR…

Nikita Sirgienko commented on pull request blender/blender#122742 2024-06-05 10:55:43 +02:00
Cycles: Fix assert failure for CPU render with no CPU device selected

The only place where we currently construct default DeviceInfo() is in the default constructor of SessionParams, where the device is expected to be explicitly configured to some real information.…

Nikita Sirgienko commented on pull request blender/blender#122742 2024-06-05 10:42:50 +02:00
Cycles: Fix assert failure for CPU render with no CPU device selected

@Sergey , so do you approve and I can merge it then?

Nikita Sirgienko commented on pull request blender/blender#122742 2024-06-05 10:08:44 +02:00
Cycles: Fix assert failure for CPU render with no CPU device selected

Do we really need to anything about this DeviceInfo at this time?

Yes, because current code would cause assert failure at any attempt to compare object created by default constructor…

Nikita Sirgienko commented on pull request blender/blender#122742 2024-06-05 09:56:11 +02:00
Cycles: Fix assert failure for CPU render with no CPU device selected

The rest I don't quite understand. This change proposes something that leads to a discrepancy between type, id, and, possibly semantic: the type is still set to DEVICE_CPU, but the id is set to…

Nikita Sirgienko commented on pull request blender/blender#122742 2024-06-04 21:34:42 +02:00
Cycles: Fix assert failure for CPU render with no CPU device selected

@blender-bot build

Nikita Sirgienko created pull request blender/blender#122742 2024-06-04 21:34:11 +02:00
Cycles: Fix assert failure for CPU render with no CPU device selected
eb97871cb9 Cycles: Fix assert failure for CPU render with no CPU device selected
7fdfa47f23 VSE: Rounded corners for timeline strips
a7171e0391 Cycles: oneAPI: Cleanup: Change packed_float3 to float3
fac32e9647 Cleanup: make format
ffa363355d Extensions: "permissions" Expect a dictionary instead of a list
Compare 10 commits »
Nikita Sirgienko deleted branch address_gpu_denoising_settings_respect from Sirgienko/blender 2024-06-03 22:41:42 +02:00
Nikita Sirgienko pushed to main at blender/blender 2024-06-03 22:41:40 +02:00
4651f8a08f Fix: Respect Blender Cycles setting for GPU denoising
Nikita Sirgienko merged pull request blender/blender#118841 2024-06-03 22:41:39 +02:00
Fix: Respect Blender Cycles setting for GPU denoising
9030dba11a Add requsted changes
770644179d Merge branch 'main' into address_gpu_denoising_settings_respect
a331ebb324 Fix #122562: Auto scrolling issues with modal operators
3a2ea7828e Fix #122599: Windows Registration/Unregistration Endless Loop
5e6760d554 Fix #122625: List of XForm ops needs to be stored at class level
Compare 34 commits »
96f1643041 Fix minor typo in the source code
Nikita Sirgienko commented on pull request blender/blender#118841 2024-06-03 13:13:03 +02:00
Fix: Respect Blender Cycles setting for GPU denoising

I don't mind such a change, but I am concerned that it might decrease the readability of the code related to this variable in the session.cpp, especially the fragment (below), which currently…

Nikita Sirgienko commented on pull request blender/blender#118841 2024-06-03 13:04:56 +02:00
Fix: Respect Blender Cycles setting for GPU denoising

@brecht, following up on our discussion from last Friday, I have completed the refactoring I mentioned and have retested the PR on various setups as a precaution. Everything is functioning well;…

Nikita Sirgienko commented on pull request blender/blender#118841 2024-06-03 12:46:47 +02:00
Fix: Respect Blender Cycles setting for GPU denoising

@blender-bot build