Sonny Campbell SonnyCampbell_Unity
1 Followers · 0 Following
  • Joined on 2022-06-01
Repositories
1
 Projects Public Activity Starred Repositories
Sonny Campbell pushed to main at SonnyCampbell_Unity/blender 2023-05-03 13:20:03 +02:00
7d5d1eae9e Cleanup: add commit to .git-blame-ignore-revs
1dcc8e6ffa Fix #107356: Cycles: improve oneAPI error handling
8775cf804e Fix compilation on Windows after f30434ac99.
88ace032a6 Metal: Storage buffer and explicit bind location support
Compare 4 commits »
Sonny Campbell pushed to main at SonnyCampbell_Unity/blender 2023-05-03 10:55:38 +02:00
bcedbdcf6f Cleanup: improve code-comments, naming, use defines, correct spelling
5f0a5c9b15 Cleanup: remove redundant path splitting in font loading
e5e17c5a81 Cleanup: rename "name" to "filepath"
7ec1456b43 Cleanup: remove BLI_path_abs call on ImBuf path when saving a sequence
d824030782 Fix blend file relative path being copied into ImBuf::filepath
Compare 1877 commits »
Sonny Campbell commented on pull request blender/blender#105375 2023-05-03 10:37:54 +02:00
USD Export: New Curves/Hair Support

Yeah you are right, thanks for catching this! I need to rethink what I was trying to do here.

f4b21f2b59 Fix comment formatting. Use canonical name for points. Update report warning to use enum names.
011ab98e7f USD doesn't support animating the type of curves. Due to this limitation we will only export curves if they match the curve type exported on the first frame.
78b9b0a917 More clear warning message for mixed curve types or mixed cyclic curves.
7995db6b99 Use custom unique_ptr deleter to handle early return cases
f41613df66 Add descriptions to unit test checks and assertions
35280b537b Move legacy curve conversion into do_write function as the context object data can and will change frame by frame.
18809994b7 Remove check_is_animated to perform default animation check on usd export
Compare 7 commits »
Sonny Campbell created pull request blender/blender#105375 2023-03-02 15:14:02 +01:00
WIP: USD Export - New Curves/Hair Support
Sonny Campbell created branch unity/T102376-USD-Curves-Export in SonnyCampbell_Unity/blender 2023-03-02 15:09:10 +01:00
9e7e2a4e5f Rebased changes onto main and resolved compilation errors due to changed api for CurvesGeometry.
5db8fadee4 Refactor logic into more consistent abstraction levels.
7443293c73 Handle memory management of curves when converting from legacy curves to new curves type with unique_ptr and freeing the memory when usd_writer_curves is disposed of.
4f0cd20be8 Remove unnecessary width interpolation code.
0c6fce335f Added logic for USD representation of periodic NURBS curves at export.
Compare 10 commits »
Sonny Campbell approved blender/blender#105185 2023-02-24 17:18:37 +01:00
#99807: Add support for exporting to USDZ - ultimate fixes

Thanks Bastien!

Sonny Campbell commented on pull request blender/blender#104556 2023-02-24 16:45:06 +01:00
T99807: Add support for exporting to USDZ

Realised the usdz_export_test.blend test blend file hasn't been uploaded yet.

Sonny Campbell commented on pull request blender/blender#104556 2023-02-24 16:07:01 +01:00
T99807: Add support for exporting to USDZ

Though yeah I just did a check and it looks like the if(usdz_filepath) is unnecessary so I'll remove it.

Sonny Campbell commented on pull request blender/blender#104556 2023-02-24 15:51:57 +01:00
T99807: Add support for exporting to USDZ

Though maybe your way is more explicit and there's less possibility for confusion?

Sonny Campbell commented on pull request blender/blender#104556 2023-02-24 15:47:53 +01:00
T99807: Add support for exporting to USDZ

I think the null terminator always evaluates to false.

So if you have an empty string with usdz_filepath[0] = '\0' then if(usdz_filepath[0]) will evaluate to false.

8a0455fbd8 Merge branch 'main' into unity/T91369-parameter-refactor
ad124d15e2 Merge remote-tracking branch 'upstream/blender-v3.5-release'
14368f4d09 Fix/Update to the i18n module settings after git submodule changes.
612965497e Curves: Avoid unnecessary allocation when calculating offsets
05637254da Cleanup: Use simpler syntax to return panel open status
Compare 168 commits »
818a360f24 Merge branch 'main' into unity/T99807-usdz-refactor
ad124d15e2 Merge remote-tracking branch 'upstream/blender-v3.5-release'
14368f4d09 Fix/Update to the i18n module settings after git submodule changes.
612965497e Curves: Avoid unnecessary allocation when calculating offsets
05637254da Cleanup: Use simpler syntax to return panel open status
Compare 46 commits »
Sonny Campbell pushed to main at SonnyCampbell_Unity/blender 2023-02-22 10:59:50 +01:00
ad124d15e2 Merge remote-tracking branch 'upstream/blender-v3.5-release'
14368f4d09 Fix/Update to the i18n module settings after git submodule changes.
612965497e Curves: Avoid unnecessary allocation when calculating offsets
05637254da Cleanup: Use simpler syntax to return panel open status
8b63966236 Revert 104438: Windows Spanning Multiple Monitors
Compare 400 commits »
Sonny Campbell commented on pull request blender/blender#104556 2023-02-22 10:56:04 +01:00
T99807: Add support for exporting to USDZ

usdc_temp_dir is the directory that contains data->unarchived_filepath, so if there is no data->unarchived_filepath there shouldn't be anything to delete.

This is basically so that we don't…

Sonny Campbell commented on pull request blender/blender#104556 2023-02-22 10:51:57 +01:00
T99807: Add support for exporting to USDZ

As a personal preference I prefer to have functions that actually do logic outside of if() conditions as I find it can be quite easy to miss, so I've moved it to the line above and stored the…

d95e3b3990 Added logs to error fail cases.
14d9b8aa8d Merge branch 'main' into unity/T99807-usdz-refactor
e1b58be9e2 Merge branch 'blender-v3.5-release'
5db40f5747 Cleanup: Mark overriden virtual call as such
c38cac9682 Merge branch 'blender-v3.5-release' into main
Compare 357 commits »