Sonny Campbell SonnyCampbell_Unity
  • Joined on 2022-06-01
Sonny Campbell deleted branch usd-curves-warning from SonnyCampbell_Unity/blender 2023-05-24 10:00:48 +02:00
Sonny Campbell deleted branch usd-curves-pinned-catmullrom from SonnyCampbell_Unity/blender 2023-05-24 09:59:41 +02:00
Sonny Campbell commented on issue blender/blender#102376 2023-05-23 13:53:42 +02:00
USD Export - New Curves/Hair Support

Hey @Lucas-Morante I've created a PR for issue number 2 you mentioned above: blender/blender#108183

This will set the correct attribute on the curve so that…

Sonny Campbell created pull request blender/blender#108183 2023-05-23 13:48:32 +02:00
USD Curve Export: Pinned CatmullRom Curve
0c0cacd0c5 In Blender the first and last points of a catmullRom curve are treated as endpoints. To account for this in USD, we must set the wrap attribute to `pinned`. This lets the client know that the first and last points are to be treated as points on the curve, and that it needs to generate "phantom" points to account for the start and end control points of a general catmullRom curve.
bceb1adb20 Fix potential buffer overflow in AssetList::setup
93ca0444f3 Fix #108129: exception editing custom properties
7d682fa107 Fix missing include
43fe7bec4f Cleanup: format
Compare 10 commits »
Sonny Campbell created branch usd-curves-pinned-catmullrom in SonnyCampbell_Unity/blender 2023-05-23 13:46:06 +02:00
Sonny Campbell commented on pull request blender/blender#108008 2023-05-17 12:58:34 +02:00
Fix warning in usd curves exporter
Sonny Campbell created pull request blender/blender#108008 2023-05-17 12:57:57 +02:00
Fix warning in usd curves exporter
Sonny Campbell pushed to usd-curves-warning at SonnyCampbell_Unity/blender 2023-05-17 12:56:29 +02:00
1cf3a46d41 Use timecode.GetValue() to fix warning about passing correct `double` type to `WM_reportf`
Sonny Campbell created branch usd-curves-warning in SonnyCampbell_Unity/blender 2023-05-17 12:56:29 +02:00
Sonny Campbell pushed to main at SonnyCampbell_Unity/blender 2023-05-17 10:02:38 +02:00
a5207ae24d Fix error returning the path length from BLI_path_normalize
e27cb91442 BLI_path: add native path canonicalize function
0099f51cdd Cleanup: sort file, uppercase booleans, add missing headers
139f4981d4 Cleanup: return early, reduce indentation
1d32a36540 Cleanup: add utility functions for checking WIN32 drive letters
Compare 382 commits »
Sonny Campbell deleted branch unity/T102376-USD-Curves-Export from SonnyCampbell_Unity/blender 2023-05-17 09:57:03 +02:00
Sonny Campbell commented on issue blender/blender#102376 2023-05-16 17:53:46 +02:00
USD Export - New Curves/Hair Support

@Lucas-Morante thanks so much, this is really helpful for me to follow up on. Are you able to share the blend file you are using at all? That way I can replicate exactly what you are seeing and do…

93fa6259b2 Update to use function-style casts as in the style guide
Sonny Campbell commented on issue blender/blender#102376 2023-05-16 12:00:08 +02:00
USD Export - New Curves/Hair Support

@Lucas-Morante Hopefully this change should be included in the next release. If you have specific use cases for it I would love to get some feedback when it's available.

I have been testing…

Sonny Campbell commented on pull request blender/blender#105375 2023-05-16 11:54:50 +02:00
USD Export: New Curves/Hair Support

I have resolved this issue with the knots now. According to the USD spec knots should be the concatentation of all batched curves so I've updated the logic there and added a test with a curve…

bbbd19ba96 Small tidy up changes
a7a1a3d3ca Update NURBS export logic so that knots are concatenated for all batched curves.
Sonny Campbell commented on pull request blender/blender#105375 2023-05-03 15:29:22 +02:00
USD Export: New Curves/Hair Support

Thanks @HooglyBoogly - yeah sorry it's been awhile since I got a chance to come back to this.

For some reason gitea won't let me resolve conversations, but from the previous comments I just…

88b89df207 Fix comment formatting. Use canonical name for `points`. Update report warning to use enum names.
465ccb3842 USD doesn't support animating the type of curves. Due to this limitation we will only export curves if they match the curve type exported on the first frame.
a1cf11eafb More clear warning message for mixed curve types or mixed cyclic curves.
57510ffdfe Use custom `unique_ptr` deleter to handle early return cases
35df5aa325 Add descriptions to unit test checks and assertions
Compare 16 commits »