Sonny Campbell SonnyCampbell_Unity
1 Followers · 0 Following
  • Joined on 2022-06-01
Repositories
1
 Projects Public Activity Starred Repositories
Sonny Campbell commented on pull request blender/blender#104459 2023-02-17 17:49:59 +01:00
Refactor: in USD importer extract read_mesh params into a struct

@blender-bot build

317d4a541a Updating the new USD_shape.reader.cc to use the USDMeshReadParams
a8411f377e Merge branch 'unity/T91369-parameter-refactor' of projects.blender.org:SonnyCampbell_Unity/blender into unity/T91369-parameter-refactor
409ee2669b Added const back onto parameters in function definitions. Fixed comment for USDMeshReadParams.
05a6b879c3 Add new create_mesh_read_params function. Remove unnecessary const.
f8088f1801 Added documentation to USDMeshReadParams. Removed unnecessary pointer usage.
Compare 6 commits »
Sonny Campbell pushed to change-working-directory at SonnyCampbell_Unity/blender 2023-02-17 11:39:20 +01:00
d3b457a1b0 Separate assertion for creating directory and changing working directory.
Sonny Campbell pushed to change-working-directory at SonnyCampbell_Unity/blender 2023-02-17 11:34:38 +01:00
e988efdbab Create test fixture to clean up test after execution.
Sonny Campbell commented on pull request blender/blender#104525 2023-02-17 11:11:32 +01:00
BLI: add function for changing working directory

Will leave this one as is, if I remove the if (BLI_exists(test_temp_dir.c_str())) check and the directory doesn't exist, it prints 40: Unable to remove directory in the test output when it…

Sonny Campbell pushed to change-working-directory at SonnyCampbell_Unity/blender 2023-02-15 13:38:32 +01:00
de3e00ccc3 Fix formatting and and comment to closing #endif.
a57007d8f4 Merge branch 'change-working-directory' of projects.blender.org:SonnyCampbell_Unity/blender into change-working-directory
a7d9b4329b Removed _apple_ functions and replaced with #if guards for CWD utility helpers
74de514dcc Add messaging to test cases. Use std::tmpnam for creating a temporary file.
96aa7ab367 T99807: Separate logic for changing working directory.
Compare 5 commits »
Sonny Campbell closed pull request SonnyCampbell_Unity/blender#1 2023-02-15 11:02:25 +01:00
Removed _apple_ functions and replaced with #if guards for CWD utility helpers
Sonny Campbell commented on pull request SonnyCampbell_Unity/blender#1 2023-02-15 11:02:25 +01:00
Removed _apple_ functions and replaced with #if guards for CWD utility helpers

Manually merged changes without the submodule updates - thanks!

Sonny Campbell commented on pull request blender/blender#104525 2023-02-15 10:55:18 +01:00
BLI: add function for changing working directory

@mont29 @dr.sybren I've merged the changes from Charles that were requested here

Sonny Campbell pushed to change-working-directory at SonnyCampbell_Unity/blender 2023-02-15 10:52:28 +01:00
a7d9b4329b Removed _apple_ functions and replaced with #if guards for CWD utility helpers
Sonny Campbell commented on pull request blender/blender#104525 2023-02-13 15:25:50 +01:00
BLI: add function for changing working directory

Done

Sonny Campbell commented on pull request blender/blender#104525 2023-02-13 15:25:36 +01:00
BLI: add function for changing working directory

Done

Sonny Campbell pushed to change-working-directory at SonnyCampbell_Unity/blender 2023-02-13 15:25:16 +01:00
74de514dcc Add messaging to test cases. Use std::tmpnam for creating a temporary file.
Sonny Campbell commented on pull request blender/blender#104525 2023-02-13 12:49:58 +01:00
BLI: add function for changing working directory

Thanks, that's perfect. Will get it updated.

Sonny Campbell commented on pull request blender/blender#104459 2023-02-13 12:46:15 +01:00
Refactor: in USD importer extract read_mesh params into a struct

Done

409ee2669b Added const back onto parameters in function definitions. Fixed comment for USDMeshReadParams.
Sonny Campbell commented on pull request blender/blender#104525 2023-02-10 16:38:03 +01:00
BLI: add function for changing working directory

I originally created a temporary directory in place, and Bastien suggested using flags_test_release_dir, or flags_test_asset_dir, or creating a new flag to pass into the tests as something…

Sonny Campbell commented on pull request blender/blender#104459 2023-02-10 13:45:39 +01:00
Refactor: in USD importer extract read_mesh params into a struct

Done

Sonny Campbell commented on pull request blender/blender#104459 2023-02-10 13:44:49 +01:00
Refactor: in USD importer extract read_mesh params into a struct

Done

05a6b879c3 Add new create_mesh_read_params function. Remove unnecessary const.