Lucas Tadeu Yup_Lucas
  • Joined on 2023-02-05
Lucas Tadeu pushed to Yup_Lucas/vse-waveform-task-pool at Yup_Lucas/blender 2023-07-11 08:51:32 +02:00
4c7cef4eee Lock the preview job whenever a sound is added
Lucas Tadeu pushed to Yup_Lucas/load-visible-sound at Yup_Lucas/blender 2023-07-10 17:07:47 +02:00
3c7988cc59 PoC: Only load the visible portion of each sound strip
Lucas Tadeu pushed to Yup_Lucas/load-visible-sound at Yup_Lucas/blender 2023-07-10 17:05:38 +02:00
8ecf3d80be PoC: Only load the visible portion of each sound strip
Lucas Tadeu created branch Yup_Lucas/load-visible-sound in Yup_Lucas/blender 2023-07-10 17:05:38 +02:00
Lucas Tadeu commented on pull request blender/blender#108877 2023-07-10 12:48:57 +02:00
VSE: Process audio strips waveforms in parallel

@iss I've applied the changes you and merged Blender's main branch into this one. I ran a build and test this morning and it works as expected.

Thanks a bunch for the review pointers.

Lucas Tadeu pushed to Yup_Lucas/vse-waveform-task-pool at Yup_Lucas/blender 2023-07-10 12:44:23 +02:00
2b431fb401 Merge remote-tracking branch 'origin/main' into Yup_Lucas/vse-waveform-task-pool
631c8681b1 Remove previewjb
f2705dd913 Fix #109683: Cycles and Eevee missing AOVs when no closure connected
bfae400ea5 Outliner: Port edit bone elements to new tree-element code design
ab12d2836b Cycles: add texture to sun light
Compare 147 commits »
Lucas Tadeu commented on pull request blender/blender#108877 2023-07-04 14:35:31 +02:00
VSE: Process audio strips waveforms in parallel

@iss I sorted out the conflict and applied most of the changes you requested.

I kept setting the pj->running = false inside the lock and the check in the function that pushes new audio…

Lucas Tadeu pushed to Yup_Lucas/vse-waveform-task-pool at Yup_Lucas/blender 2023-07-04 14:34:06 +02:00
28fde330d6 Remove comment
Lucas Tadeu pushed to Yup_Lucas/vse-waveform-task-pool at Yup_Lucas/blender 2023-07-04 14:32:36 +02:00
76d67e5a6a Apply requested changes
1d93e647f9 Merge branch 'main' into Yup_Lucas/vse-waveform-task-pool
ddb36604b5 Run clang-format on sequencer_preview.c
445d71a577 I18n: translate missing geometry node attribute tooltips
bfda24cae3 Fix: Update Stubs for Shader Builder
Compare 760 commits »
Lucas Tadeu commented on pull request blender/blender#108877 2023-07-04 14:12:24 +02:00
VSE: Process audio strips waveforms in parallel

I can't directly break there because the mutex is locked at that point.

The options is to either have BLI_mutex_unlock call at each "break out" point or to just have the if-elseif-else clause…

Lucas Tadeu commented on pull request blender/blender#108877 2023-07-04 13:57:47 +02:00
VSE: Process audio strips waveforms in parallel

But don't we need to lock the struct to access the running variable? It could be changed concurrently by the thread running the WM job.

Lucas Tadeu commented on pull request blender/blender#108877 2023-07-02 19:31:49 +02:00
VSE: Process audio strips waveforms in parallel

@iss I just saw buildbot found a merge conflict here.

Does blender require any special process for this sort of stuff or can I just go ahead and merge master into this branch to sort out the…

Lucas Tadeu pushed to Yup_Lucas/vse-waveform-task-pool at Yup_Lucas/blender 2023-06-26 09:49:42 +02:00
e926125a69 Mark job as running by default and move comment around
Lucas Tadeu commented on pull request blender/blender#108877 2023-06-26 09:47:22 +02:00
VSE: Process audio strips waveforms in parallel

Alright, this took me a while but it's finally working as I wanted.

Context

Just using the event notifier doesn't work because in [sequencer_draw.c](https://projects.blender.org/Yup_Lucas/

Lucas Tadeu pushed to Yup_Lucas/vse-waveform-task-pool at Yup_Lucas/blender 2023-06-26 09:43:08 +02:00
ac75e6b553 Make sequencer_preview_add_sound retry if the PreviewJob is terminating
Lucas Tadeu commented on pull request blender/blender#108877 2023-06-19 15:24:35 +02:00
VSE: Process audio strips waveforms in parallel

@iss the current state in this PR sort of works, but I think there's still a race condition I wasn't able to trigger.

What I think can happen is this:

  1. The PreviewJob thread sees that all…
Lucas Tadeu pushed to Yup_Lucas/vse-waveform-task-pool at Yup_Lucas/blender 2023-06-19 15:17:13 +02:00
a1f9cf4f4f Fix condition variable wait loop
Lucas Tadeu commented on pull request blender/blender#108877 2023-06-19 09:20:39 +02:00
VSE: Process audio strips waveforms in parallel

Following up on this:

I read through sequencer_thumbnails.c but…

Lucas Tadeu pushed to Yup_Lucas/vse-waveform-task-pool at Yup_Lucas/blender 2023-06-16 16:58:45 +02:00
21969220fa WIP: Add cond variable
Lucas Tadeu commented on pull request blender/blender#108877 2023-06-16 16:55:34 +02:00
VSE: Process audio strips waveforms in parallel

Just an update here: No luck with the TBB docs.

There doesn't seem to be a way to just poll the threads.

I'm working on the changes to make it so that the PreviewJob waits on a condition…