Lucas Tadeu Yup_Lucas
0 Followers · 0 Following
  • Joined on 2023-02-05
Repositories
2
 Projects Public Activity Starred Repositories
Lucas Tadeu commented on pull request blender/blender#110837 2023-09-07 18:02:07 +02:00
VSE: Implement partial waveform data loading

@iss sound good, I'll move the initialisation to a background thread.

It does make sense to have different segments be initialised in the background

Lucas Tadeu commented on pull request blender/blender#110837 2023-08-31 07:23:58 +02:00
VSE: Implement partial waveform data loading

It does load waveforms a bit faster, but it seems, that it loads whole strip anyway

Are the strips completely visible when you enable waveform drawing? If they are, the code loads all of…

Lucas Tadeu commented on pull request blender/blender#110837 2023-08-29 21:18:06 +02:00
VSE: Implement partial waveform data loading

I was able to replicate the problem on my machine by putting a really long sleep in the preview_startjob function in sequencer_preview:

 /** \file
  * \ingroup spseq
  */
+#include…
Lucas Tadeu pushed to Yup_Lucas/vse-partial-waveform-loads at Yup_Lucas/blender 2023-08-29 21:02:47 +02:00
2eafb34572 Eliminate spinlocks to update waveform loading flags
Lucas Tadeu commented on pull request blender/blender#110837 2023-08-25 15:25:38 +02:00
VSE: Implement partial waveform data loading

I think the issue with the double locking that @iss reported is here. waveform_job_start_all_needed_segements is called inside the spin lock lock.

Lucas Tadeu commented on pull request blender/blender#110837 2023-08-25 15:10:30 +02:00
VSE: Implement partial waveform data loading

hey @iss , can you send me the repro steps so I can figure out what is wrong with the patch? 🤔

Lucas Tadeu created pull request blender/blender#111302 2023-08-19 19:35:16 +02:00
VSE: Ensure text offset x1 is never larger than x2
e785b8abf2 VSE: Ensure text offset x1 is never larger than x2
Lucas Tadeu created branch Yup_Lucas/vse-fix-calculate_seq_text_offsets in Yup_Lucas/blender 2023-08-19 19:17:43 +02:00
Lucas Tadeu pushed to Yup_Lucas/vse-partial-waveform-loads at Yup_Lucas/blender 2023-08-19 16:48:38 +02:00
69ced56c05 Merge branch 'main' into Yup_Lucas/vse-partial-waveform-loads
5a8cb665e0 Cleanup: various non-functional C++ changes
faa3ef6ad5 Cleanup: format
9d08be1eec Realtime Compositor: add regression tests
4f72240c1d Cleanup: spelling (correct correction), update dictionary
Compare 543 commits »
Lucas Tadeu pushed to Yup_Lucas/vse-partial-waveform-loads at Yup_Lucas/blender 2023-08-19 16:01:59 +02:00
fdbbabc907 Remove unused code
e69e523961 Remove unused Range2i
Compare 2 commits »
Lucas Tadeu pushed to Yup_Lucas/vse-partial-waveform-loads at Yup_Lucas/blender 2023-08-19 15:41:09 +02:00
0739a99084 VSE: Remove upfront normalization and clean up
Lucas Tadeu created pull request blender/blender#110837 2023-08-05 18:38:44 +02:00
WIP: VSE: Implement partial waveform data loading
Lucas Tadeu created branch Yup_Lucas/vse-partial-waveform-loads in Yup_Lucas/blender 2023-08-05 17:55:48 +02:00
Lucas Tadeu pushed to Yup_Lucas/vse-partial-waveform-loads at Yup_Lucas/blender 2023-08-05 17:55:48 +02:00
6b69d589a1 VSE: Implement partial waveform data loading
4f673f18af Move `BKE_lib_override.h` header to be fully C++.
873453005d Fix: GPv3 not rendering when origin is out of view
d43ceb1974 Fix: bpy build on windows
331969159e Fix: Unreported memory leak
Compare 10 commits »
Lucas Tadeu pushed to Yup_Lucas/load-visible-sound at Yup_Lucas/blender 2023-07-24 18:44:56 +02:00
4113fe7771 wip
Lucas Tadeu pushed to Yup_Lucas/load-visible-sound at Yup_Lucas/blender 2023-07-17 10:48:08 +02:00
c623c3c266 WIP: Sound segments
4b7b2b0151 Merge remote-tracking branch 'origin/main' into Yup_Lucas/load-visible-sound
fe71e3d631 Merge remote-tracking branch 'origin/main' into Yup_Lucas/load-visible-sound
a04da965f6 Fix #110166: Prevent ourliner editing generic labels.
8191b152ec GHOST: Guard GL context creation behind WITH_OPENGL_BACKEND
Compare 361 commits »
Lucas Tadeu commented on pull request blender/blender#108877 2023-07-11 16:13:51 +02:00
VSE: Process audio strips waveforms in parallel

@iss I just noticed I don't actually have commit rights. Can you merge this PR ?

Lucas Tadeu pushed to Yup_Lucas/vse-waveform-task-pool at Yup_Lucas/blender 2023-07-11 08:54:06 +02:00
1e939ce0e8 Merge remote-tracking branch 'origin/main' into Yup_Lucas/vse-waveform-task-pool
74c7615dba Cleanup: use function style casts for C++
4333051f4d WM: pass the window manager & window to WM_report_banner_show
36b2291610 Cleanup: spelling in comments
7aa31c884d Mesh: Merge by Distance: Remove unnecessary array
Compare 45 commits »
Lucas Tadeu commented on pull request blender/blender#108877 2023-07-11 08:53:23 +02:00
VSE: Process audio strips waveforms in parallel

Oh, I finally understood what you meant there. I've made the code change to ensure the PreviewJob is locked inside the sequencer_preview_add_sound() function until the new sound is added.

I…