VSE: Ensure text offset x1 is never larger than x2 #111302

Lucas Tadeu · 2023-08-19T19:35:08+02:00

Lucas Tadeu commented

2023-08-19 19:35:08 +02:00

Commit the bug is present in: 5a8cb665e01d1fa057a96bd1143cd6728d93132f

When you scroll all the way to the right side of the sequencer,
x1 can become larger than x2 due to the addition of
scroller_vert_xoffs.

When that happens, the assertion inside UI_view2d_view_to_region_rcti_clip
is triggered and causes blender to crash.

This change just clamps the value of x1 to the value of x2 to ensure the
assertion is never triggered.

Video reproduction of the issue

Xcode stack trace when the crash happens

Looking at the image below you can see that the value of xmin is larger than that of xmax

Commit the bug is present in: `5a8cb665e01d1fa057a96bd1143cd6728d93132f` When you scroll all the way to the right side of the sequencer, `x1` can become larger than `x2` due to the [addition of `scroller_vert_xoffs`](https://projects.blender.org/blender/blender/src/commit/5a8cb665e01d1fa057a96bd1143cd6728d93132f/source/blender/editors/space_sequencer/sequencer_draw.cc#L1225-L1227). When that happens, the assertion inside `UI_view2d_view_to_region_rcti_clip` is triggered and causes blender to crash. This change just clamps the value of x1 to the value of x2 to ensure the assertion is never triggered. ## Video reproduction of the issue <video src="/attachments/33390215-4e40-4e07-9046-de91260ae49d" title="bug repro.mov" controls></video> ## Xcode stack trace when the crash happens Looking at the image below you can see that the value of `xmin` is larger than that of `xmax` ![Stack trace in Xcode](/attachments/4808c440-593a-4f18-abea-532e314bd081)

bug repro.mov

45 MiB

Screenshot 2023-08-19 at 17.45.54.png

1.6 MiB

Lucas Tadeu added 1 commit 2023-08-19 19:35:17 +02:00

e785b8abf2 VSE: Ensure text offset x1 is never larger than x2

When you scroll all the way to the right side of the sequencer,
`x1` can become larger than `x2` due to the addition of
`scroller_vert_xoffs`.

When that happens, the assertion inside `UI_view2d_view_to_region_rcti_clip`
is triggered and causes blender to crash.

This change just clamps the value of x1 to the value of x2 to ensure the
assertion is never triggered.

Lucas Tadeu requested review from Richard Antalik 2023-08-19 19:35:52 +02:00

Richard Antalik approved these changes 2023-08-21 17:37:17 +02:00

Richard Antalik commented

2023-08-21 18:00:42 +02:00

Technically the fix is correct, but I think, that adding scroller_vert_xoffs is still from 2.79 and could be removed instead. Indeed this was implemented in 3d1138840c where scrollers were on the other side, so I will just remove this offset instead.
Sorry, was bit too fast accepting this. Will close instead. Thanks for patch anyway.

Technically the fix is correct, but I think, that adding `scroller_vert_xoffs` is still from 2.79 and could be removed instead. Indeed this was implemented in 3d1138840c9e44384d773a1786c4c8893571f20b where scrollers were on the other side, so I will just remove this offset instead. Sorry, was bit too fast accepting this. Will close instead. Thanks for patch anyway.

👍 1

Richard Antalik closed this pull request

2023-08-21 18:00:43 +02:00

Richard Antalik commented

2023-08-21 18:27:49 +02:00

For reference, committed 9269afda59 instead

For reference, committed 9269afda59482fd6c48e1e6a76026845d763cc5a instead

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

VSE: Ensure text offset x1 is never larger than x2 #111302

Video reproduction of the issue

Xcode stack trace when the crash happens

Pull request closed