Attila Áfra aafra
0 Followers · 0 Following
  • Joined on 2019-02-12
Repositories
1
 Projects Public Activity Starred Repositories
Attila Áfra pushed to aafra/oidn-lazy-module-load at aafra/blender 2024-04-30 22:09:40 +02:00
75c1655e5a Use OIDN lazy module loading (WIP)
Attila Áfra created branch aafra/oidn-lazy-module-load in aafra/blender 2024-04-30 22:09:40 +02:00
Attila Áfra pushed to oidn-lazy-module-load at aafra/blender 2024-04-30 18:19:08 +02:00
d5ecb14ff5 Use OIDN lazy module loading (WIP)
8d13a9608b BLI: generalize task size hints for parallel_for
d588bfdb5e Geometry Nodes: improve naming and code deduplication
6bd1d5de54 Fix: assert when removing element from empty array
76a151b9d6 Refactor: Store PBVH in unique_ptr
Compare 10 commits »
Attila Áfra created branch oidn-lazy-module-load in aafra/blender 2024-04-30 18:19:08 +02:00
Attila Áfra commented on issue blender/blender#118455 2024-04-15 22:25:54 +02:00
Library changes for Blender 4.2

@brecht Yes, there will be such changes in 2.3. Thanks!

Attila Áfra commented on issue blender/blender#118455 2024-04-02 17:02:59 +02:00
Library changes for Blender 4.2

@brecht Would you be interested in integrating an OIDN 2.3 beta release into Blender 4.2 alpha? I think this way we could catch and fix issues (e.g. HIP) much earlier than last time, and the…

Attila Áfra commented on issue blender/blender#115045 2024-03-19 13:59:08 +01:00
OpenImageDenoise GPU acceleration

@brecht Couldn't you perhaps add an environment variable which could enable OIDN on HIP? In most cases there shouldn't be a crash (it has been fixed for all known cases so far), and this way…

Attila Áfra commented on issue blender/blender#119444 2024-03-15 23:44:24 +01:00
"hipErrorNoBinaryForGpu: Unable to find code object for all current devices!" with nVidia GPU and AMD iGPU

@brecht With the help of @Alaska and @MarkFreeDev , we can conclude that the HIP error/crash doesn't happen using the following minimum driver versions (older versions may also work but this is…

Attila Áfra commented on issue blender/blender#119444 2024-03-15 20:32:58 +01:00
"hipErrorNoBinaryForGpu: Unable to find code object for all current devices!" with nVidia GPU and AMD iGPU

@Alaska Could you please try to run oidnBenchmark -ld using the fresh OIDN 2.2.2 binaries? https://github.com/OpenImageDenoise/oidn/releases/tag/v2.2.2

Attila Áfra commented on issue blender/blender#119035 2024-03-15 20:31:39 +01:00
Out of GPU memory when rendering animations with Cycles and GPU denoising in Blender 4.1

It's out: https://github.com/OpenImageDenoise/oidn/releases/tag/v2.2.2

Attila Áfra commented on issue blender/blender#119035 2024-03-15 17:48:49 +01:00
Out of GPU memory when rendering animations with Cycles and GPU denoising in Blender 4.1

Quick update: the release is still on track for today but there was some internal infrastructure issue which caused an unexpected delay.

Attila Áfra commented on issue blender/blender#119444 2024-03-15 14:42:29 +01:00
"hipErrorNoBinaryForGpu: Unable to find code object for all current devices!" with nVidia GPU and AMD iGPU

Thanks @Alaska ! I'm currently finishing up the new OIDN release. I could help with the compilation after the release. But before that let's try the new OIDN 2.2.2 binaries on this machine.…

Attila Áfra commented on issue blender/blender#119035 2024-03-15 14:07:24 +01:00
Out of GPU memory when rendering animations with Cycles and GPU denoising in Blender 4.1

I'm in the middle of the release process. It should be out in a few hours max. Sorry about the delay.

Attila Áfra commented on issue blender/blender#119444 2024-03-15 01:30:00 +01:00
"hipErrorNoBinaryForGpu: Unable to find code object for all current devices!" with nVidia GPU and AMD iGPU

@Alaska Thanks a lot! Could you perhaps try to find out where exactly does OIDN crash, specifically for which HIP API call?

Attila Áfra commented on issue blender/blender#119444 2024-03-14 22:39:48 +01:00
"hipErrorNoBinaryForGpu: Unable to find code object for all current devices!" with nVidia GPU and AMD iGPU

@Alaska Yes, please do the tests.

Attila Áfra commented on issue blender/blender#119444 2024-03-14 18:43:09 +01:00
"hipErrorNoBinaryForGpu: Unable to find code object for all current devices!" with nVidia GPU and AMD iGPU

Great! For the next OIDN version I'll try to switch to lazy device module loading, when using only API functions specific to a particular device type.

Perhaps I could still add some kind of…

Attila Áfra commented on issue blender/blender#119444 2024-03-14 18:23:07 +01:00
"hipErrorNoBinaryForGpu: Unable to find code object for all current devices!" with nVidia GPU and AMD iGPU

The overhead of just checking whether a device is supported wouldn’t be much lower than actually trying to create the device, and it wouldn’t be any less riskier. Device creation doesn’t do…

Attila Áfra commented on issue blender/blender#119444 2024-03-14 17:58:57 +01:00
"hipErrorNoBinaryForGpu: Unable to find code object for all current devices!" with nVidia GPU and AMD iGPU

@brecht I will consider lazy device module loading but I really don’t want to make major API changes because of this, especially not adding a device type parameter to all device query functions.…

Attila Áfra commented on issue blender/blender#119444 2024-03-14 15:50:19 +01:00
"hipErrorNoBinaryForGpu: Unable to find code object for all current devices!" with nVidia GPU and AMD iGPU

@brecht What you describe seems to be a somewhat different matter: a change in behavior in OIDN. You can disable loading some device modules with environment variables but once OIDN gets…

Attila Áfra commented on issue blender/blender#119444 2024-03-14 15:38:14 +01:00
"hipErrorNoBinaryForGpu: Unable to find code object for all current devices!" with nVidia GPU and AMD iGPU

@Alaska I'd like to ask for your help with debugging this on the machine you have. Could you please do the following?

  • Install an AMD driver which reproduces the crash in Cycles. Please…