Amélie Fondevilla amelief
0 Followers · 0 Following
  • https://www.afonde.com/

  • Research Engineer at the animation studio Les Fées Spéciales. Occasional contributor to Grease Pencil.

  • Joined on 2022-01-17
Repositories
1
 Projects Public Activity Starred Repositories
Amélie Fondevilla pushed to main at blender/blender 2023-08-02 14:56:25 +02:00
fd75695bed GPv3: Insert grease pencil keyframe from the dopesheet
Amélie Fondevilla merged pull request blender/blender#110649 2023-08-02 14:56:25 +02:00
GPv3: Insert grease pencil keyframe from the dopesheet
Amélie Fondevilla pushed to gpv3-insert-keyframe at amelief/blender 2023-08-02 14:36:48 +02:00
33fc703589 Fix function name
b0b41645b8 Renamed parameters in header
707237e091 Remove unused header in includes
b7f5c24c95 Cleanup: renamed variables + comments
524f6844a0 Remove the inserted frame if the duplication fails
Compare 27 commits »
Amélie Fondevilla approved blender/blender#110714 2023-08-02 13:41:39 +02:00
GPv3: Replace int with FramesMapKey

LGTM.

Amélie Fondevilla pushed to gpv3-insert-keyframe at amelief/blender 2023-08-02 12:04:07 +02:00
61fcbdcb00 Renamed parameters in header
7708a91b11 Remove unused header in includes
Compare 2 commits »
Amélie Fondevilla pushed to gpv3-insert-keyframe at amelief/blender 2023-08-02 12:00:10 +02:00
a0e66dfed9 Cleanup: renamed variables + comments
Amélie Fondevilla pushed to gpv3-insert-keyframe at amelief/blender 2023-08-02 11:37:29 +02:00
3a7eade920 Remove the inserted frame if the duplication fails
971ce1c3da Return false if no frame at frame number
41ff297b93 Cleanup: Comments
0eb751b253 Add user if we duplicate as an instance
8921589d62 Cleanup: use c++ drawing class
Compare 5 commits »
Amélie Fondevilla pushed to gpv3-insert-keyframe at amelief/blender 2023-08-02 11:04:57 +02:00
44523a27e1 Remove duplicated tag
bd0d17e2f7 Copy duration of duplicated frame
2485662245 Insert duplicate frame now takes an index as argument
3af228f1c1 Make frame index at public function
b17e5e3873 Cleanup: switch statement + silent return instead of assert
Compare 40 commits »
Amélie Fondevilla pushed to gpv3-insert-keyframe at amelief/blender 2023-08-01 17:11:49 +02:00
0c6313e538 Remove duplicated tag
Amélie Fondevilla commented on pull request blender/blender#110649 2023-08-01 17:10:23 +02:00
GPv3: Insert grease pencil keyframe from the dopesheet

Agree. I had to change the function so that it takes an index instead of directly the frame to be duplicated. I think now it works, though.

Amélie Fondevilla pushed to gpv3-insert-keyframe at amelief/blender 2023-08-01 17:09:08 +02:00
c3ef866b0d Copy duration of duplicated frame
7a6a48df4f Insert duplicate frame now takes an index as argument
3bfbb4d8d4 Make frame index at public function
35a50dcac6 Cleanup: switch statement + silent return instead of assert
eae7813ed3 Refactor
Compare 5 commits »
Amélie Fondevilla pushed to gpv3-insert-keyframe at amelief/blender 2023-08-01 16:25:30 +02:00
2a382c80d9 Cleanup: renamed variables & improved comments.
Amélie Fondevilla pushed to gpv3-insert-keyframe at amelief/blender 2023-08-01 16:24:41 +02:00
f6a49de5fc Refactor
5742505d05 Add additive drawing mode in UI
1f1ceebee8 Cleanup : preparing for the user count to be increased.
4e1db68e4c Fix wrong function name
051f121cff Implement insert keyframe
Compare 50 commits »
Amélie Fondevilla commented on pull request blender/blender#110579 2023-08-01 14:48:52 +02:00
GPv3: Add user count to drawings

Oh, something else. This should be frames_for_write() I think.

Amélie Fondevilla approved blender/blender#110579 2023-08-01 14:47:24 +02:00
GPv3: Add user count to drawings

Looks good to me.

Amélie Fondevilla commented on pull request blender/blender#110579 2023-08-01 14:47:23 +02:00
GPv3: Add user count to drawings

Shouldn't this be drawing_base->type ?

Amélie Fondevilla approved blender/blender#110679 2023-08-01 12:47:49 +02:00
GPv3: Add remove_frame function to layers

Looks good. I only have a few questions.

Amélie Fondevilla commented on pull request blender/blender#110679 2023-08-01 12:47:48 +02:00
GPv3: Add remove_frame function to layers

Just curious, why use auto instead of int *next_it = begin; here ?

Amélie Fondevilla commented on pull request blender/blender#110679 2023-08-01 12:47:48 +02:00
GPv3: Add remove_frame function to layers

Is there something to be done with the drawing here ? Like remove the drawing or decrease user count ? Or is it done at a higher level ?

Amélie Fondevilla commented on pull request blender/blender#110679 2023-08-01 12:47:47 +02:00
GPv3: Add remove_frame function to layers

Maybe a bit more clear : "Removes null frames starting from \a begin to \a end (excluded), or until a non-null frame is reached."