- https://www.afonde.com/
-
Research Engineer at the animation studio Les Fées Spéciales. Occasional contributor to Grease Pencil.
- Joined on
2022-01-17
Tested it, it works. Thank you for adding this function!
Thanks for spotting this @PratikPB2123 !
I will move it to grease_pencil_edit.cc
🙂
Hey @filedescriptor thanks for the review, I'll edit the code. I was wondering it we could optimize this by separating the case of the extrude containing endpoints or not. If the selection does…
I suspected that the intersection was not efficient yes 😅
For point_to_curve_map
, I think I recall Hans saying that it was better to loop over the curves and use points_by_curve
, but ofc…
Looks good to me. This is not a part of the code that I am familiar with, so I left just one comment on the code.
Why is there two transform panels ? Maybe the one with a capital T is a duplicate ?
hi @PratikPB2123 , thanks for the PR.
I think this integration should also come with the support of basic operators, at least to avoid crashes. For example, right now, if I try to move a…
Thank you @LukasTonne , I don't mind at all.
Thank you for fixing this, I cant believe I did not notice this before..