Amélie Fondevilla amelief
  • https://www.afonde.com/
  • Research Engineer at the animation studio Les Fées Spéciales. Occasional contributor to Grease Pencil.

  • Joined on 2022-01-17
Amélie Fondevilla commented on pull request blender/blender#108807 2023-07-11 17:47:08 +02:00
GPv3: Add initial dopesheet support

I like that you pointed out this specific spot, because I renamed the legacy one, when I should have renamed the gpv3 one instead. 😅 I will change that, and check all the other renamed…

e65d231df4 Cleanup: add const qualifier
1bfc755f56 Cleanup: early return in a function instead of a big if
c1268c9473 Add assert message for unexpected channel flags
Compare 3 commits »
Amélie Fondevilla commented on pull request blender/blender#109733 2023-07-10 17:41:34 +02:00
GPv3: Add access functions for opacity and radius attributes

Yes, because we actually need that for the smoothing algorithm and we are gonna need it for further development in the next weeks.

Amélie Fondevilla pushed to gpv3-attributes-api at amelief/blender 2023-07-10 15:11:17 +02:00
c3ee7beb0d Fix the implementation of the getters
6602296198 Setting the grease pencil animation channels expanded by default
Amélie Fondevilla commented on pull request blender/blender#109635 2023-07-05 14:29:29 +02:00
GPv3: Stroke smoothing operator

This PR is waiting for 109733 to land so that we can add the option to smooth radius and opacity.

09788c26a3 Renamed variable
7ea749b8c7 Update selection and keytype for summary
Amélie Fondevilla commented on pull request blender/blender#108807 2023-07-05 12:49:14 +02:00
GPv3: Add initial dopesheet support

Actually, don't mind my last comment, we do have selection and type, I am just gonna do these TODOs in this PR :)

08a50d3dfb Refactor if statement
adfd20b91f Changing comment to be more explicit
a76cdb9e0a Initialize grease pencil cel value
afdaa411f3 Renaming cels into grease pencil cels
904006f92d Cleanup todos for action key update
Compare 193 commits »
Amélie Fondevilla pushed to gpv3-attributes-api at amelief/blender 2023-07-05 12:23:35 +02:00
d1d5c62564 Changed comment format. No functional changes.
Amélie Fondevilla commented on pull request blender/blender#109733 2023-07-05 12:20:59 +02:00
GPv3: Add access functions for opacity and radius attributes

We need setters and getters for these two very commonly accessed attributes of grease pencil. The code is based on the implementation of CurvesGeometry::positions() and `CurvesGeometry::positio…

Amélie Fondevilla created pull request blender/blender#109733 2023-07-05 12:15:43 +02:00
Add getters and setters for opacity and radius of a grease pencil drawing
Amélie Fondevilla created branch gpv3-attributes-api in amelief/blender 2023-07-05 12:14:33 +02:00
Amélie Fondevilla pushed to gpv3-attributes-api at amelief/blender 2023-07-05 12:14:33 +02:00
0d4632f327 Add getters and setters for opacity and radius of a grease pencil drawing
Amélie Fondevilla pushed to gpv3-blur-stroke-operator at amelief/blender 2023-07-05 11:54:31 +02:00
6ca5f950f2 Add radius and opacity smoothing
6dc6e6fc3e Remove unused include
39c46d1fa9 Add descriptive comment
d33463489b Fix in the smoothing algorithms : weights are now computed per point to account for fixed boundaries
b42e7cd74b Remove obsolete comment
Compare 184 commits »
Amélie Fondevilla pushed to gpv3-blur-stroke-operator at amelief/blender 2023-07-04 17:10:44 +02:00
5271bc6847 Remove unused include
Amélie Fondevilla pushed to gpv3-blur-stroke-operator at amelief/blender 2023-07-04 17:08:40 +02:00
f9a866daf9 Add descriptive comment
180b7b3678 Fix in the smoothing algorithms : weights are now computed per point to account for fixed boundaries
2d56b126ec Remove obsolete comment
174b9c926b Set props default and range to more appropriate values
2fbc7572d7 Add RNA props
Compare 5 commits »
99de7b9176 Refactor if statement
68bc1b9954 Changing comment to be more explicit
bccfe43584 Initialize grease pencil cel value
a15cdfc945 Renaming cels into grease pencil cels
Compare 4 commits »
Amélie Fondevilla commented on pull request blender/blender#108807 2023-07-04 11:49:22 +02:00
GPv3: Add initial dopesheet support

It's planned for a future commit, I guess, as we do not have cel selection at all right now.