Abdelrahman Said amsaid1989
0 Followers · 0 Following
  • Joined on 2017-10-13
Repositories
1
 Projects Public Activity Starred Repositories
Abdelrahman Said commented on pull request blender/blender#116655 2024-07-05 00:01:52 +02:00
GPv3: Port frame_clean_duplicate operator

Thanks, this looks good to me now :)

Great. Thank you very much

Abdelrahman Said commented on pull request blender/blender#116655 2024-06-01 23:34:35 +02:00
GPv3: Port frame_clean_duplicate operator

@filedescriptor I addressed all your feedback

Abdelrahman Said commented on pull request blender/blender#116655 2024-06-01 23:33:23 +02:00
GPv3: Port frame_clean_duplicate operator

All done.

Abdelrahman Said pushed to gpv3-delete-duplicate-frames at amsaid1989/blender 2024-06-01 23:33:03 +02:00
5e47d231a8 Switch to using remove_frames
eef688376d Gather start frame numbers before deleting
dd5fe71aa3 Use get_drawing_at instead of get_editable_drawing_at
b91633ce77 Use FrameMapKeyT
Compare 4 commits »
Abdelrahman Said commented on pull request blender/blender#116655 2024-06-01 23:29:43 +02:00
GPv3: Port frame_clean_duplicate operator

Tried remove_frames again and, this time, it worked. I think whatever the cause of the crash, it was fixed by some other update and now, since I merge the main branch, it's working.

Abdelrahman Said commented on pull request blender/blender#116655 2024-06-01 23:01:07 +02:00
GPv3: Port frame_clean_duplicate operator

Changed it

Abdelrahman Said commented on pull request blender/blender#116655 2024-06-01 22:57:01 +02:00
GPv3: Port frame_clean_duplicate operator

Done

Abdelrahman Said pushed to gpv3-delete-duplicate-frames at amsaid1989/blender 2024-06-01 12:30:43 +02:00
7b2156fb87 Merge branch 'main' into gpv3-delete-duplicate-frames
cab79018ee glTF exporter: Remove false positive warning
d002703484 PyAPI: fixes for defining operator macros
a700fdc163 Fix class methods being excluded from the Python API docs
90d513f7d3 Cleanup: improve checks for function types for RNA introspection
Compare 1318 commits »
Abdelrahman Said deleted branch testing from amsaid1989/blender 2024-06-01 12:28:28 +02:00
Abdelrahman Said pushed to testing at amsaid1989/blender 2024-06-01 12:26:01 +02:00
bc20f1a1e8 Merge branch 'main' into testing
Abdelrahman Said created branch testing in amsaid1989/blender 2024-06-01 12:26:01 +02:00
Abdelrahman Said pushed to main at amsaid1989/blender 2024-06-01 12:02:20 +02:00
cab79018ee glTF exporter: Remove false positive warning
d002703484 PyAPI: fixes for defining operator macros
a700fdc163 Fix class methods being excluded from the Python API docs
90d513f7d3 Cleanup: improve checks for function types for RNA introspection
20d506941b Cleanup: comments in sphinx doc generation
Compare 1317 commits »
Abdelrahman Said commented on pull request blender/blender#116655 2024-05-28 21:46:34 +02:00
GPv3: Port frame_clean_duplicate operator

Sorry for not getting to this earlier. I have a few comments

@filedescriptor No worries at all.. Will take care of these comments and push an update

Abdelrahman Said commented on pull request blender/blender#116655 2024-05-19 01:27:54 +02:00
GPv3: Port frame_clean_duplicate operator

@mod_moder Please let me know if there is anything else I need to do with this PR

Abdelrahman Said commented on pull request blender/blender#116655 2024-05-04 19:43:48 +02:00
GPv3: Port frame_clean_duplicate operator

Great.. Thank you very much. Updated the PR.

Abdelrahman Said pushed to gpv3-delete-duplicate-frames at amsaid1989/blender 2024-05-04 19:42:47 +02:00
4f4a32d662 Early exit if attributes arrays don't have same size or type
bfd0d63233 Convert attributes to static types in the lambda
Compare 2 commits »
Abdelrahman Said commented on pull request blender/blender#116655 2024-05-04 17:59:20 +02:00
GPv3: Port frame_clean_duplicate operator

And additional cleanup comment: upcast to static type for attributes should be on the caller, not in the template method.

Regarding this, I would like to confirm that I understand you…

Abdelrahman Said commented on pull request blender/blender#116655 2024-05-04 17:41:46 +02:00
GPv3: Port frame_clean_duplicate operator

@mod_moder I have addressed your comments about the varrays check.

Renamed attributes_varrays_are_equal to attributes_varrays_span_data_equal and updated it to this:

static bool…
Abdelrahman Said pushed to gpv3-delete-duplicate-frames at amsaid1989/blender 2024-05-04 17:37:50 +02:00
e0d71845ac Explicitly check if attributes arrays don't have same size or type
Abdelrahman Said commented on pull request blender/blender#116655 2024-04-29 22:19:58 +02:00
GPv3: Port frame_clean_duplicate operator

@mod_moder Addressed your latest feedback