Abdelrahman Said amsaid1989
0 Followers · 0 Following
  • Joined on 2017-10-13
Repositories
1
 Projects Public Activity Starred Repositories
Abdelrahman Said commented on pull request blender/blender#116655 2024-05-19 01:27:54 +02:00
GPv3: Port frame_clean_duplicate operator

@mod_moder Please let me know if there is anything else I need to do with this PR

Abdelrahman Said commented on pull request blender/blender#116655 2024-05-04 19:43:48 +02:00
GPv3: Port frame_clean_duplicate operator

Great.. Thank you very much. Updated the PR.

Abdelrahman Said pushed to gpv3-delete-duplicate-frames at amsaid1989/blender 2024-05-04 19:42:47 +02:00
4f4a32d662 Early exit if attributes arrays don't have same size or type
bfd0d63233 Convert attributes to static types in the lambda
Compare 2 commits »
Abdelrahman Said commented on pull request blender/blender#116655 2024-05-04 17:59:20 +02:00
GPv3: Port frame_clean_duplicate operator

And additional cleanup comment: upcast to static type for attributes should be on the caller, not in the template method.

Regarding this, I would like to confirm that I understand you…

Abdelrahman Said commented on pull request blender/blender#116655 2024-05-04 17:41:46 +02:00
GPv3: Port frame_clean_duplicate operator

@mod_moder I have addressed your comments about the varrays check.

Renamed attributes_varrays_are_equal to attributes_varrays_span_data_equal and updated it to this:

static bool…
Abdelrahman Said pushed to gpv3-delete-duplicate-frames at amsaid1989/blender 2024-05-04 17:37:50 +02:00
e0d71845ac Explicitly check if attributes arrays don't have same size or type
Abdelrahman Said commented on pull request blender/blender#116655 2024-04-29 22:19:58 +02:00
GPv3: Port frame_clean_duplicate operator

@mod_moder Addressed your latest feedback

Abdelrahman Said commented on pull request blender/blender#116655 2024-04-29 22:19:41 +02:00
GPv3: Port frame_clean_duplicate operator

Done

Abdelrahman Said commented on pull request blender/blender#116655 2024-04-29 22:19:28 +02:00
GPv3: Port frame_clean_duplicate operator

Done

Abdelrahman Said commented on pull request blender/blender#116655 2024-04-29 22:19:19 +02:00
GPv3: Port frame_clean_duplicate operator

Done

Abdelrahman Said pushed to gpv3-delete-duplicate-frames at amsaid1989/blender 2024-04-29 22:14:56 +02:00
afcf200489 Address PR feedback
Abdelrahman Said commented on pull request blender/blender#116655 2024-04-28 22:35:50 +02:00
GPv3: Port frame_clean_duplicate operator

@mod_moder Let me know if there are any changes you would like me to make

Abdelrahman Said pushed to gpv3-delete-duplicate-frames at amsaid1989/blender 2024-04-24 23:45:00 +02:00
63a6c9046a Merge main branch
c8ccf77564 Vulkan: Render graph dispatch indirect
f91b23ef2d USD import: add support for displayColor on non-Mesh USD shape prims
777473313e Fix: Correct perferred domain function for point index in curve node
36f1336e38 Fix #121041: Node tools asset list missing on startup
Compare 153 commits »
Abdelrahman Said deleted branch testing from amsaid1989/blender 2024-04-24 23:43:57 +02:00
Abdelrahman Said created branch testing in amsaid1989/blender 2024-04-24 23:42:56 +02:00
Abdelrahman Said pushed to testing at amsaid1989/blender 2024-04-24 23:42:56 +02:00
63a6c9046a Merge main branch
Abdelrahman Said pushed to main at amsaid1989/blender 2024-04-24 22:46:47 +02:00
c8ccf77564 Vulkan: Render graph dispatch indirect
f91b23ef2d USD import: add support for displayColor on non-Mesh USD shape prims
777473313e Fix: Correct perferred domain function for point index in curve node
36f1336e38 Fix #121041: Node tools asset list missing on startup
fcb19fc4ec Cleanup: EEVEE-Next: Use define for volume probe atlas format
Compare 152 commits »
Abdelrahman Said commented on pull request blender/blender#116655 2024-04-20 16:38:45 +02:00
GPv3: Port frame_clean_duplicate operator

I needed const int i : keys.index_range().drop_back(1) instead of const int i : keys.index_range().drop_front(1)

Abdelrahman Said pushed to gpv3-delete-duplicate-frames at amsaid1989/blender 2024-04-20 16:36:17 +02:00
c2adb6aaef Iterate through keyframes using index_range
0d48724c60 Add const qualifier to current and next variables
b1cbd73744 Remove unnecessary span size check
4b2d58869d Rename attrs_equal to attributes_are_equal
Compare 4 commits »
Abdelrahman Said commented on pull request blender/blender#116655 2024-04-20 15:49:46 +02:00
GPv3: Port frame_clean_duplicate operator

Thanks. Looks correct to me 🙂

Let's wait for Falk/Hans/Iliya for further review of attribute comparison code.

Thank you for your help, @PratikPB2123 😊