- Kaunas, Lithuania
- https://aras-p.info/
- Joined on
2022-01-20 -
-
Ah! But good catch, one branch below this calls into "nearest" function that does not wrap internally. Will fix!
(looks like this code is not covered by any tests lol...)
Because the "wrap" bilinear functions now wrap the u,v internally. So no longer need to do floored_fmod equivalent outside the call.
Yes. It's a question I asked on the sculpt-painting channel, "why there's a clamp in there?". I took the clamp out of the interpolation function and put it in the calling place. But Brecht thinks…
Both are floored modulo, i.e. behave the same wrt negative numbers.
Yeah I'm not sure if the code as-is actually solves your problem properly. If you want to implement support for exporting Bezier curves as actual curves, then sure that could be implemented. I…
Agreed with Sergey via chat:
- Make this more extensive: low level BLI pixel interpolation function, possibly templated upon filter mode, wrapping behavior, etc. Could return color by value…
I think IMB_transform could be used for this, even if it's somewhat overkill. You would get multi-threading "for free" though.
If not that, I think factoring out the actual rotation function…