Aras Pranckevicius aras_p
9 Followers · 0 Following
Repositories
2
 Projects Public Activity Starred Repositories
Aras Pranckevicius created pull request blender/blender#126021 2024-08-07 10:33:47 +02:00
Cleanup: Make more VSE functions use const arguments where they can
Aras Pranckevicius pushed to vse_cleanup at aras_p/blender 2024-08-07 10:33:16 +02:00
9e136464c6 Cleanup: Make more VSE functions use const arguments where they can
2858c3b287 Link/Append: separate instantiation of loose data from core link/append code
91de9acc61 DRW: Reduce complexity of Draw primitive expansion
12f3e23326 Refactor: Remove SCULPT_active_vert_co_get
b119e1a497 Cycles: Fix potential NaN in normal mapping
Compare 10 commits »
Aras Pranckevicius created branch vse_cleanup in aras_p/blender 2024-08-07 10:33:16 +02:00
Aras Pranckevicius suggested changes for blender/blender#124333 2024-08-07 08:44:44 +02:00
VSE: Connected Strips

Code looks good, I've added some minor comments that should be easy to address.

Aras Pranckevicius commented on pull request blender/blender#124333 2024-08-07 08:43:59 +02:00
VSE: Connected Strips

Currently the icon is still ICON_LINKED from back when this feature was called "Linked strips". Should this be changed, and if so, to which icon

@pablovazquez opinions on what icon to use to…

Aras Pranckevicius commented on pull request blender/blender#124333 2024-08-07 08:38:10 +02:00
VSE: Connected Strips

Would probably be less error prone to introduce a constant for both lines of code, e.g.

Aras Pranckevicius commented on pull request blender/blender#124333 2024-08-07 08:34:02 +02:00
VSE: Connected Strips

Minor: to me probably would read easier if bool changed = false would be moved further below, right before the LISTBASE_FOREACH loop. And the !SEQ_is_strip_connected check would simply return false.

Aras Pranckevicius commented on pull request blender/blender#124333 2024-08-07 08:31:40 +02:00
VSE: Connected Strips

Minor, and probably this is following existing code, but I'm wondering whether the comments for Identifiers, Api callbacks and Flags are much useful here (and in SEQUENCER_OT_disconnect). It is very clear what these function parts are already, without the comments.

Aras Pranckevicius commented on pull request blender/blender#124333 2024-08-07 08:27:56 +02:00
VSE: Connected Strips

What would orig_start be used for? Currently indeed it seems to not be used for anything, so why have it at all?

Aras Pranckevicius commented on pull request blender/blender#124333 2024-08-07 08:26:12 +02:00
VSE: Connected Strips

seq_list argument could be const blender::VectorSet<Sequence *> & I think, no need to copy the whole vector set by value.

Aras Pranckevicius commented on pull request blender/blender#124333 2024-08-07 08:25:01 +02:00
VSE: Connected Strips

Minor: forward declaring struct SeqConnection; in this header is not really needed?

Aras Pranckevicius commented on pull request blender/blender#124333 2024-08-07 08:18:54 +02:00
VSE: Connected Strips

@blender-bot package

Aras Pranckevicius commented on pull request blender/blender#118670 2024-08-06 18:22:26 +02:00
VSE: Add anim manager

Ah wait no, this also happens on main, but only with some specific file that I have. I was stupidly testing main with some different file, but this branch with that problematic file. Sorry! Move…

Aras Pranckevicius pushed to main at aras_p/blender 2024-08-06 15:34:32 +02:00
9e0b673467 Fix #125938: Transfer Mode (Alt+Q) doesn't work for pose mode switching to a liboverride armature.
6d27aa709d Cleanup: Workbench Shadow Shader
4035f2fe9c Fix #125826: Crash when using Render Engine Procedural with PointClouds
5110833ff1 Extensions: use wait cursor when toggling add-ons
3549c9e2b7 Cleanup: Sculpt: Remove "no original coordinates" check for redo
Compare 4642 commits »
Aras Pranckevicius created pull request blender/blender#125966 2024-08-06 15:34:21 +02:00
Cleanup: Remove unused code from BLI_mempool
Aras Pranckevicius created branch mempool_cleanup in aras_p/blender 2024-08-06 15:33:44 +02:00
Aras Pranckevicius pushed to mempool_cleanup at aras_p/blender 2024-08-06 15:33:44 +02:00
da13709c2b Cleanup: Remove unused code from BLI_mempool
9e0b673467 Fix #125938: Transfer Mode (Alt+Q) doesn't work for pose mode switching to a liboverride armature.
6d27aa709d Cleanup: Workbench Shadow Shader
4035f2fe9c Fix #125826: Crash when using Render Engine Procedural with PointClouds
5110833ff1 Extensions: use wait cursor when toggling add-ons
Compare 10 commits »
Aras Pranckevicius commented on pull request blender/blender#125953 2024-08-06 15:16:32 +02:00
WIP: Fix #118505: Incorrect strip image transformation

@iss hmm not sure indeed which behavior "feels more correct", I could also see arguments for either way :/

Aras Pranckevicius commented on pull request blender/blender#118670 2024-08-06 15:08:53 +02:00
VSE: Add anim manager

This ends up creating and shutting down a whole OS thread, basically for each sequencer frame that is being processed. Maybe that is not a big problem, but feels a bit like a waste. Wouldn't it be better to have one "prefetch thread" that does all this "free unused and prefetch anims", instead of spawning a new one many times per second?

Aras Pranckevicius commented on pull request blender/blender#118670 2024-08-06 14:59:35 +02:00
VSE: Add anim manager

My guess for what happens is:

  1. parallel_load_anims is called with two strips that are visible at once, but they share the same anim object
  2. they get put onto two different worker threads…