- Kaunas, Lithuania
- https://aras-p.info/
- Joined on
2022-01-20
Draw
primitive expansion
Code looks good, I've added some minor comments that should be easy to address.
Currently the icon is still ICON_LINKED from back when this feature was called "Linked strips". Should this be changed, and if so, to which icon
@pablovazquez opinions on what icon to use to…
Would probably be less error prone to introduce a constant for both lines of code, e.g.
Minor: to me probably would read easier if bool changed = false
would be moved further below, right before the LISTBASE_FOREACH
loop. And the !SEQ_is_strip_connected
check would simply return false.
Minor, and probably this is following existing code, but I'm wondering whether the comments for Identifiers
, Api callbacks
and Flags
are much useful here (and in SEQUENCER_OT_disconnect
). It is very clear what these function parts are already, without the comments.
What would orig_start
be used for? Currently indeed it seems to not be used for anything, so why have it at all?
seq_list
argument could be const blender::VectorSet<Sequence *> &
I think, no need to copy the whole vector set by value.
Minor: forward declaring struct SeqConnection;
in this header is not really needed?
Ah wait no, this also happens on main, but only with some specific file that I have. I was stupidly testing main with some different file, but this branch with that problematic file. Sorry! Move…
@iss hmm not sure indeed which behavior "feels more correct", I could also see arguments for either way :/
This ends up creating and shutting down a whole OS thread, basically for each sequencer frame that is being processed. Maybe that is not a big problem, but feels a bit like a waste. Wouldn't it be better to have one "prefetch thread" that does all this "free unused and prefetch anims", instead of spawning a new one many times per second?
My guess for what happens is:
parallel_load_anims
is called with two strips that are visible at once, but they share the same anim object- they get put onto two different worker threads…