- Kaunas, Lithuania
- https://aras-p.info/
- Joined on
2022-01-20 -
-
Yes there's quite a bit of logic that is weird/funky but I have not changed it, I just moved it from render.cc. Cleaning all that up and "somehow" improving which parts of strips want to show…
I don't understand it either. I just moved the function from render.cc, since it is no longer needed there. What is the logic of the function keeps on being mystery to me, but I have not changed…
While I was not able to test performance improvement on my Gold edit (see comment about C++ exception above), on another file that I have with several video tracks each cut into many pieces…
With latest commit on this PR, I am getting a C++ exception "resource deadlock would occur" (seemingly the mutex is already locked by the same thread? but not 100% sure). This is on Windows, on Gold (gold-edit-v804 - I forget where I got it from, Francesco or Sergey gave it to me, entering frame 2875).
Ah ok! I was not sure whether BLI utilities or C++ std is preferred. Will change.
Timeline area X axis coordinate is "frames", Y axis is "channels". So this is +-30 frames from what is visible, and +-1 channels. It is similar to the previous cache code, but indeed perhaps would…
Similar to my suggestion at #124549, maybe that behavior should be reverted, and actual logic changed to:
- Draw text with the color as it would be (from theme or elsewhere),
- Draw text outline…
As @Harley says, the glyph advancing right now is not correct. This can be easily seen in cursive/script fonts, e.g. "Dancing Script" (https://fontlibrary.org/en/font/dancing). Current main branch…
Minor: I'd think that using namespace blender is not needed since what follows is already a sub-namesspace of that (blender::seq)
