- Kaunas, Lithuania
- https://aras-p.info/
- Joined on
2022-01-20
Minor: forward declaring struct SeqConnection;
in this header is not really needed?
Ah wait no, this also happens on main, but only with some specific file that I have. I was stupidly testing main with some different file, but this branch with that problematic file. Sorry! Move…
@iss hmm not sure indeed which behavior "feels more correct", I could also see arguments for either way :/
This ends up creating and shutting down a whole OS thread, basically for each sequencer frame that is being processed. Maybe that is not a big problem, but feels a bit like a waste. Wouldn't it be better to have one "prefetch thread" that does all this "free unused and prefetch anims", instead of spawning a new one many times per second?
My guess for what happens is:
parallel_load_anims
is called with two strips that are visible at once, but they share the same anim object- they get put onto two different worker threads…
Looking at the code, this should be unrelated to this PR
Well I dunno. It consistently happens for me in this PR, and consistently does not happen without this PR. I'm testing on windows…
For me this happens in "scene3" of this file, does not happen in "scene2" or "scene1" of the same file. What is different in scene3, is that the same source video file is used multiple times at…
@iss my take is that this issue, as formulated right now, is too vague/nebulous to do anything about it.
First of all "pixel processing" is not the largest performance issue with the sequencer…
@Sean-Devonport thanks for testing (and I've learned how to spin up a computer In The Cloud, yay :))! I'll land this to main branch for 4.3, and will queue up a backport for upcoming 4.2.1.