Aras Pranckevicius aras_p
Aras Pranckevicius pushed to vse_fix_blur_on_color at aras_p/blender 2024-02-15 10:13:51 +01:00
3c1367e74b VSE: Generalize the check from just Color/Text to any effect that has no inputs
9ed76d8bfb Merge branch 'main' into vse_fix_blur_on_color
5c87dfd269 Cleanup: use BLI_time_ prefix for time functions
e6c919830c Cleanup: Remove unused logging macros that free the input string
e9fff6124c Merge branch 'blender-v4.1-release'
Compare 109 commits »
Aras Pranckevicius pushed to main at aras_p/blender 2024-02-15 10:13:40 +01:00
5c87dfd269 Cleanup: use BLI_time_ prefix for time functions
e6c919830c Cleanup: Remove unused logging macros that free the input string
e9fff6124c Merge branch 'blender-v4.1-release'
f1cb2fa74b Fix: Crash with logging after recent std::string cleanup
34ed7ee2d9 Merge branch 'blender-v4.1-release'
Compare 106 commits »
Aras Pranckevicius commented on issue blender/blender#118288 2024-02-15 08:21:58 +01:00
VSE: Strips Design Tweaks

@pablovazquez another question I have, how/if does this interact with the strip resizing "handles". Right now these are just "wider" rectangles on either side of the strip. With the proposed…

Aras Pranckevicius commented on issue blender/blender#118288 2024-02-15 05:58:06 +01:00
VSE: Strips Design Tweaks

@nickberckley @mod_moder rounded corners are possible to do, I'm just trying to clarify whether they are implied by this design (judging from the screenshots), or not (since the text never…

Aras Pranckevicius commented on issue blender/blender#118288 2024-02-14 20:57:28 +01:00
VSE: Strips Design Tweaks

This looks great! But looking at the design mockups, my questions are about... the rounded corners lol :)

IMHO, the very slightly rounded corners do make the overall look much better. But,…

Aras Pranckevicius commented on pull request blender/blender#118269 2024-02-14 18:08:00 +01:00
Fix #118213: Applying effects to VSE Color/Text strips makes both the effect and source strip visible

Yeah, I'll test whether generalizing this to "effects with zero inputs" does not "horribly break" other strips (like adjustment layers), and update the code.

Aras Pranckevicius commented on pull request blender/blender#118269 2024-02-14 17:42:50 +01:00
Fix #118213: Applying effects to VSE Color/Text strips makes both the effect and source strip visible

So if you place color strip above the effect, both strips would be rendered. It is probably rare case, but I think it should be supported. Will have to check how your code behaves.

Yes, that…

Aras Pranckevicius created pull request blender/blender#118269 2024-02-14 13:43:34 +01:00
Fix #118213: Applying effects to VSE Color/Text strips makes both the effect and source strip visible
Aras Pranckevicius created branch vse_fix_blur_on_color in aras_p/blender 2024-02-14 13:40:47 +01:00
Aras Pranckevicius pushed to vse_fix_blur_on_color at aras_p/blender 2024-02-14 13:40:47 +01:00
3d4a45a1d5 Fix #118213: Applying effects to VSE Color/Text strips makes both the effect and source strip visible
Aras Pranckevicius commented on issue blender/blender#118213 2024-02-14 12:46:52 +01:00
VSE: Applying Blur to Color strip produces different result than to same color Image strip

@iss found what is the cause of different outline in your "complex text effect stack" file between 3.6 and 4.0 -- the effect was seemingly relying on strip color Multiply affecting the alpha…

Aras Pranckevicius commented on issue blender/blender#118213 2024-02-13 20:10:25 +01:00
VSE: Applying Blur to Color strip produces different result than to same color Image strip

@iss hmm, that file is produced with Blender 3.6, it seems... and it renders differently between 3.6 and 4.0 already (same in 4.1/4.2 as in 4.0). Not sure if by design, or something "broke" lol.

Aras Pranckevicius commented on issue blender/blender#118155 2024-02-13 19:52:54 +01:00
VSE Improve video decoding delays

That's a curious cache design!

Some caching systems I've worked on in the past would have approached this differently, something like:

  • There's no "linking" of related results at all, -…
Aras Pranckevicius commented on issue blender/blender#118213 2024-02-13 19:26:26 +01:00
VSE: Applying Blur to Color strip produces different result than to same color Image strip

I can fairly easily think of how to solve this, and I think (hope) for Color strips that would not cause practical problems. Not sure about Text strips though, e.g. today if you just add a blur…

Aras Pranckevicius opened issue blender/blender#118213 2024-02-13 19:05:42 +01:00
VSE: Applying Blur to Color strip produces different result than to same color Image strip
Aras Pranckevicius commented on pull request blender/blender#118176 2024-02-13 18:18:04 +01:00
Cleanup: Remove redundant return statement

LGTM. Yeah no idea why the code is like this, the extra return statement seems to be clearly unnecessary.

Aras Pranckevicius deleted branch vse_effect_tests from aras_p/blender 2024-02-13 13:20:36 +01:00
Aras Pranckevicius pushed to main at blender/blender 2024-02-13 13:20:35 +01:00
aa37aa5fe1 Tests: Add sequencer effect render tests
Aras Pranckevicius merged pull request blender/blender#118200 2024-02-13 13:20:34 +01:00
Tests: Add sequencer effect render tests