archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

Code cleanup: de-duplicate switch statement, style edits

Browse Source
This commit is contained in:
Campbell Barton
2014-03-13 06:18:25 +11:00
parent deef641878
commit 032b42d48d
7 changed files with 32 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
source/blender/compositor/nodes/COM_CornerPinNode.cpp
View File

@@ -47,7 +47,7 @@ void CornerPinNode::convertToOperations(ExecutionSystem *graph, CompositorContex
input_image->relinkConnections(warp_image_operation->getInputSocket(0), 0, graph);
for (int i = 0; i < 4; ++i) {
int node_index = node_corner_index[i];
getInputSocket(node_index)->relinkConnections(warp_image_operation->getInputSocket(i+1),
getInputSocket(node_index)->relinkConnections(warp_image_operation->getInputSocket(i + 1),
node_index, graph);
}
output_warped_image->relinkConnections(warp_image_operation->getOutputSocket());
@@ -59,7 +59,7 @@ void CornerPinNode::convertToOperations(ExecutionSystem *graph, CompositorContex
/* connect mask op inputs to the same sockets as the warp image op */
for (int i = 0; i < 4; ++i)
addLink(graph,
warp_image_operation->getInputSocket(i+1)->getConnection()->getFromSocket(),
warp_image_operation->getInputSocket(i + 1)->getConnection()->getFromSocket(),
plane_mask_operation->getInputSocket(i));
output_plane->relinkConnections(plane_mask_operation->getOutputSocket());

2
source/blender/editors/interface/interface.c
View File

@@ -1096,7 +1096,7 @@ void uiEndBlock(const bContext *C, uiBlock *block)
block->auto_open_last = block->oldblock->auto_open_last;
block->tooltipdisabled = block->oldblock->tooltipdisabled;
copy_v3_v3(ui_block_hsv_get(block),
ui_block_hsv_get(block->oldblock));
ui_block_hsv_get(block->oldblock));
block->oldblock = NULL;
}

8
source/blender/editors/interface/interface_regions.c
View File

@@ -1897,10 +1897,6 @@ static void uiBlockPicker(uiBlock *block, float rgba[4], PointerRNA *ptr, Proper
RNA_property_float_get_array(ptr, prop, rgba);
switch (U.color_picker_type) {
case USER_CP_CIRCLE_HSV:
case USER_CP_CIRCLE_HSL:
circle_picker(block, ptr, prop);
break;
case USER_CP_SQUARE_SV:
square_picker(block, ptr, prop, UI_GRAD_SV);
break;
@@ -1910,6 +1906,10 @@ static void uiBlockPicker(uiBlock *block, float rgba[4], PointerRNA *ptr, Proper
case USER_CP_SQUARE_HV:
square_picker(block, ptr, prop, UI_GRAD_HV);
break;
/* user default */
case USER_CP_CIRCLE_HSV:
case USER_CP_CIRCLE_HSL:
default:
circle_picker(block, ptr, prop);
break;

23
source/blender/editors/interface/interface_templates.c
View File

@@ -2240,11 +2240,6 @@ void uiTemplateColorPicker(uiLayout *layout, PointerRNA *ptr, const char *propna
row = uiLayoutRow(col, true);
switch (U.color_picker_type) {
case USER_CP_CIRCLE_HSV:
case USER_CP_CIRCLE_HSL:
but = uiDefButR_prop(block, HSVCIRCLE, 0, "", 0, 0, WHEEL_SIZE, WHEEL_SIZE, ptr, prop,
-1, 0.0, 0.0, 0, 0, "");
break;
case USER_CP_SQUARE_SV:
but = uiDefButR_prop(block, HSVCUBE, 0, "", 0, 0, WHEEL_SIZE, WHEEL_SIZE, ptr, prop,
-1, 0.0, 0.0, UI_GRAD_SV, 0, "");
@@ -2257,9 +2252,13 @@ void uiTemplateColorPicker(uiLayout *layout, PointerRNA *ptr, const char *propna
but = uiDefButR_prop(block, HSVCUBE, 0, "", 0, 0, WHEEL_SIZE, WHEEL_SIZE, ptr, prop,
-1, 0.0, 0.0, UI_GRAD_HV, 0, "");
break;
/* user default */
case USER_CP_CIRCLE_HSV:
case USER_CP_CIRCLE_HSL:
default:
but = uiDefButR_prop(block, HSVCIRCLE, 0, "", 0, 0, WHEEL_SIZE, WHEEL_SIZE, ptr, prop,
-1, 0.0, 0.0, 0, 0, "");
-1, 0.0, 0.0, 0, 0, "");
break;
}
@@ -2281,15 +2280,10 @@ void uiTemplateColorPicker(uiLayout *layout, PointerRNA *ptr, const char *propna
if (value_slider) {
switch (U.color_picker_type) {
case USER_CP_CIRCLE_HSV:
uiItemS(row);
uiDefButR_prop(block, HSVCUBE, 0, "", WHEEL_SIZE + 6, 0, 14, WHEEL_SIZE, ptr, prop,
-1, softmin, softmax, UI_GRAD_V_ALT, 0, "");
break;
case USER_CP_CIRCLE_HSL:
uiItemS(row);
uiDefButR_prop(block, HSVCUBE, 0, "", WHEEL_SIZE + 6, 0, 14, WHEEL_SIZE, ptr, prop,
-1, softmin, softmax, UI_GRAD_L_ALT, 0, "");
-1, softmin, softmax, UI_GRAD_L_ALT, 0, "");
break;
case USER_CP_SQUARE_SV:
uiItemS(col);
@@ -2306,10 +2300,13 @@ void uiTemplateColorPicker(uiLayout *layout, PointerRNA *ptr, const char *propna
uiDefButR_prop(block, HSVCUBE, 0, "", 0, 4, WHEEL_SIZE, 18, ptr, prop,
-1, softmin, softmax, UI_GRAD_HV + 3, 0, "");
break;
/* user default */
case USER_CP_CIRCLE_HSV:
default:
uiItemS(row);
uiDefButR_prop(block, HSVCUBE, 0, "", WHEEL_SIZE + 6, 0, 14, WHEEL_SIZE, ptr, prop,
-1, softmin, softmax, UI_GRAD_V_ALT, 0, "");
-1, softmin, softmax, UI_GRAD_V_ALT, 0, "");
break;
}
}

10
source/blender/editors/transform/transform_conversions.c
View File

@@ -3012,7 +3012,10 @@ static int gpf_cmp_frame(void *thunk, void *a, void *b)
*((bool *)thunk) = true;
/* selected last */
if ((frame_a->flag & GP_FRAME_SELECT) &&
((frame_b->flag & GP_FRAME_SELECT) == 0)) return 1;
((frame_b->flag & GP_FRAME_SELECT) == 0))
{
return 1;
}
return 0;
}
@@ -3026,7 +3029,10 @@ static int masklay_shape_cmp_frame(void *thunk, void *a, void *b)
*((bool *)thunk) = true;
/* selected last */
if ((frame_a->flag & MASK_SHAPE_SELECT) &&
((frame_b->flag & MASK_SHAPE_SELECT) == 0)) return 1;
((frame_b->flag & MASK_SHAPE_SELECT) == 0))
{
return 1;
}
return 0;
}

12
source/blender/makesrna/intern/rna_nodetree.c
View File

@@ -3430,13 +3430,13 @@ static void def_sh_tex_image(StructRNA *srna)
static const EnumPropertyItem prop_interpolation_items[] = {
{SHD_INTERP_LINEAR, "Linear", 0, "Linear",
"Linear interpolation"},
"Linear interpolation"},
{SHD_INTERP_CLOSEST, "Closest", 0, "Closest",
"No interpolation (sample closest texel"},
{SHD_INTERP_CUBIC, "Cubic", 0, "Cubic",
"Cubic interpolation (OSL only)"},
{SHD_INTERP_SMART, "Smart", 0, "Smart",
"Bicubic when maxifying, else bilinear (OSL only)"},
"No interpolation (sample closest texel"},
{SHD_INTERP_CUBIC, "Cubic", 0, "Cubic",
"Cubic interpolation (OSL only)"},
{SHD_INTERP_SMART, "Smart", 0, "Smart",
"Bicubic when maxifying, else bilinear (OSL only)"},
{0, NULL, 0, NULL, NULL}
};

2
source/blender/nodes/composite/nodes/node_composite_cornerpin.c
View File

@@ -26,7 +26,7 @@
* ***** END GPL LICENSE BLOCK *****
*/
/** \file blender/nodes/composite/nodes/node_composite_planetrackdeform.c
/** \file blender/nodes/composite/nodes/node_composite_cornerpin.c
* \ingroup cmpnodes
*/