archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

Fix T67876: 2D Stabilization doesn't compensate rotation in spacial cases

Browse Source 
This was caused by 2D stabilization trying to be smart and lower weight
of tracks which are too close to the rotation center. This was causing
algorithm to ignore a single track which was set to constant 1 weight and
used for rotation compensation.

It is quite tricky to quantify this change without having comprehensive
regression suit, so can only hope that initial intention is still working
as expected.
This commit is contained in:
Sergey Sharybin
2019-07-29 12:26:47 +02:00
parent 60d71ffbe9
commit 92f6e60f46
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
source/blender/blenkernel/intern/tracking_stabilize.c
View File

@@ -611,16 +611,19 @@ static bool average_track_contributions(StabContext *ctx,
float rotation, scale, quality;
quality = rotation_contribution(
stabilization_base, marker, aspect, r_pivot, &rotation, &scale);
weight *= quality;
weight_sum += weight;
*r_angle += rotation * weight;
const float quality_weight = weight * quality;
weight_sum += quality_weight;
*r_angle += rotation * quality_weight;
if (stab->flag & TRACKING_STABILIZE_SCALE) {
*r_scale_step += logf(scale) * weight;
*r_scale_step += logf(scale) * quality_weight;
}
else {
*r_scale_step = 0;
}
ok |= (weight_sum > EPSILON_WEIGHT);
/* NOTE: Use original marker weight and not the scaled one with the proximity here to allow
* simple stabilization setups when there is a single track in a close proximity of the
* center. */
ok |= (weight > EPSILON_WEIGHT);
}
}
}