archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

Generalizing the graph code used for Reeb graphs and Rig (Armature) graphs

Browse Source 
Removing a lot of duplicated code
This commit is contained in:
Martin Poirier
2008-05-28 16:39:05 +00:00
parent db44a4a1a7
commit ab787c9765
6 changed files with 1235 additions and 1573 deletions
Download Patch File Download Diff File Expand all files Collapse all files

102
source/blender/blenlib/BLI_graph.h Normal file
View File

@@ -0,0 +1,102 @@
#ifndef BLI_GRAPH_H_
#define BLI_GRAPH_H_
#include "DNA_listBase.h"
struct BGraph;
struct BNode;
struct BArc;
struct RadialArc;
typedef void (*FreeArc)(struct BArc*);
typedef void (*FreeNode)(struct BNode*);
typedef void (*RadialSymmetry)(struct BNode* root_node, struct RadialArc* ring, int total);
typedef void (*AxialSymmetry)(struct BNode* root_node, struct BNode* node1, struct BNode* node2, struct BArc* arc1, struct BArc* arc2);
/* IF YOU MODIFY THOSE TYPES, YOU NEED TO UPDATE ALL THOSE THAT "INHERIT" FROM THEM
*
* RigGraph, ReebGraph
*
* */
typedef struct BGraph {
ListBase arcs;
ListBase nodes;
/* function pointer to deal with custom fonctionnality */
FreeArc free_arc;
FreeNode free_node;
RadialSymmetry radial_symmetry;
AxialSymmetry axial_symmetry;
} BGraph;
typedef struct BNode {
void *next, *prev;
float p[3];
int flag;
int degree;
struct BArc **arcs;
int symmetry_level;
int symmetry_flag;
float symmetry_axis[3];
} BNode;
typedef struct BArc {
void *next, *prev;
struct BNode *head, *tail;
int flag;
float length;
int symmetry_level;
int symmetry_flag;
} BArc;
/* Helper structure for radial symmetry */
typedef struct RadialArc
{
struct BArc *arc;
float n[3]; /* normalized vector joining the nodes of the arc */
} RadialArc;
BNode *BLI_otherNode(BArc *arc, BNode *node);
void BLI_freeNode(BGraph *graph, BNode *node);
void BLI_flagNodes(BGraph *graph, int flag);
void BLI_flagArcs(BGraph *graph, int flag);
int BLI_hasAdjacencyList(BGraph *rg);
void BLI_buildAdjacencyList(BGraph *rg);
void BLI_replaceNode(BGraph *graph, BNode *node_src, BNode *node_replaced);
void BLI_removeDoubleNodes(BGraph *graph, float limit);
BArc * BLI_findConnectedArc(BGraph *graph, BArc *arc, BNode *v);
int BLI_isGraphCyclic(BGraph *graph);
/*------------ Symmetry handling ------------*/
// float limit = G.scene->toolsettings->skgen_symmetry_limit;
void BLI_markdownSymmetry(BGraph *graph, BNode *root_node, float limit);
void BLI_mirrorAlongAxis(float v[3], float center[3], float axis[3]);
/* BNode symmetry flags */
#define SYM_TOPOLOGICAL 1
#define SYM_PHYSICAL 2
/* the following two are exclusive */
#define SYM_AXIAL 4
#define SYM_RADIAL 8
/* BArc symmetry flags
*
* axial symetry sides */
#define SYM_SIDE_POSITIVE 1
#define SYM_SIDE_NEGATIVE 2
#endif /*BLI_GRAPH_H_*/

678
source/blender/blenlib/intern/graph.c Normal file
View File

@@ -0,0 +1,678 @@
/**
* $Id:
*
* ***** BEGIN GPL LICENSE BLOCK *****
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
*
* Contributor(s): Martin Poirier
*
* ***** END GPL LICENSE BLOCK *****
* graph.c: Common graph interface and methods
*/
#include "MEM_guardedalloc.h"
#include "BLI_graph.h"
#include "BLI_blenlib.h"
#include "BLI_arithb.h"
#include "BKE_utildefines.h"
void BLI_freeNode(BGraph *graph, BNode *node)
{
if (node->arcs)
{
MEM_freeN(node->arcs);
}
if (graph->free_node)
{
graph->free_node(node);
}
}
BNode *BLI_otherNode(BArc *arc, BNode *node)
{
return (arc->head == node) ? arc->tail : arc->head;
}
void BLI_flagNodes(BGraph *graph, int flag)
{
BNode *node;
for(node = graph->nodes.first; node; node = node->next)
{
node->flag = flag;
}
}
void BLI_flagArcs(BGraph *graph, int flag)
{
BArc *arc;
for(arc = graph->arcs.first; arc; arc = arc->next)
{
arc->flag = flag;
}
}
static void addArcToNodeAdjacencyList(BNode *node, BArc *arc)
{
node->arcs[node->degree] = arc;
node->degree++;
}
void BLI_buildAdjacencyList(BGraph *rg)
{
BNode *node;
BArc *arc;
for(node = rg->nodes.first; node; node = node->next)
{
if (node->arcs != NULL)
{
MEM_freeN(node->arcs);
}
node->arcs = MEM_callocN((node->degree) * sizeof(BArc*), "adjacency list");
/* temporary use to indicate the first index available in the lists */
node->degree = 0;
}
for(arc = rg->arcs.first; arc; arc= arc->next)
{
addArcToNodeAdjacencyList(arc->head, arc);
addArcToNodeAdjacencyList(arc->tail, arc);
}
}
int BLI_hasAdjacencyList(BGraph *rg)
{
BNode *node;
for(node = rg->nodes.first; node; node = node->next)
{
if (node->arcs == NULL)
{
return 0;
}
}
return 1;
}
void BLI_replaceNode(BGraph *graph, BNode *node_src, BNode *node_replaced)
{
BArc *arc, *next_arc;
for (arc = graph->arcs.first; arc; arc = next_arc)
{
next_arc = arc->next;
if (arc->head == node_replaced)
{
arc->head = node_src;
node_src->degree++;
}
if (arc->tail == node_replaced)
{
arc->tail = node_src;
node_src->degree++;
}
if (arc->head == arc->tail)
{
node_src->degree -= 2;
graph->free_arc(arc);
BLI_freelinkN(&graph->arcs, arc);
}
}
}
void BLI_removeDoubleNodes(BGraph *graph, float limit)
{
BNode *node_src, *node_replaced;
for(node_src = graph->nodes.first; node_src; node_src = node_src->next)
{
for(node_replaced = graph->nodes.first; node_replaced; node_replaced = node_replaced->next)
{
if (node_replaced != node_src && VecLenf(node_replaced->p, node_src->p) <= limit)
{
BLI_replaceNode(graph, node_src, node_replaced);
BLI_freeNode(graph, node_replaced);
BLI_remlink(&graph->nodes, node_replaced);
}
}
}
}
/*************************************** CYCLE DETECTION ***********************************************/
int detectCycle(BNode *node, BArc *src_arc)
{
int value = 0;
if (node->flag == 0)
{
int i;
/* mark node as visited */
node->flag = 1;
for(i = 0; i < node->degree && value == 0; i++)
{
BArc *arc = node->arcs[i];
/* don't go back on the source arc */
if (arc != src_arc)
{
value = detectCycle(BLI_otherNode(arc, node), arc);
}
}
}
else
{
value = 1;
}
return value;
}
int BLI_isGraphCyclic(BGraph *graph)
{
BNode *node;
int value = 0;
/* NEED TO CHECK IF ADJACENCY LIST EXIST */
/* Mark all nodes as not visited */
BLI_flagNodes(graph, 0);
/* detectCycles in subgraphs */
for(node = graph->nodes.first; node && value == 0; node = node->next)
{
/* only for nodes in subgraphs that haven't been visited yet */
if (node->flag == 0)
{
value = value || detectCycle(node, NULL);
}
}
return value;
}
BArc * BLI_findConnectedArc(BGraph *graph, BArc *arc, BNode *v)
{
BArc *nextArc = arc->next;
for(nextArc = graph->arcs.first; nextArc; nextArc = nextArc->next)
{
if (arc != nextArc && (nextArc->head == v || nextArc->tail == v))
{
break;
}
}
return nextArc;
}
/*********************************** GRAPH AS TREE FUNCTIONS *******************************************/
int BLI_subtreeDepth(BNode *node, BArc *rootArc)
{
int depth = 0;
/* Base case, no arcs leading away */
if (node->arcs == NULL || *(node->arcs) == NULL)
{
return 0;
}
else
{
int i;
for(i = 0; i < node->degree; i++)
{
BArc *arc = node->arcs[i];
/* only arcs that go down the tree */
if (arc != rootArc)
{
BNode *newNode = BLI_otherNode(arc, node);
depth = MAX2(depth, BLI_subtreeDepth(newNode, arc));
}
}
}
return depth + 1; //BLI_countlist(&rootArc->edges);
}
/********************************* SYMMETRY DETECTION **************************************************/
void markdownSymmetryArc(BGraph *graph, BArc *arc, BNode *node, int level, float limit);
void BLI_mirrorAlongAxis(float v[3], float center[3], float axis[3])
{
float dv[3], pv[3];
VecSubf(dv, v, center);
Projf(pv, dv, axis);
VecMulf(pv, -2);
VecAddf(v, v, pv);
}
static void markRadialSymmetry(BGraph *graph, BNode *node, int depth, float axis[3], float limit)
{
RadialArc *ring = NULL;
RadialArc *unit;
int symmetric = 1;
int count = 0;
int i;
/* mark topological symmetry */
node->symmetry_flag |= SYM_TOPOLOGICAL;
/* count the number of arcs in the symmetry ring */
for (i = 0; i < node->degree; i++)
{
BArc *connectedArc = node->arcs[i];
/* depth is store as a negative in flag. symmetry level is positive */
if (connectedArc->symmetry_level == -depth)
{
count++;
}
}
ring = MEM_callocN(sizeof(RadialArc) * count, "radial symmetry ring");
unit = ring;
/* fill in the ring */
for (unit = ring, i = 0; i < node->degree; i++)
{
BArc *connectedArc = node->arcs[i];
/* depth is store as a negative in flag. symmetry level is positive */
if (connectedArc->symmetry_level == -depth)
{
BNode *otherNode = BLI_otherNode(connectedArc, node);
float vec[3];
unit->arc = connectedArc;
/* project the node to node vector on the symmetry plane */
VecSubf(unit->n, otherNode->p, node->p);
Projf(vec, unit->n, axis);
VecSubf(unit->n, unit->n, vec);
Normalize(unit->n);
unit++;
}
}
/* sort ring */
for (i = 0; i < count - 1; i++)
{
float minAngle = 3; /* arbitrary high value, higher than 2, at least */
int minIndex = -1;
int j;
for (j = i + 1; j < count; j++)
{
float angle = Inpf(ring[i].n, ring[j].n);
/* map negative values to 1..2 */
if (angle < 0)
{
angle = 1 - angle;
}
if (angle < minAngle)
{
minIndex = j;
minAngle = angle;
}
}
/* swap if needed */
if (minIndex != i + 1)
{
RadialArc tmp;
tmp = ring[i + 1];
ring[i + 1] = ring[minIndex];
ring[minIndex] = tmp;
}
}
for (i = 0; i < count && symmetric; i++)
{
BNode *node1, *node2;
float tangent[3];
float normal[3];
float p[3];
int j = (i + 1) % count; /* next arc in the circular list */
VecAddf(tangent, ring[i].n, ring[j].n);
Crossf(normal, tangent, axis);
node1 = BLI_otherNode(ring[i].arc, node);
node2 = BLI_otherNode(ring[j].arc, node);
VECCOPY(p, node2->p);
BLI_mirrorAlongAxis(p, node->p, normal);
/* check if it's within limit before continuing */
if (VecLenf(node1->p, p) > limit)
{
symmetric = 0;
}
}
if (symmetric)
{
/* mark node as symmetric physically */
VECCOPY(node->symmetry_axis, axis);
node->symmetry_flag |= SYM_PHYSICAL;
node->symmetry_flag |= SYM_RADIAL;
if (graph->radial_symmetry)
{
graph->radial_symmetry(node, ring, count);
}
}
MEM_freeN(ring);
}
static void setSideAxialSymmetry(BNode *root_node, BNode *end_node, BArc *arc)
{
float vec[3];
VecSubf(vec, end_node->p, root_node->p);
if (Inpf(vec, root_node->symmetry_axis) < 0)
{
arc->symmetry_flag |= SYM_SIDE_NEGATIVE;
}
else
{
arc->symmetry_flag |= SYM_SIDE_POSITIVE;
}
}
static void markAxialSymmetry(BGraph *graph, BNode *node, int depth, float axis[3], float limit)
{
BArc *arc1 = NULL;
BArc *arc2 = NULL;
BNode *node1 = NULL, *node2 = NULL;
float nor[3], vec[3], p[3];
int i;
/* mark topological symmetry */
node->symmetry_flag |= SYM_TOPOLOGICAL;
for (i = 0; i < node->degree; i++)
{
BArc *connectedArc = node->arcs[i];
/* depth is store as a negative in flag. symmetry level is positive */
if (connectedArc->symmetry_level == -depth)
{
if (arc1 == NULL)
{
arc1 = connectedArc;
node1 = BLI_otherNode(arc1, node);
}
else
{
arc2 = connectedArc;
node2 = BLI_otherNode(arc2, node);
break; /* Can stop now, the two arcs have been found */
}
}
}
/* shouldn't happen, but just to be sure */
if (node1 == NULL || node2 == NULL)
{
return;
}
VecSubf(vec, node1->p, node->p);
Normalize(vec);
VecSubf(p, node->p, node2->p);
Normalize(p);
VecAddf(p, p, vec);
Crossf(vec, p, axis);
Crossf(nor, vec, axis);
/* mirror node2 along axis */
VECCOPY(p, node2->p);
BLI_mirrorAlongAxis(p, node->p, nor);
/* check if it's within limit before continuing */
if (VecLenf(node1->p, p) <= limit)
{
/* mark node as symmetric physically */
VECCOPY(node->symmetry_axis, nor);
node->symmetry_flag |= SYM_PHYSICAL;
node->symmetry_flag |= SYM_AXIAL;
/* set side on arcs */
setSideAxialSymmetry(node, node1, arc1);
setSideAxialSymmetry(node, node2, arc2);
if (graph->axial_symmetry)
{
graph->axial_symmetry(node, node1, node2, arc1, arc2);
}
}
}
static void markdownSecondarySymmetry(BGraph *graph, BNode *node, int depth, int level, float limit)
{
float axis[3] = {0, 0, 0};
int count = 0;
int i;
/* count the number of branches in this symmetry group
* and determinte the axis of symmetry
* */
for (i = 0; i < node->degree; i++)
{
BArc *connectedArc = node->arcs[i];
/* depth is store as a negative in flag. symmetry level is positive */
if (connectedArc->symmetry_level == -depth)
{
count++;
}
/* If arc is on the axis */
else if (connectedArc->symmetry_level == level)
{
VecAddf(axis, axis, connectedArc->head->p);
VecSubf(axis, axis, connectedArc->tail->p);
}
}
Normalize(axis);
/* Split between axial and radial symmetry */
if (count == 2)
{
markAxialSymmetry(graph, node, depth, axis, limit);
}
else
{
markRadialSymmetry(graph, node, depth, axis, limit);
}
/* markdown secondary symetries */
for (i = 0; i < node->degree; i++)
{
BArc *connectedArc = node->arcs[i];
if (connectedArc->symmetry_level == -depth)
{
/* markdown symmetry for branches corresponding to the depth */
markdownSymmetryArc(graph, connectedArc, node, level + 1, limit);
}
}
}
void markdownSymmetryArc(BGraph *graph, BArc *arc, BNode *node, int level, float limit)
{
int i;
arc->symmetry_level = level;
node = BLI_otherNode(arc, node);
for (i = 0; i < node->degree; i++)
{
BArc *connectedArc = node->arcs[i];
if (connectedArc != arc)
{
BNode *connectedNode = BLI_otherNode(connectedArc, node);
/* symmetry level is positive value, negative values is subtree depth */
connectedArc->symmetry_level = -BLI_subtreeDepth(connectedNode, connectedArc);
}
}
arc = NULL;
for (i = 0; i < node->degree; i++)
{
int issymmetryAxis = 0;
BArc *connectedArc = node->arcs[i];
/* only arcs not already marked as symetric */
if (connectedArc->symmetry_level < 0)
{
int j;
/* true by default */
issymmetryAxis = 1;
for (j = 0; j < node->degree && issymmetryAxis == 1; j++)
{
BArc *otherArc = node->arcs[j];
/* different arc, same depth */
if (otherArc != connectedArc && otherArc->symmetry_level == connectedArc->symmetry_level)
{
/* not on the symmetry axis */
issymmetryAxis = 0;
}
}
}
/* arc could be on the symmetry axis */
if (issymmetryAxis == 1)
{
/* no arc as been marked previously, keep this one */
if (arc == NULL)
{
arc = connectedArc;
}
else
{
/* there can't be more than one symmetry arc */
arc = NULL;
break;
}
}
}
/* go down the arc continuing the symmetry axis */
if (arc)
{
markdownSymmetryArc(graph, arc, node, level, limit);
}
/* secondary symmetry */
for (i = 0; i < node->degree; i++)
{
BArc *connectedArc = node->arcs[i];
/* only arcs not already marked as symetric and is not the next arc on the symmetry axis */
if (connectedArc->symmetry_level < 0)
{
/* subtree depth is store as a negative value in the symmetry */
markdownSecondarySymmetry(graph, node, -connectedArc->symmetry_level, level, limit);
}
}
}
void BLI_markdownSymmetry(BGraph *graph, BNode *root_node, float limit)
{
BNode *node;
BArc *arc;
if (BLI_isGraphCyclic(graph))
{
return;
}
/* mark down all arcs as non-symetric */
BLI_flagArcs(graph, 0);
/* mark down all nodes as not on the symmetry axis */
BLI_flagNodes(graph, 0);
node = root_node;
/* only work on acyclic graphs and if only one arc is incident on the first node */
if (node->degree == 1)
{
arc = node->arcs[0];
markdownSymmetryArc(graph, arc, node, 1, limit);
/* mark down non-symetric arcs */
for (arc = graph->arcs.first; arc; arc = arc->next)
{
if (arc->symmetry_level < 0)
{
arc->symmetry_level = 0;
}
else
{
/* mark down nodes with the lowest level symmetry axis */
if (arc->head->symmetry_level == 0 || arc->head->symmetry_level > arc->symmetry_level)
{
arc->head->symmetry_level = arc->symmetry_level;
}
if (arc->tail->symmetry_level == 0 || arc->tail->symmetry_level > arc->symmetry_level)
{
arc->tail->symmetry_level = arc->symmetry_level;
}
}
}
}
}

69
source/blender/include/reeb.h
View File

@@ -30,6 +30,8 @@
#include "DNA_listBase.h"
#include "BLI_graph.h"
struct GHash;
struct EdgeHash;
struct ReebArc;
@@ -37,8 +39,15 @@ struct ReebEdge;
struct ReebNode;
typedef struct ReebGraph {
ListBase arcs;
ListBase nodes;
ListBase arcs;
ListBase nodes;
FreeArc free_arc;
FreeNode free_node;
RadialSymmetry radial_symmetry;
AxialSymmetry axial_symmetry;
/*********************************/
int totnodes;
struct EdgeHash *emap;
} ReebGraph;
@@ -50,17 +59,20 @@ typedef struct EmbedBucket {
} EmbedBucket;
typedef struct ReebNode {
struct ReebNode *next, *prev;
struct ReebArc **arcs;
int index;
int degree;
float weight;
void *next, *prev;
float p[3];
int flag;
int degree;
struct ReebArc **arcs;
int symmetry_level;
int symmetry_flag;
float symmetry_axis[3];
/*********************************/
int index;
float weight;
} ReebNode;
typedef struct ReebEdge {
@@ -72,15 +84,19 @@ typedef struct ReebEdge {
} ReebEdge;
typedef struct ReebArc {
struct ReebArc *next, *prev;
ListBase edges;
struct ReebNode *v1, *v2;
struct EmbedBucket *buckets;
int bcount;
void *next, *prev;
struct ReebNode *head, *tail;
int flag;
float length;
int symmetry_level;
int symmetry_flag;
/*********************************/
ListBase edges;
int bcount;
struct EmbedBucket *buckets;
struct GHash *faces;
float angle;
@@ -107,8 +123,6 @@ void renormalizeWeight(struct EditMesh *em, float newmax);
ReebGraph * generateReebGraph(struct EditMesh *me, int subdivisions);
ReebGraph * newReebGraph();
#define OTHER_NODE(arc, node) ((arc->v1 == node) ? arc->v2 : arc->v1)
void initArcIterator(struct ReebArcIterator *iter, struct ReebArc *arc, struct ReebNode *head);
void initArcIterator2(struct ReebArcIterator *iter, struct ReebArc *arc, int start, int end);
void initArcIteratorStart(struct ReebArcIterator *iter, struct ReebArc *arc, struct ReebNode *head, int start);
@@ -129,36 +143,9 @@ void repositionNodes(ReebGraph *rg);
void postprocessGraph(ReebGraph *rg, char mode);
void removeNormalNodes(ReebGraph *rg);
/* Graph processing */
void buildAdjacencyList(ReebGraph *rg);
void sortNodes(ReebGraph *rg);
void sortArcs(ReebGraph *rg);
int subtreeDepth(ReebNode *node, ReebArc *rootArc);
int countConnectedArcs(ReebGraph *rg, ReebNode *node);
int hasAdjacencyList(ReebGraph *rg);
int isGraphCyclic(ReebGraph *rg);
/*------------ Symmetry handling ------------*/
void markdownSymmetry(ReebGraph *rg);
/* ReebNode symmetry flags */
#define SYM_TOPOLOGICAL 1
#define SYM_PHYSICAL 2
/* the following two are exclusive */
#define SYM_AXIAL 4
#define SYM_RADIAL 8
/* ReebArc symmetry flags
*
* axial symetry sides */
#define SYM_SIDE_POSITIVE 1
#define SYM_SIDE_NEGATIVE 2
/*------------ Sanity check ------------*/
void verifyBuckets(ReebGraph *rg);
void verifyFaces(ReebGraph *rg);

750
source/blender/src/autoarmature.c
View File

@@ -1,5 +1,5 @@
/**
* $Id: editarmature.c 14848 2008-05-15 08:05:56Z aligorith $
* $Id:
*
* ***** BEGIN GPL LICENSE BLOCK *****
*
@@ -46,6 +46,7 @@
#include "BLI_arithb.h"
#include "BLI_editVert.h"
#include "BLI_ghash.h"
#include "BLI_graph.h"
#include "BDR_editobject.h"
@@ -70,37 +71,47 @@ struct RigArc;
struct RigEdge;
typedef struct RigGraph {
ListBase arcs;
ListBase nodes;
struct RigNode *head;
ListBase arcs;
ListBase nodes;
FreeArc free_arc;
FreeNode free_node;
RadialSymmetry radial_symmetry;
AxialSymmetry axial_symmetry;
/*********************************/
struct RigNode *head;
ReebGraph *link;
} RigGraph;
typedef struct RigNode {
struct RigNode *next, *prev;
void *next, *prev;
float p[3];
int degree;
struct RigArc **arcs;
int flag;
int degree;
struct BArc **arcs;
int symmetry_level;
int symmetry_flag;
float symmetry_axis[3];
/*********************************/
ReebNode *link;
} RigNode;
typedef struct RigArc {
struct RigArc *next, *prev;
void *next, *prev;
RigNode *head, *tail;
ListBase edges;
float length;
int flag;
float length;
int symmetry_level;
int symmetry_flag;
/*********************************/
ListBase edges;
int count;
ReebArc *link;
} RigArc;
@@ -116,45 +127,7 @@ typedef struct RigEdge {
/*******************************************************************************************************/
static void RIG_calculateEdgeAngle(RigEdge *edge_first, RigEdge *edge_second);
void RIG_markdownSymmetry(RigGraph *rg);
void RIG_markdownSymmetryArc(RigArc *arc, RigNode *node, int level);
void RIG_markdownSecondarySymmetry(RigNode *node, int depth, int level);
/*******************************************************************************************************/
static RigNode *RIG_otherNode(RigArc *arc, RigNode *node)
{
if (arc->head == node)
return arc->tail;
else
return arc->head;
}
static void RIG_flagNodes(RigGraph *rg, int flag)
{
RigNode *node;
for(node = rg->nodes.first; node; node = node->next)
{
node->flag = flag;
}
}
static void RIG_flagArcs(RigGraph *rg, int flag)
{
RigArc *arc;
for(arc = rg->arcs.first; arc; arc = arc->next)
{
arc->flag = flag;
}
}
static void RIG_addArcToNodeAdjacencyList(RigNode *node, RigArc *arc)
{
node->arcs[node->degree] = arc;
node->degree++;
}
/*********************************** EDITBONE UTILS ****************************************************/
int countEditBoneChildren(ListBase *list, EditBone *parent)
@@ -192,6 +165,34 @@ EditBone* nextEditBoneChild(ListBase *list, EditBone *parent, int n)
return NULL;
}
/************************************ DESTRUCTORS ******************************************************/
void RIG_freeRigArc(BArc *arc)
{
BLI_freelistN(&((RigArc*)arc)->edges);
}
void RIG_freeRigGraph(BGraph *rg)
{
BNode *node;
BArc *arc;
for (arc = rg->arcs.first; arc; arc = arc->next)
{
RIG_freeRigArc(arc);
}
BLI_freelistN(&rg->arcs);
for (node = rg->nodes.first; node; node = node->next)
{
BLI_freeNode((BGraph*)rg, (BNode*)node);
}
BLI_freelistN(&rg->nodes);
MEM_freeN(rg);
}
/************************************* ALLOCATORS ******************************************************/
static RigGraph *newRigGraph()
@@ -201,6 +202,9 @@ static RigGraph *newRigGraph()
rg->head = NULL;
rg->free_arc = RIG_freeRigArc;
rg->free_node = NULL;
return rg;
}
@@ -209,7 +213,6 @@ static RigArc *newRigArc(RigGraph *rg)
RigArc *arc;
arc = MEM_callocN(sizeof(RigArc), "rig arc");
arc->length = 0;
arc->count = 0;
BLI_addtail(&rg->arcs, arc);
@@ -279,118 +282,13 @@ static void RIG_addEdgeToArc(RigArc *arc, float tail[3], EditBone *bone)
edge->length = VecLenf(edge->head, edge->tail);
arc->length += edge->length;
arc->count += 1;
}
/************************************ DESTRUCTORS ******************************************************/
static void RIG_freeRigNode(RigNode *node)
{
if (node->arcs)
{
MEM_freeN(node->arcs);
}
}
static void RIG_freeRigArc(RigArc *arc)
{
BLI_freelistN(&arc->edges);
}
static void RIG_freeRigGraph(RigGraph *rg)
{
RigNode *node;
RigArc *arc;
for (arc = rg->arcs.first; arc; arc = arc->next)
{
RIG_freeRigArc(arc);
}
BLI_freelistN(&rg->arcs);
for (node = rg->nodes.first; node; node = node->next)
{
RIG_freeRigNode(node);
}
BLI_freelistN(&rg->nodes);
MEM_freeN(rg);
}
/*******************************************************************************************************/
static void RIG_buildAdjacencyList(RigGraph *rg)
{
RigNode *node;
RigArc *arc;
for(node = rg->nodes.first; node; node = node->next)
{
if (node->arcs != NULL)
{
MEM_freeN(node->arcs);
}
node->arcs = MEM_callocN((node->degree + 1) * sizeof(RigArc*), "adjacency list");
/* temporary use to indicate the first index available in the lists */
node->degree = 0;
}
for(arc = rg->arcs.first; arc; arc= arc->next)
{
RIG_addArcToNodeAdjacencyList(arc->head, arc);
RIG_addArcToNodeAdjacencyList(arc->tail, arc);
}
}
static void RIG_replaceNode(RigGraph *rg, RigNode *node_src, RigNode *node_replaced)
{
RigArc *arc, *next_arc;
for (arc = rg->arcs.first; arc; arc = next_arc)
{
next_arc = arc->next;
if (arc->head == node_replaced)
{
arc->head = node_src;
node_src->degree++;
}
if (arc->tail == node_replaced)
{
arc->tail = node_src;
node_src->degree++;
}
if (arc->head == arc->tail)
{
node_src->degree -= 2;
RIG_freeRigArc(arc);
BLI_freelinkN(&rg->arcs, arc);
}
}
}
static void RIG_removeDoubleNodes(RigGraph *rg, float limit)
{
RigNode *node_src, *node_replaced;
for(node_src = rg->nodes.first; node_src; node_src = node_src->next)
{
for(node_replaced = rg->nodes.first; node_replaced; node_replaced = node_replaced->next)
{
if (node_replaced != node_src && VecLenf(node_replaced->p, node_src->p) <= limit)
{
RIG_replaceNode(rg, node_src, node_replaced);
}
}
}
}
static void RIG_calculateEdgeAngle(RigEdge *edge_first, RigEdge *edge_second)
{
float vec_first[3], vec_second[3];
@@ -404,483 +302,6 @@ static void RIG_calculateEdgeAngle(RigEdge *edge_first, RigEdge *edge_second)
edge_first->angle = saacos(Inpf(vec_first, vec_second));
}
/*********************************** GRAPH AS TREE FUNCTIONS *******************************************/
int RIG_subtreeDepth(RigNode *node, RigArc *rootArc)
{
int depth = 0;
/* Base case, no arcs leading away */
if (node->arcs == NULL || *(node->arcs) == NULL)
{
return 0;
}
else
{
RigArc ** pArc;
for(pArc = node->arcs; *pArc; pArc++)
{
RigArc *arc = *pArc;
/* only arcs that go down the tree */
if (arc != rootArc)
{
RigNode *newNode = RIG_otherNode(arc, node);
depth = MAX2(depth, RIG_subtreeDepth(newNode, arc));
}
}
}
return depth + BLI_countlist(&rootArc->edges);
}
int RIG_countConnectedArcs(RigGraph *rg, RigNode *node)
{
int count = 0;
/* use adjacency list if present */
if (node->arcs)
{
RigArc **arcs;
for(arcs = node->arcs; *arcs; arcs++)
{
count++;
}
}
else
{
RigArc *arc;
for(arc = rg->arcs.first; arc; arc = arc->next)
{
if (arc->head == node || arc->tail == node)
{
count++;
}
}
}
return count;
}
/********************************* SYMMETRY DETECTION **************************************************/
static void mirrorAlongAxis(float v[3], float center[3], float axis[3])
{
float dv[3], pv[3];
VecSubf(dv, v, center);
Projf(pv, dv, axis);
VecMulf(pv, -2);
VecAddf(v, v, pv);
}
/* Helper structure for radial symmetry */
typedef struct RadialArc
{
RigArc *arc;
float n[3]; /* normalized vector joining the nodes of the arc */
} RadialArc;
void RIG_markRadialSymmetry(RigNode *node, int depth, float axis[3])
{
RadialArc *ring = NULL;
RadialArc *unit;
float limit = G.scene->toolsettings->skgen_symmetry_limit;
int symmetric = 1;
int count = 0;
int i;
/* mark topological symmetry */
node->symmetry_flag |= SYM_TOPOLOGICAL;
/* count the number of arcs in the symmetry ring */
for (i = 0; node->arcs[i] != NULL; i++)
{
RigArc *connectedArc = node->arcs[i];
/* depth is store as a negative in flag. symmetry level is positive */
if (connectedArc->symmetry_level == -depth)
{
count++;
}
}
ring = MEM_callocN(sizeof(RadialArc) * count, "radial symmetry ring");
unit = ring;
/* fill in the ring */
for (unit = ring, i = 0; node->arcs[i] != NULL; i++)
{
RigArc *connectedArc = node->arcs[i];
/* depth is store as a negative in flag. symmetry level is positive */
if (connectedArc->symmetry_level == -depth)
{
RigNode *otherNode = RIG_otherNode(connectedArc, node);
float vec[3];
unit->arc = connectedArc;
/* project the node to node vector on the symmetry plane */
VecSubf(unit->n, otherNode->p, node->p);
Projf(vec, unit->n, axis);
VecSubf(unit->n, unit->n, vec);
Normalize(unit->n);
unit++;
}
}
/* sort ring */
for (i = 0; i < count - 1; i++)
{
float minAngle = 3; /* arbitrary high value, higher than 2, at least */
int minIndex = -1;
int j;
for (j = i + 1; j < count; j++)
{
float angle = Inpf(ring[i].n, ring[j].n);
/* map negative values to 1..2 */
if (angle < 0)
{
angle = 1 - angle;
}
if (angle < minAngle)
{
minIndex = j;
minAngle = angle;
}
}
/* swap if needed */
if (minIndex != i + 1)
{
RadialArc tmp;
tmp = ring[i + 1];
ring[i + 1] = ring[minIndex];
ring[minIndex] = tmp;
}
}
for (i = 0; i < count && symmetric; i++)
{
RigNode *node1, *node2;
float tangent[3];
float normal[3];
float p[3];
int j = (i + 1) % count; /* next arc in the circular list */
VecAddf(tangent, ring[i].n, ring[j].n);
Crossf(normal, tangent, axis);
node1 = RIG_otherNode(ring[i].arc, node);
node2 = RIG_otherNode(ring[j].arc, node);
VECCOPY(p, node2->p);
mirrorAlongAxis(p, node->p, normal);
/* check if it's within limit before continuing */
if (VecLenf(node1->p, p) > limit)
{
symmetric = 0;
}
}
if (symmetric)
{
/* mark node as symmetric physically */
VECCOPY(node->symmetry_axis, axis);
node->symmetry_flag |= SYM_PHYSICAL;
node->symmetry_flag |= SYM_RADIAL;
}
MEM_freeN(ring);
}
static void setSideAxialSymmetry(RigNode *root_node, RigNode *end_node, RigArc *arc)
{
float vec[3];
VecSubf(vec, end_node->p, root_node->p);
if (Inpf(vec, root_node->symmetry_axis) < 0)
{
arc->symmetry_flag |= SYM_SIDE_NEGATIVE;
}
else
{
arc->symmetry_flag |= SYM_SIDE_POSITIVE;
}
}
void RIG_markAxialSymmetry(RigNode *node, int depth, float axis[3])
{
RigArc *arc1 = NULL;
RigArc *arc2 = NULL;
RigNode *node1 = NULL, *node2 = NULL;
float limit = G.scene->toolsettings->skgen_symmetry_limit;
float nor[3], vec[3], p[3];
int i;
/* mark topological symmetry */
node->symmetry_flag |= SYM_TOPOLOGICAL;
for (i = 0; node->arcs[i] != NULL; i++)
{
RigArc *connectedArc = node->arcs[i];
/* depth is store as a negative in flag. symmetry level is positive */
if (connectedArc->symmetry_level == -depth)
{
if (arc1 == NULL)
{
arc1 = connectedArc;
node1 = RIG_otherNode(arc1, node);
}
else
{
arc2 = connectedArc;
node2 = RIG_otherNode(arc2, node);
break; /* Can stop now, the two arcs have been found */
}
}
}
/* shouldn't happen, but just to be sure */
if (node1 == NULL || node2 == NULL)
{
return;
}
VecSubf(vec, node1->p, node->p);
Normalize(vec);
VecSubf(p, node->p, node2->p);
Normalize(p);
VecAddf(p, p, vec);
Crossf(vec, p, axis);
Crossf(nor, vec, axis);
/* mirror node2 along axis */
VECCOPY(p, node2->p);
mirrorAlongAxis(p, node->p, nor);
/* check if it's within limit before continuing */
if (VecLenf(node1->p, p) <= limit)
{
/* mark node as symmetric physically */
VECCOPY(node->symmetry_axis, nor);
node->symmetry_flag |= SYM_PHYSICAL;
node->symmetry_flag |= SYM_AXIAL;
/* set side on arcs */
setSideAxialSymmetry(node, node1, arc1);
setSideAxialSymmetry(node, node2, arc2);
printf("flag: %i <-> %i\n", arc1->symmetry_flag, arc2->symmetry_flag);
}
else
{
printf("NOT SYMMETRIC!\n");
printf("%f <= %f\n", VecLenf(node1->p, p), limit);
printvecf("axis", nor);
}
}
void RIG_markdownSecondarySymmetry(RigNode *node, int depth, int level)
{
float axis[3] = {0, 0, 0};
int count = 0;
int i;
/* count the number of branches in this symmetry group
* and determinte the axis of symmetry
* */
for (i = 0; node->arcs[i] != NULL; i++)
{
RigArc *connectedArc = node->arcs[i];
/* depth is store as a negative in flag. symmetry level is positive */
if (connectedArc->symmetry_level == -depth)
{
count++;
}
/* If arc is on the axis */
else if (connectedArc->symmetry_level == level)
{
VecAddf(axis, axis, connectedArc->head->p);
VecSubf(axis, axis, connectedArc->tail->p);
}
}
Normalize(axis);
/* Split between axial and radial symmetry */
if (count == 2)
{
RIG_markAxialSymmetry(node, depth, axis);
}
else
{
RIG_markRadialSymmetry(node, depth, axis);
}
/* markdown secondary symetries */
for (i = 0; node->arcs[i] != NULL; i++)
{
RigArc *connectedArc = node->arcs[i];
if (connectedArc->symmetry_level == -depth)
{
/* markdown symmetry for branches corresponding to the depth */
RIG_markdownSymmetryArc(connectedArc, node, level + 1);
}
}
}
void RIG_markdownSymmetryArc(RigArc *arc, RigNode *node, int level)
{
int i;
arc->symmetry_level = level;
node = RIG_otherNode(arc, node);
for (i = 0; node->arcs[i] != NULL; i++)
{
RigArc *connectedArc = node->arcs[i];
if (connectedArc != arc)
{
RigNode *connectedNode = RIG_otherNode(connectedArc, node);
/* symmetry level is positive value, negative values is subtree depth */
connectedArc->symmetry_level = -RIG_subtreeDepth(connectedNode, connectedArc);
}
}
arc = NULL;
for (i = 0; node->arcs[i] != NULL; i++)
{
int issymmetryAxis = 0;
RigArc *connectedArc = node->arcs[i];
/* only arcs not already marked as symetric */
if (connectedArc->symmetry_level < 0)
{
int j;
/* true by default */
issymmetryAxis = 1;
for (j = 0; node->arcs[j] != NULL && issymmetryAxis == 1; j++)
{
RigArc *otherArc = node->arcs[j];
/* different arc, same depth */
if (otherArc != connectedArc && otherArc->symmetry_level == connectedArc->symmetry_level)
{
/* not on the symmetry axis */
issymmetryAxis = 0;
}
}
}
/* arc could be on the symmetry axis */
if (issymmetryAxis == 1)
{
/* no arc as been marked previously, keep this one */
if (arc == NULL)
{
arc = connectedArc;
}
else
{
/* there can't be more than one symmetry arc */
arc = NULL;
break;
}
}
}
/* go down the arc continuing the symmetry axis */
if (arc)
{
RIG_markdownSymmetryArc(arc, node, level);
}
/* secondary symmetry */
for (i = 0; node->arcs[i] != NULL; i++)
{
RigArc *connectedArc = node->arcs[i];
/* only arcs not already marked as symetric and is not the next arc on the symmetry axis */
if (connectedArc->symmetry_level < 0)
{
/* subtree depth is store as a negative value in the symmetry */
RIG_markdownSecondarySymmetry(node, -connectedArc->symmetry_level, level);
}
}
}
void RIG_markdownSymmetry(RigGraph *rg)
{
RigNode *node;
RigArc *arc;
/* mark down all arcs as non-symetric */
RIG_flagArcs(rg, 0);
/* mark down all nodes as not on the symmetry axis */
RIG_flagNodes(rg, 0);
if (rg->head)
{
node = rg->head;
}
else
{
/* !TODO! DO SOMETHING SMART HERE */
return;
}
/* only work on acyclic graphs and if only one arc is incident on the first node */
if (RIG_countConnectedArcs(rg, node) == 1)
{
arc = node->arcs[0];
RIG_markdownSymmetryArc(arc, node, 1);
/* mark down non-symetric arcs */
for (arc = rg->arcs.first; arc; arc = arc->next)
{
if (arc->symmetry_level < 0)
{
arc->symmetry_level = 0;
}
else
{
/* mark down nodes with the lowest level symmetry axis */
if (arc->head->symmetry_level == 0 || arc->head->symmetry_level > arc->symmetry_level)
{
arc->head->symmetry_level = arc->symmetry_level;
}
if (arc->tail->symmetry_level == 0 || arc->tail->symmetry_level > arc->symmetry_level)
{
arc->tail->symmetry_level = arc->symmetry_level;
}
}
}
}
}
/*******************************************************************************************************/
static void RIG_arcFromBoneChain(RigGraph *rg, ListBase *list, EditBone *root_bone, RigNode *starting_node)
@@ -942,7 +363,7 @@ static void RIG_arcFromBoneChain(RigGraph *rg, ListBase *list, EditBone *root_bo
if (contain_head)
{
rg->head = arc->tail;
rg->head = (RigNode*)arc->tail;
}
}
@@ -955,7 +376,7 @@ static void RIG_findHead(RigGraph *rg)
{
RigArc *arc = rg->arcs.first;
rg->head = arc->head;
rg->head = (RigNode*)arc->head;
}
}
}
@@ -997,7 +418,7 @@ static void RIG_printArc(RigArc *arc)
printf("\n");
RIG_printNode(arc->head, "head");
RIG_printNode((RigNode*)arc->head, "head");
for (edge = arc->edges.first; edge; edge = edge->next)
{
@@ -1009,7 +430,7 @@ static void RIG_printArc(RigArc *arc)
}
printf("symmetry level: %i\n", arc->symmetry_level);
RIG_printNode(arc->tail, "tail");
RIG_printNode((RigNode*)arc->tail, "tail");
}
void RIG_printGraph(RigGraph *rg)
@@ -1048,9 +469,9 @@ static RigGraph *armatureToGraph(ListBase *list)
}
}
RIG_removeDoubleNodes(rg, 0);
BLI_removeDoubleNodes((BGraph*)rg, 0);
RIG_buildAdjacencyList(rg);
BLI_buildAdjacencyList((BGraph*)rg);
RIG_findHead(rg);
@@ -1151,6 +572,8 @@ static void retargetArctoArcAggresive(RigArc *iarc)
int first_pass = 1;
int must_move = nb_joints - 1;
int i;
printf("aggressive\n");
positions = MEM_callocN(sizeof(int) * nb_joints, "Aggresive positions");
best_positions = MEM_callocN(sizeof(int) * nb_joints, "Best Aggresive positions");
@@ -1161,13 +584,13 @@ static void retargetArctoArcAggresive(RigArc *iarc)
if (earc->symmetry_level == 1 && iarc->symmetry_level == 1)
{
symmetry_axis = 1;
node_start = earc->v2;
node_end = earc->v1;
node_start = earc->tail;
node_end = earc->head;
}
else
{
node_start = earc->v1;
node_end = earc->v2;
node_start = earc->head;
node_end = earc->tail;
}
/* init with first values */
@@ -1375,13 +798,13 @@ static void retargetArctoArcLength(RigArc *iarc)
if (earc->symmetry_level == 1 && iarc->symmetry_level == 1)
{
symmetry_axis = 1;
node_start = earc->v2;
node_end = earc->v1;
node_start = (ReebNode*)earc->tail;
node_end = (ReebNode*)earc->head;
}
else
{
node_start = earc->v1;
node_end = earc->v2;
node_start = (ReebNode*)earc->head;
node_end = (ReebNode*)earc->tail;
}
initArcIterator(&iter, earc, node_start);
@@ -1499,14 +922,14 @@ static void retargetArctoArc(RigArc *iarc)
/* symmetry axis */
if (earc->symmetry_level == 1 && iarc->symmetry_level == 1)
{
VECCOPY(bone->head, earc->v2->p);
VECCOPY(bone->tail, earc->v1->p);
VECCOPY(bone->head, earc->tail->p);
VECCOPY(bone->tail, earc->head->p);
}
/* or not */
else
{
VECCOPY(bone->head, earc->v1->p);
VECCOPY(bone->tail, earc->v2->p);
VECCOPY(bone->head, earc->head->p);
VECCOPY(bone->tail, earc->tail->p);
}
}
else
@@ -1535,8 +958,9 @@ static void findCorrespondingArc(RigArc *start_arc, RigNode *start_node, RigArc
next_iarc->link = NULL;
for(i = 0, next_earc = enode->arcs[i]; next_earc; i++, next_earc = enode->arcs[i])
for(i = 0; i < enode->degree; i++)
{
next_earc = (ReebArc*)enode->arcs[i];
if (next_earc->flag == 0 && /* not already taken */
next_earc->symmetry_flag == symmetry_flag &&
next_earc->symmetry_level == symmetry_level)
@@ -1561,8 +985,9 @@ static void findCorrespondingArc(RigArc *start_arc, RigNode *start_node, RigArc
printf("flag %i -- symmetry level %i -- symmetry flag %i\n", 0, symmetry_level, symmetry_flag);
printf("CANDIDATES\n");
for(i = 0, next_earc = enode->arcs[i]; next_earc; i++, next_earc = enode->arcs[i])
for(i = 0; i < enode->degree; i++)
{
next_earc = (ReebArc*)enode->arcs[i];
printf("flag %i -- symmetry level %i -- symmetry flag %i\n", next_earc->flag, next_earc->symmetry_level, next_earc->symmetry_flag);
}
}
@@ -1574,18 +999,19 @@ static void retargetSubgraph(RigGraph *rigg, RigArc *start_arc, RigNode *start_n
ReebArc *earc = start_arc->link;
RigNode *inode = start_node;
ReebNode *enode = start_node->link;
RigArc *next_iarc;
int i;
retargetArctoArc(iarc);
enode = OTHER_NODE(earc, enode);
inode = RIG_otherNode(iarc, inode);
enode = (ReebNode*)BLI_otherNode((BArc*)earc, (BNode*)enode);
inode = (RigNode*)BLI_otherNode((BArc*)iarc, (BNode*)inode);
inode->link = enode;
for(i = 0, next_iarc = inode->arcs[i]; next_iarc; i++, next_iarc = inode->arcs[i])
for(i = 0; i < inode->degree; i++)
{
RigArc *next_iarc = (RigArc*)inode->arcs[i];
/* no back tracking */
if (next_iarc != iarc)
{
@@ -1613,12 +1039,12 @@ static void retargetGraphs(RigGraph *rigg)
}
earc = reebg->arcs.first;
iarc = rigg->head->arcs[0];
iarc = (RigArc*)rigg->head->arcs[0];
iarc->link = earc;
earc->flag = 1;
enode = earc->v1;
enode = earc->head;
inode = iarc->tail;
inode->link = enode;
@@ -1634,7 +1060,7 @@ void BIF_retargetArmature()
reebg = BIF_ReebGraphFromEditMesh();
markdownSymmetry(reebg);
BLI_markdownSymmetry((BGraph*)reebg, reebg->nodes.first, G.scene->toolsettings->skgen_symmetry_limit);
printf("Reeb Graph created\n");
@@ -1660,7 +1086,7 @@ void BIF_retargetArmature()
printf("Armature graph created\n");
RIG_markdownSymmetry(rigg);
BLI_markdownSymmetry((BGraph*)rigg, (BNode*)rigg->head, G.scene->toolsettings->skgen_symmetry_limit);
RIG_printGraph(rigg);
@@ -1675,7 +1101,7 @@ void BIF_retargetArmature()
BLI_freelistN(&list);
RIG_freeRigGraph(rigg);
RIG_freeRigGraph((BGraph*)rigg);
}
}
}

40
source/blender/src/editarmature.c
View File

@@ -4324,7 +4324,7 @@ float arcLengthRatio(ReebArc *arc)
float embedLength = 0.0f;
int i;
arcLength = VecLenf(arc->v1->p, arc->v2->p);
arcLength = VecLenf(arc->head->p, arc->tail->p);
if (arc->bcount > 0)
{
@@ -4334,8 +4334,8 @@ float arcLengthRatio(ReebArc *arc)
embedLength += VecLenf(arc->buckets[i - 1].p, arc->buckets[i].p);
}
/* Add head and tail -> embedding vectors */
embedLength += VecLenf(arc->v1->p, arc->buckets[0].p);
embedLength += VecLenf(arc->v2->p, arc->buckets[arc->bcount - 1].p);
embedLength += VecLenf(arc->head->p, arc->buckets[0].p);
embedLength += VecLenf(arc->tail->p, arc->buckets[arc->bcount - 1].p);
}
else
{
@@ -4483,7 +4483,7 @@ void generateSkeletonFromReebGraph(ReebGraph *rg)
arcBoneMap = BLI_ghash_new(BLI_ghashutil_ptrhash, BLI_ghashutil_ptrcmp);
markdownSymmetry(rg);
BLI_markdownSymmetry((BGraph*)rg, rg->nodes.first, G.scene->toolsettings->skgen_symmetry_limit);
for (arc = rg->arcs.first; arc; arc = arc->next)
{
@@ -4501,33 +4501,33 @@ void generateSkeletonFromReebGraph(ReebGraph *rg)
*/
/* if arc is a symmetry axis, internal bones go up the tree */
if (arc->symmetry_level == 1 && arc->v2->degree != 1)
if (arc->symmetry_level == 1 && arc->tail->degree != 1)
{
head = arc->v2;
tail = arc->v1;
head = arc->tail;
tail = arc->head;
arc->flag = -1; /* mark arc direction */
}
/* Bones point AWAY from the symmetry axis */
else if (arc->v1->symmetry_level == 1)
else if (arc->head->symmetry_level == 1)
{
head = arc->v1;
tail = arc->v2;
head = arc->head;
tail = arc->tail;
arc->flag = 1; /* mark arc direction */
}
else if (arc->v2->symmetry_level == 1)
else if (arc->tail->symmetry_level == 1)
{
head = arc->v2;
tail = arc->v1;
head = arc->tail;
tail = arc->head;
arc->flag = -1; /* mark arc direction */
}
/* otherwise, always go from low weight to high weight */
else
{
head = arc->v1;
tail = arc->v2;
head = arc->head;
tail = arc->tail;
arc->flag = 1; /* mark arc direction */
}
@@ -4571,12 +4571,12 @@ void generateSkeletonFromReebGraph(ReebGraph *rg)
ReebArc *incomingArc = NULL;
int i;
for (i = 0; node->arcs[i] != NULL; i++)
for (i = 0; i < node->degree; i++)
{
arc = node->arcs[i];
arc = (ReebArc*)node->arcs[i];
/* if arc is incoming into the node */
if ((arc->v1 == node && arc->flag == -1) || (arc->v2 == node && arc->flag == 1))
if ((arc->head == node && arc->flag == -1) || (arc->tail == node && arc->flag == 1))
{
if (incomingArc == NULL)
{
@@ -4597,12 +4597,12 @@ void generateSkeletonFromReebGraph(ReebGraph *rg)
EditBone *parentBone = BLI_ghash_lookup(arcBoneMap, incomingArc);
/* Look for outgoing arcs and parent their bones */
for (i = 0; node->arcs[i] != NULL; i++)
for (i = 0; i < node->degree; i++)
{
arc = node->arcs[i];
/* if arc is outgoing from the node */
if ((arc->v1 == node && arc->flag == 1) || (arc->v2 == node && arc->flag == -1))
if ((arc->head == node && arc->flag == 1) || (arc->tail == node && arc->flag == -1))
{
EditBone *childBone = BLI_ghash_lookup(arcBoneMap, arc);

1169
source/blender/src/reeb.c
View File

File diff suppressed because it is too large Load Diff