archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

Multi-Objects: MESH_OT_offset_edge_loops

Browse Source 
Changes from reviewer (Dalai Felinto):
* Code style (replace tabs with spaces).
* Return OPERATOR_CANCELLED if no a single object get through.

Maniphest Tasks: T54643
https://developer.blender.org/D3392
This commit is contained in:
Nick Milios
2018-08-31 17:07:42 -03:00
committed by Dalai Felinto
parent 41759e74de
commit efd843b51c
1 changed files with 38 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
source/blender/editors/mesh/editmesh_tools.c
View File

@@ -6466,11 +6466,21 @@ void MESH_OT_wireframe(wmOperatorType *ot)
static int edbm_offset_edgeloop_exec(bContext *C, wmOperator *op) static int edbm_offset_edgeloop_exec(bContext *C, wmOperator *op)
{ {
Object *obedit = CTX_data_edit_object(C);
BMEditMesh *em = BKE_editmesh_from_object(obedit);
BMOperator bmop;
const bool use_cap_endpoint = RNA_boolean_get(op->ptr, "use_cap_endpoint"); const bool use_cap_endpoint = RNA_boolean_get(op->ptr, "use_cap_endpoint");
int ret = OPERATOR_CANCELLED;
ViewLayer *view_layer = CTX_data_view_layer(C);
uint objects_len = 0;
Object **objects = BKE_view_layer_array_from_objects_in_edit_mode_unique_data(view_layer, &objects_len);
for (uint ob_index = 0; ob_index < objects_len; ob_index++) {
Object *obedit = objects[ob_index];
BMEditMesh *em = BKE_editmesh_from_object(obedit);
if (em->bm->totedgesel == 0) {
continue;
}
BMOperator bmop;
EDBM_op_init( EDBM_op_init(
em, &bmop, op, em, &bmop, op,
"offset_edgeloops edges=%he use_cap_endpoint=%b", "offset_edgeloops edges=%he use_cap_endpoint=%b",
@@ -6491,13 +6501,16 @@ static int edbm_offset_edgeloop_exec(bContext *C, wmOperator *op)
BMO_slot_buffer_hflag_enable(em->bm, bmop.slots_out, "edges.out", BM_EDGE, BM_ELEM_SELECT, true); BMO_slot_buffer_hflag_enable(em->bm, bmop.slots_out, "edges.out", BM_EDGE, BM_ELEM_SELECT, true);
if (!EDBM_op_finish(em, &bmop, op, true)) { if (!EDBM_op_finish(em, &bmop, op, true)) {
return OPERATOR_CANCELLED; continue;
} }
else { else {
EDBM_update_generic(em, true, true); EDBM_update_generic(em, true, true);
return OPERATOR_FINISHED; ret = OPERATOR_FINISHED;
} }
} }
MEM_freeN(objects);
return ret;
}
void MESH_OT_offset_edge_loops(wmOperatorType *ot) void MESH_OT_offset_edge_loops(wmOperatorType *ot)
{ {