d1eefc4215
Spelling: Then Versus Than
...
Corrects incorrect usages of the words 'then' and 'than'.
Differential Revision: https://developer.blender.org/D9246
Reviewed by Campbell Barton
2020-10-19 08:43:08 -07:00
20869065b8
Cleanup: BMesh, Clang-Tidy else-after-return fixes
...
This addresses warnings from Clang-Tidy's `readability-else-after-return`
rule in the `source/blender/bmesh` module.
No functional changes.
2020-07-03 14:48:37 +02:00
2d1cce8331
Cleanup: make format after SortedIncludes change
2020-03-19 09:33:58 +01:00
ee192a35e8
Cleanup: comments (long lines) in bmesh
2019-04-29 22:06:26 +10:00
e12c08e8d1
ClangFormat: apply to source, most of intern
...
Apply clang format as proposed in T53211.
For details on usage and instructions for migrating branches
without conflicts, see:
https://wiki.blender.org/wiki/Tools/ClangFormat
2019-04-17 06:21:24 +02:00
de13d0a80c
doxygen: add newline after \file
...
While \file doesn't need an argument, it can't have another doxy
command after it.
2019-02-18 08:22:12 +11:00
eef4077f18
Cleanup: remove redundant doxygen \file argument
...
Move \ingroup onto same line to be more compact and
make it clear the file is in the group.
2019-02-06 15:45:22 +11:00
65ec7ec524
Cleanup: remove redundant, invalid info from headers
...
BF-admins agree to remove header information that isn't useful,
to reduce noise.
- BEGIN/END license blocks
Developers should add non license comments as separate comment blocks.
No need for separator text.
- Contributors
This is often invalid, outdated or misleading
especially when splitting files.
It's more useful to git-blame to find out who has developed the code.
See P901 for script to perform these edits.
2019-02-02 01:36:28 +11:00
1e4aab36c2
Cleanup: remove redundant BKE/BLI/BIF headers
2019-01-26 21:20:25 +11:00
900c562b71
Cleanup: rename fast-heap -> heap-simple
...
In general prefer API names don't start with adjectives
since it causes grouping of unrelated API's for completion.
2018-11-06 13:06:49 +11:00
d805a4a5ef
Cleanup: move fast heap into own source & header
2018-11-06 12:52:34 +11:00
fee6ab18e7
BLI_heap: implement a limited but faster version of heap.
...
If the user only needs insertion and removal from top, there is
no need to allocate and manage separate HeapNode objects: the
data can be stored directly in the main tree array.
This measured a 24% FPS increase on a ~50% heap-heavy workload.
Reviewers: brecht
Differential Revision: https://developer.blender.org/D3898
2018-11-05 20:49:17 +03:00
ccdacf1c9b
Cleanup: use '_len' instead of '_size' w/ BLI API
...
- When returning the number of items in a collection use BLI_*_len()
- Keep _size() for size in bytes.
- Keep _count() for data structures that don't store length
(hint this isn't a simple getter).
See P611 to apply instead of manually resolving conflicts.
2018-02-15 23:39:08 +11:00
e428ea3e00
Cleanup: indentation
2018-01-16 11:40:43 +11:00
1d966ca7a1
Math Lib: add angle_on_axis_v3v3_v3
...
Use for calculating the angle between 2 directions on an axis.
Also signed version and normalized plane projection,
use when input is normalized.
2017-06-16 01:27:58 +10:00
c5d7602925
Fix T49471: Vertex Connect randomly broken.
...
Not sure where this comes from, but code was converting BMEdge* to BMVert* to check oflags,
i.e. not accessing correct memory.
Regression, to be backported to 2.78a.
2016-09-28 16:58:11 +02:00
3948f65686
Cleanup: style, spelling
2016-07-19 10:27:33 +10:00
8343518272
Cleanup: comment blocks
2016-07-15 02:39:45 +10:00
0a026033ae
BMesh: make toolflags optional
...
Saves 8 bytes per vert/edge/face.
Gives overall ~20-25% memory saving for dyntopo sculpting
and modifiers that use BMesh.
2016-07-01 19:29:22 +10:00
a3530b35bd
Fix T46784: Connect vertices (follow up)
...
Another fix for a slightly different case from the original report, to give better orientation.
Vertex normals influence on the orientation is now scaled by the alignment with the cut direction.
Also use face normal instead of loop normal which can be unreliable when the corners edges are co-linear.
2015-11-17 14:36:22 +11:00
e38a80d5f6
Fix T46784: Connect vertices uses odd orientation
...
Use connected faces to calculate the paths orientation
when normals are aligned with the direction.
2015-11-16 15:21:22 +11:00
93d1acfb5c
correct ifdef
2015-08-02 23:36:42 +10:00
e31f8e756f
Fix T45582: Connect vertex hangs
...
With multiple branches it was possible the search could run for a long time,
especially when there was no possible path to the target.
Now use a heap to keep track of the best path and finish immediately once its reached.
2015-08-01 19:04:09 +10:00
0e9051fbfe
BMesh connect pair, fallback to identity matrix
...
For overlapping vertices, a matrix for the operation can't be calculated.
2015-08-01 15:11:45 +10:00
ea5f9fee8d
Cleanup: function arg wrapping
2015-05-05 16:34:38 +10:00
831a111353
Fix T43792: Connect faces fails with ngons
...
Complex ngons that intersected the path multiple times would fail to connect.
Now find closest intersections in both directions.
2015-02-25 00:08:39 +11:00
dec523da87
Fix for regression in bmesh connect-pair
...
T42563 fix wasn't right, fortunately this doesn't fail in most cases.
2015-01-10 12:32:14 +11:00
46e2d5ee41
Cleanup: typo
2014-11-21 14:16:35 +01:00
7d040d2a08
Cleanup: use BLI_listbase_*** prefix for count,sort,sort_r
2014-11-16 13:57:58 +01:00
3ead24d235
Fix T4256: Connect tool hangs
2014-11-10 18:38:46 +01:00
b7174c9320
Fix connect-vertices failing for concave ngons
...
Also add:
- generic callback for bmesh elements.
- ability to pass an existing array to a bmesh operator.
2014-11-02 00:09:14 +01:00
d658ea1b20
Cleanup: style
2014-11-01 23:32:02 +01:00
6b3ec0c515
Fix editmesh-connect with hidden geometry
...
- ignore hidden faces & verts
- when cutting a pair, select edges co-linear to the cut.
Also support creating a buffer from hidden elem's even if BMO_FLAG_RESPECT_HIDE is enabled.
(if the hflag used includes BM_ELEM_HIDDEN).
2014-09-02 14:35:56 +10:00
c1ec73f522
Fix T41631: Connect acts on unrelated vert
2014-08-30 00:13:56 +10:00
00b29156e0
Defines: replace ELEM3-16 with ELEM(...), that can take varargs
2014-07-20 01:33:40 +10:00
412826a504
Mempool: delay allocating an initial chunk, its not always used
2014-04-08 12:58:56 +10:00
af59ee340f
Mempool: remove BLI_MEMPOOL_SYSMALLOC, MEM_* allocs are more efficient now
2014-04-05 12:14:05 +11:00
5256a5d66c
BMesh: let vert-connect make degenerate faces when only 2 verts selected
2014-03-27 12:52:34 +11:00
b3afbcab8f
ListBase API: add utility api funcs for clearing and checking empty
2014-02-08 06:24:05 +11:00
76e989d7b1
function renaming for own recently added BLI_math functions, suggested by Brecht.
2013-07-30 10:58:36 +00:00
c754eaa0f9
add inline functions getting a single axis from mul_m3_v3()
2013-07-28 19:46:33 +00:00
b7396654e1
fix for bad NULL check in bmo_connect_pair, also remove duplicate checks in if statements and redundant initialization vars.
2013-07-13 16:25:47 +00:00
3a1082b359
tweak comparisons for connect pair in rare case the value == CONNECT_EPS.
2013-06-23 15:00:12 +00:00
dc12dd23f6
fix for connect_pair cutting across triangle verts from edges.
2013-06-23 09:50:10 +00:00
e4bb913510
Extend existing editmesh connect tool so it can connect across multiple faces.
...
only use this when 2 vertices are selected, otherwise use the same behavior as before.
This works a little like a fast knife tool, but it only cuts straight lines and doesnt depend on the view-port.
Examples:
- http://www.graphicall.org/ftp/ideasman42/mesh_connect_pair.png
- http://www.graphicall.org/ftp/ideasman42/mesh_connect_pair_curve.png
2013-06-22 17:25:02 +00:00
