f4bb0a7412
code cleanup: remove duplicate calls to 'BMW_current_state'
2013-05-13 16:35:28 +00:00
34f9932418
simple optimization, replace BM_face_other_edge_loop() with BM_loop_other_edge_loop() in situations where the loop is known this avoids a lookup.
2013-04-19 01:02:58 +00:00
347e2b6cb0
code cleanup: make bmesh var names more consistent
2013-03-09 17:12:24 +00:00
89bda7899d
style cleanup & some spelling
2013-02-03 10:28:28 +00:00
b27854bd47
use booleans for bmesh api.
2013-01-14 16:42:43 +00:00
36f79eab20
fix [ #33784 ] Select Linked All + Seams fails to select seam bounded area
...
was incorrectly flushing vertex selection.
2013-01-08 17:30:06 +00:00
eb69d1c1ae
style cleanup: also quiet harmless compiler warning.
2012-10-29 15:43:54 +00:00
ec67334e25
A few more BMesh errors messages translated, and "automated" translation for modifers too!
2012-10-27 11:12:09 +00:00
8b7f410f95
Code cleanup - silence some "uninitialised" warnings in BMesh code
...
There are still a lot more in bmo_bevel.c and bmo_extrude.c, but those don't
seem that easy to fix.
2012-10-08 06:28:06 +00:00
74c9c24d27
style cleanyp
2012-06-23 23:22:19 +00:00
ed33320e3f
Code cleanup: simplify standard GHash creation.
...
Added four new functions as shortcuts to creating GHashes that use the
standard ptr/str/int/pair hash and compare functions.
GHash *BLI_ghash_ptr_new(const char *info);
GHash *BLI_ghash_str_new(const char *info);
GHash *BLI_ghash_int_new(const char *info);
GHash *BLI_ghash_pair_new(const char *info);
Replaced almost all occurrences of BLI_ghash_new() with one of the
above functions.
2012-05-16 00:51:36 +00:00
e701f9b670
style cleanup: whitespace / commas
2012-04-29 15:47:02 +00:00
b340f930ec
style cleanup: changes to brace placement / newlines - for/while/if/switch
2012-04-28 06:31:57 +00:00
475ecbb0ce
remove BM_ITER, BM_ITER_INDEX macros, use ELEM or MESH variants only (the maceros had unused args in both cases).
2012-04-19 13:47:58 +00:00
75b869e428
style cleanup: BM_ITER / BM_ITER_INDEX / BMO_ITER
2012-04-19 11:44:12 +00:00
1f01d62d15
more replacement for BM_edge_face_count() use.
2012-04-18 06:57:28 +00:00
b3bca9d252
Minor code cleanup: Don't reference previous BMwEdgeringWalker after BMW_state_remove. Its memory is freed on that call.
2012-04-12 12:11:21 +00:00
7004f929b9
Fix: loopcut didn't stop on hidden faces
2012-04-12 12:03:12 +00:00
b44ae0c387
Fix #30791 : BMEdge.is_manifold also returned true for edges with only one face
...
attached to it. A manifold edge should have exactly 2 faces attached to it,
sticking to the standard definition for "manifold".
2012-04-03 17:09:47 +00:00
28889a3500
fix [ #30732 ] bmesh: loop select continues through hidden sections.
2012-03-30 09:27:54 +00:00
0e972b6293
partial fix for [ #30732 ] bmesh: loop select continues through hidden sections.
...
loop cut and edge ring select still need to be fixed.
2012-03-30 08:43:47 +00:00
f87c5b3453
fix [ #30715 ] bmesh: select linked not ignoring hidden verts/edges/faces
...
add optional flag to ignore hidden elements.
also remove loop mask flag - since it wasnt used and vert/edge/face is enough.
2012-03-29 13:09:07 +00:00
81d8f17843
style cleanup: pep8, indentation
2012-03-24 07:36:32 +00:00
3c11379e26
code cleanup: move bmesh inline funcs to headers (avoids compiling the C files).
2012-03-24 01:24:58 +00:00
7044d80639
code cleanup: remove BMesh * args from query functions which don't need it
2012-03-22 07:53:11 +00:00
95f66f162c
Fix #30504 selecting self-intersecting face loop won't work correctly.
...
Added generic secondary hash to walker. In faceloop select it is used to remember if edge has been previously visited, in addition to the hash used for faces. This solves the case where walker stops if it finds an already added face.
2012-03-21 21:40:42 +00:00
ee1dc84239
Fix for crash on selecting loop in cases when some edges aren't connected to any faces.
2012-03-21 17:34:31 +00:00
be116242d4
style cleanup
2012-03-20 04:27:14 +00:00
4f19c1a995
spelling cleanup
2012-03-18 07:38:51 +00:00
a829a905da
fix hang when loop selecting an ngon. We need to check if edge currently walked on has already been added
2012-03-14 13:52:17 +00:00
01b3e9cc9f
loopwalker support for selecting the sides of ngons
...
see: wiki.blender.org/uploads/d/dc/BMesh_NGon_Loop_Select.png
2012-03-13 18:37:31 +00:00
b47e2ee907
code/style cleanup for loop walker which was is fairly confusing and hard to extend.
...
- only have one return at the end of the function.
- break up functionality more clearly between wire/face walk.
- remove unused struct member.
2012-03-13 17:13:44 +00:00
aedd4af57e
code cleanup/bugfix uninitialized values
...
- edgebisect bmesh operator used uninialized beauty field.
- BLI_join_dirfile could read from before the string bounds when passed an empty dir string.
- pransform could use an uninitialized projected coordinate (unlikely but possible)
- RNA_property_path_from_ID_check would compare against an uninitialized pointer when the path wasn't found.
also have bmesh walker use BM_edge_other_vert() utility function.
2012-03-12 06:53:47 +00:00
ac24d98e24
bmesh: edge loop select
...
add support for loop selecting boundry edges only - handy for loop selecting the side of an ngon.
2012-03-11 21:47:14 +00:00
33d8104716
Fix edge loop selection. Now boundary selection checks only for filled edges to determine when to stop and stops at vertices shared by only 2 edges.
2012-03-11 20:45:58 +00:00
17786b3b3e
building without python works again, cleanup bmesh include paths (cmake and scons).
2012-03-08 03:25:53 +00:00
7b7214c722
code cleanup - give edge split more helpful var names and replace edgetag macros with static functions.
2012-03-06 17:23:26 +00:00
a0ab2eefb9
* rename BM_face_other_loop --> BM_face_other_edge_loop
...
* optimize BM_face_other_edge_loop to do about half as many iterations for quad heavy meshes, with ngons the gain is much more since searching around the entire ngon when the edge already stores its loop is silly.
... also nicer in cases where edge has no face users it avoids a loop on all face corners.
2012-03-04 16:36:31 +00:00
76e9f91d1c
switch arg order for BM_face_other_* funcs (make face come first), and add nice ascii art for BM_face_other_vert_loop since this stuff is hard to grasp as text.
2012-03-04 16:01:02 +00:00
8c7ea2f746
#ifdef out ngon edge-ring loop support, from r44561, this is a nice feature but can too easily give bad results, perhaps being it back with some sanity checks.
2012-03-03 22:27:34 +00:00
21280a6386
Code Cleanup - naming consistancy for bmesh struct types
2012-03-02 12:44:34 +00:00
1f473a78b8
Code Cleanup: remove bmesh_radial_loop_next() function,
...
just access l->radial_next
2012-03-01 17:13:02 +00:00
216f74880e
style cleanup: bmesh - have continue on new line, also avoid unneeded loop in bmo_extrude_face_region_exec() in some cases.
2012-03-01 13:13:08 +00:00
ea13ec1699
Spelling Cleanup
2012-03-01 12:20:18 +00:00
af0a469307
fix [ #29135 ] NGons dont work with loop cut
...
patch by Andrew Wiggin
2012-02-29 17:23:41 +00:00
d1d11bbe9b
more header re-arranging.
...
Some function comments were in headers, some in the C files, some in both.
Moved function comments from headers into the C files.
2012-02-28 18:28:30 +00:00
e17bf02c2d
Code Cleanup:
...
* made bmesh_structure.h function names more consistant.
* remove unused code in bmesh_structure.c
* removed 'Edge Flip' operator (missing from bmesh but looked into trunk feature and dont think its worth keeping).
* tagged some BMESH_TODO's
2012-02-27 13:47:53 +00:00
98aececc8e
bmesh code cleanup
...
* change BMO_elem_flag_* defines to inline functions.
* BMO_slot_map_insert() is too big for an inline function - un-inline it.
* remove redundant casts.
2012-02-25 20:58:03 +00:00
afc56a0b10
copying bmesh dir on its own from bmesh branch
2012-02-19 18:31:04 +00:00
