archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Pholio - finish off making public (ie not logged in) views work

Browse Source 
Summary: Fixes T2652. Did some testing post T2691 to see if I could close this and noted an error in the JS if you view the page not logged in. This fixes that error. Everything else I can think of seems to work...? :D

Test Plan: played around with a mock not logged in and got sensible interactions and no errors

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2652

Differential Revision: https://secure.phabricator.com/D6438
This commit is contained in:
Bob Trahan
2013-07-12 12:07:52 -07:00
parent 9838251515
commit 014fba2831
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js
View File

@@ -631,7 +631,9 @@ JX.behavior('pholio-mock-view', function(config) {
} }
load_inline_comments(); load_inline_comments();
JX.DOM.invoke(JX.$(config.commentFormID), 'shouldRefresh'); if (config.loggedIn) {
JX.DOM.invoke(JX.$(config.commentFormID), 'shouldRefresh');
}
JX.Stratcom.listen('resize', null, redraw_image); JX.Stratcom.listen('resize', null, redraw_image);
redraw_image(); redraw_image();