archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix an issue with rendering some commit hovercards

Browse Source 
Summary: This logic wasn't quite right.

Test Plan: Hovered over a recognized commit, got a valid hovercard

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D14925
This commit is contained in:
epriestley
2016-01-02 05:09:10 -08:00
parent 2328e739b7
commit 1b4f5e38ce
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/applications/diffusion/engineextension/DiffusionHovercardEngineExtension.php
View File

@@ -28,7 +28,7 @@ final class DiffusionHovercardEngineExtension
$author_phid = $commit->getAuthorPHID(); $author_phid = $commit->getAuthorPHID();
if ($author_phid) { if ($author_phid) {
$author = $viewer->loadHandle($author)->renderLink(); $author = $viewer->renderHandle($author_phid);
} else { } else {
$commit_data = $commit->loadCommitData(); $commit_data = $commit->loadCommitData();
$author = phutil_tag('em', array(), $commit_data->getAuthorName()); $author = phutil_tag('em', array(), $commit_data->getAuthorName());