Rename "transactionpro" table to "transaction"

Summary: Ref T2217. Cleans up the table names. Moves old data to `maniphest_transaction_legacy`. We'll drop that eventually once it's more clear that I didn't break the world.

Test Plan: Did reads/writes to/from these tables.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2217

Differential Revision: https://secure.phabricator.com/D7094

resources/sql/patches/20130923.mrename.sql

@@ -0,0 +1,5 @@
+ALTER TABLE {$NAMESPACE}_maniphest.maniphest_transaction
+  RENAME {$NAMESPACE}_maniphest.maniphest_transaction_legacy;
+
+ALTER TABLE {$NAMESPACE}_maniphest.maniphest_transactionpro
+  RENAME {$NAMESPACE}_maniphest.maniphest_transaction;

src/applications/maniphest/storage/ManiphestTransaction.php

@@ -17,11 +17,6 @@ final class ManiphestTransaction
     return 'maniphest';
   }
 
-  public function getTableName() {
-    // TODO: Remove once the "pro" table gets renamed.
-    return 'maniphest_transactionpro';
-  }
-
   public function getApplicationTransactionType() {
     return ManiphestPHIDTypeTask::TYPECONST;
   }

src/applications/maniphest/storage/ManiphestTransactionComment.php

@@ -3,11 +3,6 @@
 final class ManiphestTransactionComment
   extends PhabricatorApplicationTransactionComment {
 
-  public function getTableName() {
-    // TODO: Remove once the "pro" stuff gets dropped.
-    return 'maniphest_transaction_comment';
-  }
-
   public function getApplicationTransactionObject() {
     return new ManiphestTransaction();
   }

src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php

@@ -1620,6 +1620,10 @@ final class PhabricatorBuiltinPatchList extends PhabricatorSQLPatchList {
         'type' => 'php',
         'name' => $this->getPatchPath('20130921.xmigratemaniphest.php'),
       ),
+      '20130923.mrename.sql' => array(
+        'type' => 'sql',
+        'name' => $this->getPatchPath('20130923.mrename.sql'),
+      ),
     );
   }
 }