archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix displaying non-image files.

Browse Source 
Summary: The Files application currently tries to render all browser-viewable files in an img tag, not taking into account if they're an image or not.

Test Plan: Looked at various image and non-image files.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4511
This commit is contained in:
Asher Baker
2013-01-18 06:19:32 -08:00
committed by epriestley
parent 656a6f9b55
commit 27e2198e11
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/applications/files/controller/PhabricatorFileInfoController.php
View File

@@ -136,7 +136,7 @@ final class PhabricatorFileInfoController extends PhabricatorFileController {
} }
} }
if ($file->isViewableInBrowser()) { if ($file->isViewableImage()) {
// TODO: Clean this up after Pholio (dark backgrounds, standardization, // TODO: Clean this up after Pholio (dark backgrounds, standardization,
// etc.) // etc.)