Fix T38210: phabricator file downloads not working for non-logged in users.

src/applications/files/controller/PhabricatorFileDataController.php

@@ -10,6 +10,10 @@ final class PhabricatorFileDataController extends PhabricatorFileController {
     $this->key  = $data['key'];
   }
 
+  public function shouldAllowPublic() {
+    return true;
+  }
+
   public function shouldRequireLogin() {
     return false;
   }

src/applications/files/controller/PhabricatorFileInfoController.php

@@ -4,6 +4,10 @@ final class PhabricatorFileInfoController extends PhabricatorFileController {
 
   private $phid;
 
+  public function shouldAllowPublic() {
+    return true;
+  }
+
   public function willProcessRequest(array $data) {
     $this->phid = $data['phid'];
   }

src/view/layout/PhabricatorActionView.php

@@ -40,7 +40,7 @@ final class PhabricatorActionView extends AphrontView {
    * viewing.
    */
   public function getHref() {
-    if ($this->workflow || $this->renderAsForm) {
+    if (($this->workflow || $this->renderAsForm) && !$this->download) {
       if (!$this->user || !$this->user->isLoggedIn()) {
         return id(new PhutilURI('/auth/start/'))
           ->setQueryParam('next', (string)$this->getObjectURI());