archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Reorder audit actions to match Differential

Browse Source 
Summary:
These trip me up every time because Differential has:

> Comment, Accept, Request Changes, Resign, Commandeer, Add Reviewers, Add Subscribers

while audits currently show:

> Comment, Add Subscribers, Add Auditors, Accept, Raise Concern, Resign

Now they're more or less in the same order which helps with muscle memory.

Test Plan: Careful inspection.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15323
This commit is contained in:
Ben Alpert
2016-02-21 12:16:04 -08:00
committed by epriestley
parent 22d2b7ed04
commit 31927476e3
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/applications/diffusion/controller/DiffusionCommitController.php
View File

@@ -790,8 +790,6 @@ final class DiffusionCommitController extends DiffusionController {
$actions = array(); $actions = array();
$actions[PhabricatorAuditActionConstants::COMMENT] = true; $actions[PhabricatorAuditActionConstants::COMMENT] = true;
$actions[PhabricatorAuditActionConstants::ADD_CCS] = true;
$actions[PhabricatorAuditActionConstants::ADD_AUDITORS] = true;
// We allow you to accept your own commits. A use case here is that you // We allow you to accept your own commits. A use case here is that you
// notice an issue with your own commit and "Raise Concern" as an indicator // notice an issue with your own commit and "Raise Concern" as an indicator
@@ -801,7 +799,6 @@ final class DiffusionCommitController extends DiffusionController {
$actions[PhabricatorAuditActionConstants::ACCEPT] = true; $actions[PhabricatorAuditActionConstants::ACCEPT] = true;
$actions[PhabricatorAuditActionConstants::CONCERN] = true; $actions[PhabricatorAuditActionConstants::CONCERN] = true;
// To resign, a user must have authority on some request and not be the // To resign, a user must have authority on some request and not be the
// commit's author. // commit's author.
if (!$user_is_author) { if (!$user_is_author) {
@@ -837,6 +834,9 @@ final class DiffusionCommitController extends DiffusionController {
$actions[PhabricatorAuditActionConstants::CLOSE] = true; $actions[PhabricatorAuditActionConstants::CLOSE] = true;
} }
$actions[PhabricatorAuditActionConstants::ADD_AUDITORS] = true;
$actions[PhabricatorAuditActionConstants::ADD_CCS] = true;
foreach ($actions as $constant => $ignored) { foreach ($actions as $constant => $ignored) {
$actions[$constant] = $actions[$constant] =
PhabricatorAuditActionConstants::getActionName($constant); PhabricatorAuditActionConstants::getActionName($constant);