archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Remove "TB" unit tests

Browse Source 
Summary: These fail on 32-bit machines and seem not valuable enough to try to make work with `bc`, etc.

Test Plan: Ran tests (depends on D2622).

Reviewers: floatinglomas, vrana, btrahan

Reviewed By: vrana

CC: aran

Maniphest Tasks: T1298

Differential Revision: https://secure.phabricator.com/D2623
This commit is contained in:
epriestley
2012-06-01 07:51:56 -07:00
parent 06b2eb55f0
commit 3512ba2b55
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/view/utils/__tests__/PhabricatorUnitsTestCase.php
View File

@@ -18,6 +18,9 @@
final class PhabricatorUnitsTestCase extends PhabricatorTestCase { final class PhabricatorUnitsTestCase extends PhabricatorTestCase {
// NOTE: Keep tests below PHP_INT_MAX on 32-bit systems, since if you write
// larger numeric literals they'll evaluate to nonsense.
public function testByteFormatting() { public function testByteFormatting() {
$tests = array( $tests = array(
1 => '1 B', 1 => '1 B',
@@ -26,7 +29,6 @@ final class PhabricatorUnitsTestCase extends PhabricatorTestCase {
10000000 => '10 MB', 10000000 => '10 MB',
100000000 => '100 MB', 100000000 => '100 MB',
1000000000 => '1 GB', 1000000000 => '1 GB',
1000000000000 => '1 TB',
999 => '999 B', 999 => '999 B',
); );
@@ -48,7 +50,6 @@ final class PhabricatorUnitsTestCase extends PhabricatorTestCase {
'1KB' => 1000, '1KB' => 1000,
'1MB' => 1000000, '1MB' => 1000000,
'1GB' => 1000000000, '1GB' => 1000000000,
'1TB' => 1000000000000,
'1.5M' => 1500000, '1.5M' => 1500000,
'1 000' => 1000, '1 000' => 1000,
'1,234.56 KB' => 1234560, '1,234.56 KB' => 1234560,