Disambiguate isEmpty()

Summary:
Fixes T10250.

Rename the one I added to `hasAnyProperties()` for clarity.

Test Plan:
  - Viewed a project profile with content.
  - Viewed a project profile with no properties.
  - Viewed a workboard with tasks that had a mixture of additional projects and no additional projects.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10250

Differential Revision: https://secure.phabricator.com/D15151
This commit is contained in:
epriestley
2016-01-31 15:16:51 -08:00
parent 080d838c69
commit 354858e434
5 changed files with 10 additions and 15 deletions

View File

@@ -125,7 +125,7 @@ final class PhabricatorProjectProfileController
PhabricatorCustomField::ROLE_VIEW);
$field_list->appendFieldsToPropertyList($project, $viewer, $view);
if ($view->isEmpty()) {
if (!$view->hasAnyProperties()) {
return null;
}