Transactions - change show all key from "~" to "@"
Summary: (some) international keyboard layouts can not type "~" in a way as to trigger this so use "@" instead. Save the suggested "+" as that seems like it would be useful for some future "adding stuff" keyboard workflow. Pretty stoked to get this squared away as I am quite confident our unreleased product will now be a huge smashing success. Ref T6683. Test Plan: made sure my choice was okay via https://en.wikipedia.org/wiki/Dead_key#Dead_keys_on_various_keyboard_layouts; used the "@" key to show all transactions Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6683 Differential Revision: https://secure.phabricator.com/D10983
This commit is contained in:
		| @@ -8,7 +8,7 @@ | |||||||
| return array( | return array( | ||||||
|   'names' => array( |   'names' => array( | ||||||
|     'core.pkg.css' => '669b2c21', |     'core.pkg.css' => '669b2c21', | ||||||
|     'core.pkg.js' => 'da3ab00a', |     'core.pkg.js' => 'bc72b978', | ||||||
|     'darkconsole.pkg.js' => 'df001cab', |     'darkconsole.pkg.js' => 'df001cab', | ||||||
|     'differential.pkg.css' => '8af45893', |     'differential.pkg.css' => '8af45893', | ||||||
|     'differential.pkg.js' => '42c10e78', |     'differential.pkg.js' => '42c10e78', | ||||||
| @@ -420,7 +420,7 @@ return array( | |||||||
|     'rsrc/js/application/repository/repository-crossreference.js' => 'f9539603', |     'rsrc/js/application/repository/repository-crossreference.js' => 'f9539603', | ||||||
|     'rsrc/js/application/search/behavior-reorder-queries.js' => 'e9581f08', |     'rsrc/js/application/search/behavior-reorder-queries.js' => 'e9581f08', | ||||||
|     'rsrc/js/application/slowvote/behavior-slowvote-embed.js' => 'd6f54db0', |     'rsrc/js/application/slowvote/behavior-slowvote-embed.js' => 'd6f54db0', | ||||||
|     'rsrc/js/application/transactions/behavior-show-older-transactions.js' => '77fcaaee', |     'rsrc/js/application/transactions/behavior-show-older-transactions.js' => 'bde958eb', | ||||||
|     'rsrc/js/application/transactions/behavior-transaction-comment-form.js' => '9f7309fb', |     'rsrc/js/application/transactions/behavior-transaction-comment-form.js' => '9f7309fb', | ||||||
|     'rsrc/js/application/transactions/behavior-transaction-list.js' => '13c739ea', |     'rsrc/js/application/transactions/behavior-transaction-list.js' => '13c739ea', | ||||||
|     'rsrc/js/application/uiexample/JavelinViewExample.js' => 'd4a14807', |     'rsrc/js/application/uiexample/JavelinViewExample.js' => 'd4a14807', | ||||||
| @@ -623,7 +623,7 @@ return array( | |||||||
|     'javelin-behavior-phabricator-remarkup-assist' => 'e32d14ab', |     'javelin-behavior-phabricator-remarkup-assist' => 'e32d14ab', | ||||||
|     'javelin-behavior-phabricator-reveal-content' => '60821bc7', |     'javelin-behavior-phabricator-reveal-content' => '60821bc7', | ||||||
|     'javelin-behavior-phabricator-search-typeahead' => '724b1247', |     'javelin-behavior-phabricator-search-typeahead' => '724b1247', | ||||||
|     'javelin-behavior-phabricator-show-older-transactions' => '77fcaaee', |     'javelin-behavior-phabricator-show-older-transactions' => 'bde958eb', | ||||||
|     'javelin-behavior-phabricator-tooltips' => '3ee3408b', |     'javelin-behavior-phabricator-tooltips' => '3ee3408b', | ||||||
|     'javelin-behavior-phabricator-transaction-comment-form' => '9f7309fb', |     'javelin-behavior-phabricator-transaction-comment-form' => '9f7309fb', | ||||||
|     'javelin-behavior-phabricator-transaction-list' => '13c739ea', |     'javelin-behavior-phabricator-transaction-list' => '13c739ea', | ||||||
| @@ -1308,12 +1308,6 @@ return array( | |||||||
|       'javelin-install', |       'javelin-install', | ||||||
|       'javelin-util', |       'javelin-util', | ||||||
|     ), |     ), | ||||||
|     '77fcaaee' => array( |  | ||||||
|       'javelin-behavior', |  | ||||||
|       'javelin-stratcom', |  | ||||||
|       'javelin-dom', |  | ||||||
|       'phabricator-busy', |  | ||||||
|     ), |  | ||||||
|     '7814b593' => array( |     '7814b593' => array( | ||||||
|       'javelin-request', |       'javelin-request', | ||||||
|       'javelin-behavior', |       'javelin-behavior', | ||||||
| @@ -1651,6 +1645,12 @@ return array( | |||||||
|       'phabricator-tooltip', |       'phabricator-tooltip', | ||||||
|       'changeset-view-manager', |       'changeset-view-manager', | ||||||
|     ), |     ), | ||||||
|  |     'bde958eb' => array( | ||||||
|  |       'javelin-behavior', | ||||||
|  |       'javelin-stratcom', | ||||||
|  |       'javelin-dom', | ||||||
|  |       'phabricator-busy', | ||||||
|  |     ), | ||||||
|     'be807912' => array( |     'be807912' => array( | ||||||
|       'javelin-behavior', |       'javelin-behavior', | ||||||
|       'javelin-dom', |       'javelin-dom', | ||||||
|   | |||||||
| @@ -105,7 +105,7 @@ JX.behavior('phabricator-show-older-transactions', function(config) { | |||||||
|   JX.Stratcom.listen('hashchange', null, check_hash); |   JX.Stratcom.listen('hashchange', null, check_hash); | ||||||
|   check_hash(); |   check_hash(); | ||||||
|  |  | ||||||
|   new JX.KeyboardShortcut(['~'], 'Show all older changes in the timeline.') |   new JX.KeyboardShortcut(['@'], 'Show all older changes in the timeline.') | ||||||
|     .setHandler(JX.bind(null, load_older, load_all_older_callback)) |     .setHandler(JX.bind(null, load_older, load_all_older_callback)) | ||||||
|     .register(); |     .register(); | ||||||
| }); | }); | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user
	 Bob Trahan
					Bob Trahan