Fix credential upgrade issue after introduction of isLocked column

Summary: Fixes T5035. This migration isn't forward compatible after schema mutation.

Test Plan: Ran locally, will get reporting user to confirm.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: gera, epriestley

Maniphest Tasks: T5035

Differential Revision: https://secure.phabricator.com/D9101

resources/sql/patches/20131121.repocredentials.2.mig.php

@@ -86,8 +86,29 @@ foreach ($map as $credential_type => $credential_usernames) {
         ->setEditPolicy(PhabricatorPolicies::POLICY_ADMIN)
         ->setName($name)
         ->setUsername($username)
-        ->setSecretID($secret_id)
-        ->save();
+        ->setSecretID($secret_id);
+
+      $credential->setPHID($credential->generatePHID());
+
+      queryfx(
+        $credential->establishConnection('w'),
+        'INSERT INTO %T (name, credentialType, providesType, viewPolicy,
+          editPolicy, description, username, secretID, isDestroyed,
+          phid, dateCreated, dateModified)
+          VALUES (%s, %s, %s, %s, %s, %s, %s, %d, %d, %s, %d, %d)',
+        $credential->getTableName(),
+        $credential->getName(),
+        $credential->getCredentialType(),
+        $credential->getProvidesType(),
+        $credential->getViewPolicy(),
+        $credential->getEditPolicy(),
+        $credential->getDescription(),
+        $credential->getUsername(),
+        $credential->getSecretID(),
+        $credential->getIsDestroyed(),
+        $credential->getPHID(),
+        time(),
+        time());
 
       foreach ($repositories as $repository) {
         queryfx(