Move icon inside link in ActionLink

Summary: Moves the icon into the link

Test Plan: Tested a form (Phrequent), disabled, and regular action link

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T5331

Differential Revision: https://secure.phabricator.com/D9503

src/view/layout/PhabricatorActionView.php

@@ -140,7 +140,7 @@ final class PhabricatorActionView extends AphrontView {
           array(
             'class' => 'phabricator-action-view-item',
           ),
-          $this->name);
+          array($icon, $this->name));
 
         $item = phabricator_form(
           $this->user,
@@ -160,7 +160,7 @@ final class PhabricatorActionView extends AphrontView {
             'sigil' => $sigils,
             'meta' => $this->metadata,
           ),
-          $this->name);
+          array($icon, $this->name));
       }
     } else {
       $item = phutil_tag(
@@ -168,7 +168,7 @@ final class PhabricatorActionView extends AphrontView {
         array(
           'class' => 'phabricator-action-view-item',
         ),
-        $this->name);
+        array($icon, $this->name));
     }
 
     $classes = array();
@@ -186,7 +186,7 @@ final class PhabricatorActionView extends AphrontView {
       array(
         'class' => implode(' ', $classes),
       ),
-      array($icon, $item));
+      $item);
   }
 
 }