archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Allow Maniphest and Differential object lists to be filtered by user.

Browse Source
This commit is contained in:
epriestley
2011-04-11 02:03:30 -07:00
parent fb020ae27d
commit 675ce22bf4
5 changed files with 95 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
src/applications/differential/controller/revisionlist/DifferentialRevisionListController.php
View File

@@ -25,9 +25,18 @@ class DifferentialRevisionListController extends DifferentialController {
}
public function processRequest() {
$request = $this->getRequest();
$user = $request->getUser();
if ($request->isFormPost()) {
$phid_arr = $request->getArr('view_user');
$view_target = head($phid_arr);
return id(new AphrontRedirectResponse())
->setURI($request->getRequestURI()->alter('phid', $view_target));
}
$filters = array(
'Your Revisions',
'User Revisions',
'active' => array(
'name' => 'Active Revisions',
'queries' => array(
@@ -85,6 +94,7 @@ class DifferentialRevisionListController extends DifferentialController {
'All Revisions',
'allopen' => array(
'name' => 'Open',
'nofilter' => true,
'queries' => array(
array(
'query' => DifferentialRevisionListData::QUERY_ALL_OPEN,
@@ -98,15 +108,14 @@ class DifferentialRevisionListController extends DifferentialController {
$this->filter = 'active';
}
$request = $this->getRequest();
$user = $request->getUser();
$view_phid = nonempty($request->getStr('phid'), $user->getPHID());
$queries = array();
$filter = $filters[$this->filter];
foreach ($filter['queries'] as $query) {
$query_object = new DifferentialRevisionListData(
$query['query'],
array($user->getPHID()));
array($view_phid));
$queries[] = array(
'object' => $query_object,
) + $query;
@@ -114,6 +123,10 @@ class DifferentialRevisionListController extends DifferentialController {
$side_nav = new AphrontSideNavView();
$query = null;
if ($view_phid) {
$query = '?phid='.$view_phid;
}
foreach ($filters as $filter_name => $filter_desc) {
if (is_int($filter_name)) {
@@ -129,13 +142,16 @@ class DifferentialRevisionListController extends DifferentialController {
phutil_render_tag(
'a',
array(
'href' => '/differential/filter/'.$filter_name.'/',
'href' => '/differential/filter/'.$filter_name.'/'.$query,
'class' => $selected ? 'aphront-side-nav-selected' : null,
),
phutil_escape_html($filter_desc['name'])));
}
$phids = array();
$phids[$view_phid] = true;
$rev_ids = array();
foreach ($queries as $key => $query) {
$revisions = $query['object']->loadRevisions();
@@ -180,6 +196,25 @@ class DifferentialRevisionListController extends DifferentialController {
$handles = array();
}
if (empty($filters[$this->filter]['nofilter'])) {
$filter_form = id(new AphrontFormView())
->setUser($user)
->appendChild(
id(new AphrontFormTokenizerControl())
->setDatasource('/typeahead/common/users/')
->setLabel('View User')
->setName('view_user')
->setValue(
array(
$view_phid => $handles[$view_phid]->getFullName(),
))
->setLimit(1));
$filter_view = new AphrontListFilterView();
$filter_view->appendChild($filter_form);
$side_nav->appendChild($filter_view);
}
foreach ($queries as $query) {
$table = $this->renderRevisionTable(
$query['revisions'],

4
src/applications/differential/controller/revisionlist/__init__.php
View File

@@ -6,6 +6,7 @@
phutil_require_module('phabricator', 'aphront/response/redirect');
phutil_require_module('phabricator', 'applications/differential/constants/revisionstatus');
phutil_require_module('phabricator', 'applications/differential/controller/base');
phutil_require_module('phabricator', 'applications/differential/data/revisionlist');
@@ -13,6 +14,9 @@ phutil_require_module('phabricator', 'applications/differential/storage/revision
phutil_require_module('phabricator', 'applications/phid/handle/data');
phutil_require_module('phabricator', 'storage/queryfx');
phutil_require_module('phabricator', 'view/control/table');
phutil_require_module('phabricator', 'view/form/base');
phutil_require_module('phabricator', 'view/form/control/tokenizer');
phutil_require_module('phabricator', 'view/layout/listfilter');
phutil_require_module('phabricator', 'view/layout/panel');
phutil_require_module('phabricator', 'view/layout/sidenav');
phutil_require_module('phabricator', 'view/utils');