archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Improve unit test detail panel in Differential.

Browse Source
This commit is contained in:
epriestley
2011-04-10 17:47:47 -07:00
parent 720bf02570
commit fb020ae27d
3 changed files with 580 additions and 564 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1124
src/__celerity_resource_map__.php
View File

File diff suppressed because it is too large Load Diff

10
src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php
View File

@@ -305,11 +305,17 @@ class DifferentialRevisionViewController extends DifferentialController {
$name = phutil_escape_html(idx($test, 'name'));
$result = phutil_escape_html(idx($test, 'result'));
$userdata = phutil_escape_html(idx($test, 'userdata'));
if (strlen($userdata) > 256) {
$userdata = substr($userdata, 0, 256).'...';
}
$userdata = str_replace("\n", '<br />', $userdata);
$unit_messages[] =
'<tr>'.
'<th>'.$name.'</th>'.
'<th class="unit-test-result result-'.$result.'">'.
strtoupper($result).
'<th class="unit-test-result">'.
'<div class="result-'.$result.'">'.
strtoupper($result).
'</div>'.
'</th>'.
'<td>'.$userdata.'</td>'.
'</tr>';

10
webroot/rsrc/css/application/differential/revision-detail.css
View File

@@ -66,8 +66,18 @@
padding: 4px 8px;
}
.differential-unit-table th.unit-test-result {
padding: 0;
}
.differential-unit-table .result-fail {
background: #ff3333;
padding: 4px 8px;
}
.differential-unit-table .result-unsound {
background: #cc33cc;
padding: 4px 8px;
}
.differential-unit-table td {