Allow MFA task edits to go through on workboards
Summary: Depends on D20272. Ref T13074. When a task requires MFA to edit, you currently get a fatal. Provide a cancel URI so the prompt works and the edit can go through. Test Plan: - Locked a task, dragged it on a workboard. - Before: fatal trying to build an MFA gate. - After: got MFA gated, answered prompt, action went through. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13074 Differential Revision: https://secure.phabricator.com/D20273
This commit is contained in:
@@ -43,6 +43,13 @@ final class PhabricatorProjectMoveController
|
|||||||
return new Aphront404Response();
|
return new Aphront404Response();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
$cancel_uri = $this->getApplicationURI(
|
||||||
|
new PhutilURI(
|
||||||
|
urisprintf('board/%d/', $project->getID()),
|
||||||
|
array(
|
||||||
|
'order' => $order,
|
||||||
|
)));
|
||||||
|
|
||||||
$board_phid = $project->getPHID();
|
$board_phid = $project->getPHID();
|
||||||
|
|
||||||
$object = id(new ManiphestTaskQuery())
|
$object = id(new ManiphestTaskQuery())
|
||||||
@@ -107,7 +114,8 @@ final class PhabricatorProjectMoveController
|
|||||||
->setActor($viewer)
|
->setActor($viewer)
|
||||||
->setContinueOnMissingFields(true)
|
->setContinueOnMissingFields(true)
|
||||||
->setContinueOnNoEffect(true)
|
->setContinueOnNoEffect(true)
|
||||||
->setContentSourceFromRequest($request);
|
->setContentSourceFromRequest($request)
|
||||||
|
->setCancelURI($cancel_uri);
|
||||||
|
|
||||||
$editor->applyTransactions($object, $xactions);
|
$editor->applyTransactions($object, $xactions);
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user