archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Consolidate Conpherence frame rendering

Browse Source 
Summary: Conpherence frame rendering is spread out a bit across ConpherenceController, ConpherenceListController, and previously ConpherenceNewController. I want to let the Thread and Widget controllers render the frame for mobile. Ref T2421.

Test Plan: Viewed conpherences, switched between conpherences.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2421

Differential Revision: https://secure.phabricator.com/D5501
This commit is contained in:
epriestley
2013-04-01 12:43:07 -07:00
parent 7b07f6ab3d
commit 7ef2edd300
5 changed files with 96 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
src/applications/conpherence/controller/ConpherenceListController.php
View File

@@ -48,7 +48,10 @@ final class ConpherenceListController extends
$this->loadStartingConpherences($current_selection_epoch);
$nav = $this->buildSideNavView();
$main_pane = $this->renderEmptyMainPane();
$main_pane = id(new ConpherenceLayoutView())
->setBaseURI($this->getApplicationURI())
->setSelectedConpherencePHID($this->getSelectedConpherencePHID());
$nav->appendChild(
array(
$main_pane,
@@ -62,54 +65,4 @@ final class ConpherenceListController extends
));
}
private function renderEmptyMainPane() {
$this->initJavelinBehaviors(true);
return javelin_tag(
'div',
array(
'id' => 'conpherence-main-pane',
'sigil' => 'conpherence-layout'
),
array(
javelin_tag(
'div',
array(
'class' => 'conpherence-header-pane',
'id' => 'conpherence-header-pane',
'sigil' => 'conpherence-header',
),
''),
phutil_tag(
'div',
array(
'class' => 'conpherence-widget-pane',
'id' => 'conpherence-widget-pane'
),
''),
javelin_tag(
'div',
array(
'class' => 'conpherence-message-pane',
'id' => 'conpherence-message-pane'
),
array(
javelin_tag(
'div',
array(
'class' => 'conpherence-messages',
'id' => 'conpherence-messages',
'sigil' => 'conpherence-messages',
),
''),
phutil_tag(
'div',
array(
'id' => 'conpherence-form'
),
'')
))
));
}
}