Simplify "Blame Revision" field in Differential
Summary: Ref T11114. This is still mostly in use, but toss a few commit message parsing things. Test Plan: Viewed/edited/upated blame rev from CLI/web UI. Reviewers: chad Reviewed By: chad Maniphest Tasks: T11114 Differential Revision: https://secure.phabricator.com/D17089
This commit is contained in:
@@ -32,6 +32,10 @@ final class DifferentialBlameRevisionField
|
||||
}
|
||||
|
||||
public function renderPropertyViewValue(array $handles) {
|
||||
if (!strlen($this->getValue())) {
|
||||
return null;
|
||||
}
|
||||
|
||||
return $this->getValue();
|
||||
}
|
||||
|
||||
@@ -91,25 +95,6 @@ final class DifferentialBlameRevisionField
|
||||
return true;
|
||||
}
|
||||
|
||||
public function shouldAllowEditInCommitMessage() {
|
||||
return true;
|
||||
}
|
||||
|
||||
public function shouldOverwriteWhenCommitMessageIsEdited() {
|
||||
return true;
|
||||
}
|
||||
|
||||
public function getCommitMessageLabels() {
|
||||
return array(
|
||||
'Blame Revision',
|
||||
'Blame Rev',
|
||||
);
|
||||
}
|
||||
|
||||
public function renderCommitMessageValue(array $handles) {
|
||||
return $this->getValue();
|
||||
}
|
||||
|
||||
public function shouldAppearInConduitDictionary() {
|
||||
return true;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user