archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix displaying of inlines related both to visible and hidden diff

Browse Source 
Summary: I tried also filling the column by empty space but this looks better.

Test Plan: Displayed a comment both with visible and hidden inlines.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T1216

Differential Revision: https://secure.phabricator.com/D2789
This commit is contained in:
vrana
2012-06-18 18:05:06 -07:00
parent c762050b7c
commit 8a8a48cc8f
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/infrastructure/diff/view/PhabricatorInlineSummaryView.php
View File

@@ -78,11 +78,9 @@ final class PhabricatorInlineSummaryView extends AphrontView {
} }
} }
$cols = $has_where ? 3 : 2;
$rows[] = $rows[] =
'<tr>'. '<tr>'.
'<th colspan="'.$cols.'">'. '<th colspan="3">'.
phutil_escape_html($group). phutil_escape_html($group).
'</th>'. '</th>'.
'</tr>'; '</tr>';
@@ -123,6 +121,7 @@ final class PhabricatorInlineSummaryView extends AphrontView {
$where = idx($item, 'where'); $where = idx($item, 'where');
$colspan = ($has_where ? '' : ' colspan="2"');
$rows[] = $rows[] =
'<tr>'. '<tr>'.
'<td class="inline-line-number">'.$lines.'</td>'. '<td class="inline-line-number">'.$lines.'</td>'.
@@ -131,7 +130,7 @@ final class PhabricatorInlineSummaryView extends AphrontView {
phutil_escape_html($where). phutil_escape_html($where).
'</td>' '</td>'
: null). : null).
'<td class="inline-summary-content">'. '<td class="inline-summary-content"'.$colspan.'>'.
'<div class="phabricator-remarkup">'. '<div class="phabricator-remarkup">'.
$item['content']. $item['content'].
'</div>'. '</div>'.